diff mbox series

[pseudo,15/23] pseudo.h: Avoid accessing unallocated memory

Message ID	1783039578-31531-16-git-send-email-mark.hatle@kernel.crashing.org
State	New
Headers	show Return-Path: <mark.hatle@kernel.crashing.org> ip: 63.228.1.57, mailfrom: mark.hatle@kernel.crashing.org) From: Mark Hatle <mark.hatle@kernel.crashing.org> To: yocto-patches@lists.yoctoproject.org Cc: richard.purdie@linuxfoundation.org, frezidok1@gmail.com Subject: [pseudo][PATCH 15/23] pseudo.h: Avoid accessing unallocated memory Date: Thu, 2 Jul 2026 19:46:10 -0500 Message-Id: <1783039578-31531-16-git-send-email-mark.hatle@kernel.crashing.org> In-Reply-To: <1783039578-31531-1-git-send-email-mark.hatle@kernel.crashing.org> References: <1783039578-31531-1-git-send-email-mark.hatle@kernel.crashing.org>
Series	Create new pseudo 1.99.0 version \| expand [pseudo,00/23] Create new pseudo 1.99.0 version [pseudo,01/23] Makefile.in: Move version to 1.99.0 to prep for 2.0 development [pseudo,02/23] pseudo_util: Add log severity flags [pseudo,03/23] pseudo: Add new logging macros [pseudo,04/23] pseudo_util: Change pseudo_diag() calls to appropriate logging macros [pseudo,05/23] pseudo_db: Change pseudo_diag() calls to appropriate macros [pseudo,06/23] pseudo_client: Change pseudo_diag() calls to appropriate macros [pseudo,07/23] pseudo_server: Change pseudo_diag() calls to appropriate macros [pseudo,08/23] pseudo.c: Change pseudo_diag() calls to appropriate macros [pseudo,09/23] pseudolog.c: Change pseudo_diag() calls to appropriate macros [pseudo,10/23] wrappers: Change pseudo_diag() calls to appropriate macros [pseudo,11/23] pseudo: Change pseudo_diag() name to pseudo_log() [pseudo,12/23] pseudo_util: Add default log severity values [pseudo,13/23] pseudo_util.c: strchr now returns const char [pseudo,14/23] test/test-openat2-func.c: Remove unusuaed saved_errno [pseudo,15/23] pseudo.h: Avoid accessing unallocated memory [pseudo,16/23] pseudo_util: Avoid accidental free calls for without_libpseudo() [pseudo,17/23] pseudo_util: Ensure pseudo_setupenvp handles memory consistently [pseudo,18/23] pseudo_util: Avoid a memory leak in pseudo_dropenv() [pseudo,19/23] pseudo_util: Clean up memory handling for setupenvp results [pseudo,20/23] exec*: Replace bash workaround to avoid memory corruption [pseudo,21/23] pseudo_util: Correctly free memory allocated by pseudo_setupenvp [pseudo,22/23] test-bash-exec-env: Add bash env test case [pseudo,23/23] test: various: Move to makefile compilation

Commit Message

Mark Hatle July 3, 2026, 12:46 a.m. UTC

From: Richard Purdie <richard.purdie@linuxfoundation.org>

We can call STARTSWITH in cases where the item being searched for is longer
than the string itself. Switch from memcmp to strncmp to avoid accessing
unassigned memory.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Message-ID: <20260701131336.3578279-1-richard.purdie@linuxfoundation.org>
Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
---
 pseudo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/pseudo.h b/pseudo.h
index 66aa70e..ae1fe0d 100644
--- a/pseudo.h
+++ b/pseudo.h
@@ -119,7 +119,7 @@  extern char *pseudo_version;
  #define PSEUDO_LIBDIR "lib"
 #endif
 
-#define STARTSWITH(x, y) (!memcmp((x), (y), sizeof(y) - 1))
+#define STARTSWITH(x, y) (strncmp(y, x, strlen(y)) == 0)
 
 #ifndef PSEUDO_LOCALSTATEDIR
  #define PSEUDO_LOCALSTATEDIR "var/pseudo"