diff mbox series

[meta-mingw] mingw-w64: use correct path to license file

Message ID 20250820065756.1295786-1-samuli.piippo@qt.io
State New
Headers show
Series [meta-mingw] mingw-w64: use correct path to license file | expand

Commit Message

Samuli Piippo Aug. 20, 2025, 6:57 a.m. UTC
Amend b7ac9777ad0c4512f1a63aa6bec4ecedd91783e1 and use UNPACKDIR
also for the license file.

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
 recipes-devtools/mingw-w64/mingw-w64.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Samuli Piippo Nov. 12, 2025, 7:44 a.m. UTC | #1
The yocto autobuilder doesn't seem to catch this error as the builds pass
with the patch still in master-next.
Should there be some improvement on the autobuilder scripts as well?

-samuli

On Wed, 20 Aug 2025 at 09:58, Samuli Piippo <samuli.piippo@gmail.com> wrote:

> Amend b7ac9777ad0c4512f1a63aa6bec4ecedd91783e1 and use UNPACKDIR
> also for the license file.
>
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> ---
>  recipes-devtools/mingw-w64/mingw-w64.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/mingw-w64/mingw-w64.inc
> b/recipes-devtools/mingw-w64/mingw-w64.inc
> index 97315f4..a24e96c 100644
> --- a/recipes-devtools/mingw-w64/mingw-w64.inc
> +++ b/recipes-devtools/mingw-w64/mingw-w64.inc
> @@ -1,5 +1,5 @@
>  LICENSE = "ZPL-2.1"
> -LIC_FILES_CHKSUM =
> "file://${WORKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
> +LIC_FILES_CHKSUM =
> "file://${UNPACKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
>
>  COMPATIBLE_HOST = ".*-mingw.*"
>
> --
> 2.43.0
>
>
Joshua Watt Nov. 12, 2025, 3:16 p.m. UTC | #2
On Wed, Nov 12, 2025 at 12:44 AM Samuli Piippo <samuli.piippo@gmail.com> wrote:
>
> The yocto autobuilder doesn't seem to catch this error as the builds pass with the patch still in master-next.
> Should there be some improvement on the autobuilder scripts as well?

I haven't run master-next build on the AB yet.

>
> -samuli
>
> On Wed, 20 Aug 2025 at 09:58, Samuli Piippo <samuli.piippo@gmail.com> wrote:
>>
>> Amend b7ac9777ad0c4512f1a63aa6bec4ecedd91783e1 and use UNPACKDIR
>> also for the license file.
>>
>> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
>> ---
>>  recipes-devtools/mingw-w64/mingw-w64.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-devtools/mingw-w64/mingw-w64.inc b/recipes-devtools/mingw-w64/mingw-w64.inc
>> index 97315f4..a24e96c 100644
>> --- a/recipes-devtools/mingw-w64/mingw-w64.inc
>> +++ b/recipes-devtools/mingw-w64/mingw-w64.inc
>> @@ -1,5 +1,5 @@
>>  LICENSE = "ZPL-2.1"
>> -LIC_FILES_CHKSUM = "file://${WORKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
>> +LIC_FILES_CHKSUM = "file://${UNPACKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
>>
>>  COMPATIBLE_HOST = ".*-mingw.*"
>>
>> --
>> 2.43.0
>>
Joshua Watt Nov. 12, 2025, 3:18 p.m. UTC | #3
On Wed, Nov 12, 2025 at 8:16 AM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> On Wed, Nov 12, 2025 at 12:44 AM Samuli Piippo <samuli.piippo@gmail.com> wrote:
> >
> > The yocto autobuilder doesn't seem to catch this error as the builds pass with the patch still in master-next.
> > Should there be some improvement on the autobuilder scripts as well?
>
> I haven't run master-next build on the AB yet.

Although, that doesn't make sense after thinking for 2 seconds,
because your asking why the AB didn't catch the initial problem that
you are fixing here :)

IDK why that is TBH.

>
> >
> > -samuli
> >
> > On Wed, 20 Aug 2025 at 09:58, Samuli Piippo <samuli.piippo@gmail.com> wrote:
> >>
> >> Amend b7ac9777ad0c4512f1a63aa6bec4ecedd91783e1 and use UNPACKDIR
> >> also for the license file.
> >>
> >> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> >> ---
> >>  recipes-devtools/mingw-w64/mingw-w64.inc | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-devtools/mingw-w64/mingw-w64.inc b/recipes-devtools/mingw-w64/mingw-w64.inc
> >> index 97315f4..a24e96c 100644
> >> --- a/recipes-devtools/mingw-w64/mingw-w64.inc
> >> +++ b/recipes-devtools/mingw-w64/mingw-w64.inc
> >> @@ -1,5 +1,5 @@
> >>  LICENSE = "ZPL-2.1"
> >> -LIC_FILES_CHKSUM = "file://${WORKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
> >> +LIC_FILES_CHKSUM = "file://${UNPACKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
> >>
> >>  COMPATIBLE_HOST = ".*-mingw.*"
> >>
> >> --
> >> 2.43.0
> >>
diff mbox series

Patch

diff --git a/recipes-devtools/mingw-w64/mingw-w64.inc b/recipes-devtools/mingw-w64/mingw-w64.inc
index 97315f4..a24e96c 100644
--- a/recipes-devtools/mingw-w64/mingw-w64.inc
+++ b/recipes-devtools/mingw-w64/mingw-w64.inc
@@ -1,5 +1,5 @@ 
 LICENSE = "ZPL-2.1"
-LIC_FILES_CHKSUM = "file://${WORKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
+LIC_FILES_CHKSUM = "file://${UNPACKDIR}/mingw-w64-v${PV}/COPYING;md5=bb936f0e04d8f1e19ad545100cee9654"
 
 COMPATIBLE_HOST = ".*-mingw.*"