diff mbox series

[meta-rockchip] linux-torvalds-next: ignore TMPDIR issues

Message ID 20240715143149.16336-1-twoerner@gmail.com
State New
Headers show
Series [meta-rockchip] linux-torvalds-next: ignore TMPDIR issues | expand

Commit Message

Trevor Woerner July 15, 2024, 2:31 p.m. UTC
oe-core has raised the status of some checks from warnings to errors. Ignore
the "...contains references to TMPDIR..." error when building the
torvalds-next kernel.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 recipes-kernel/linux/linux-torvalds-next_git.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Quentin Schulz July 15, 2024, 2:42 p.m. UTC | #1
Hi Trevor,

On 7/15/24 4:31 PM, Trevor Woerner via lists.yoctoproject.org wrote:
> oe-core has raised the status of some checks from warnings to errors. Ignore
> the "...contains references to TMPDIR..." error when building the
> torvalds-next kernel.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>   recipes-kernel/linux/linux-torvalds-next_git.bb | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb
> index c0ac1de22005..6f3db7c61bdf 100644
> --- a/recipes-kernel/linux/linux-torvalds-next_git.bb
> +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb
> @@ -5,6 +5,7 @@ SECTION = "kernel"
>   LICENSE = "GPL-2.0-only"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46"
>   
> +ERROR_QA:remove = "buildpaths"

I think I've had those as warnings already and I've patched the files 
triggering those in my downstream tree, and Bruce as well I think in 
linux-yocto. We should really at least notify upstream to check if there 
isn't anything we can do about it to avoid silencing warnings/errors or 
carrying patches.

https://git.theobroma-systems.com/jaguar-linux.git/commit/?id=55b4a6e969981d21b320a90a6ba1b8f89cda80f0
https://git.theobroma-systems.com/jaguar-linux.git/commit/?id=01a5c521907b714dc9bbde9dc6a8e06b1894d019

In any case,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Richard Purdie July 15, 2024, 2:47 p.m. UTC | #2
On Mon, 2024-07-15 at 10:31 -0400, Trevor Woerner via
lists.yoctoproject.org wrote:
> oe-core has raised the status of some checks from warnings to errors.
> Ignore
> the "...contains references to TMPDIR..." error when building the
> torvalds-next kernel.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  recipes-kernel/linux/linux-torvalds-next_git.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb
> b/recipes-kernel/linux/linux-torvalds-next_git.bb
> index c0ac1de22005..6f3db7c61bdf 100644
> --- a/recipes-kernel/linux/linux-torvalds-next_git.bb
> +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb
> @@ -5,6 +5,7 @@ SECTION = "kernel"
>  LICENSE = "GPL-2.0-only"
>  LIC_FILES_CHKSUM =
> "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46"
>  
> +ERROR_QA:remove = "buildpaths"
>  DEFAULT_PREFERENCE = "-1"
>  COMPATIBLE_MACHINE = "^$"
>  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"

You may want to add that to WARN_QA so you remember to at least look at
them a some point. They're a sign of non-reproducible builds for a
start and break hash equivalence sstate reuse.

Cheers,

Richard
Trevor Woerner July 15, 2024, 3:23 p.m. UTC | #3
On Mon 2024-07-15 @ 03:47:11 PM, Richard Purdie via lists.yoctoproject.org wrote:
> On Mon, 2024-07-15 at 10:31 -0400, Trevor Woerner via
> lists.yoctoproject.org wrote:
> > oe-core has raised the status of some checks from warnings to errors.
> > Ignore
> > the "...contains references to TMPDIR..." error when building the
> > torvalds-next kernel.
> > 
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> >  recipes-kernel/linux/linux-torvalds-next_git.bb | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb
> > b/recipes-kernel/linux/linux-torvalds-next_git.bb
> > index c0ac1de22005..6f3db7c61bdf 100644
> > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb
> > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb
> > @@ -5,6 +5,7 @@ SECTION = "kernel"
> >  LICENSE = "GPL-2.0-only"
> >  LIC_FILES_CHKSUM =
> > "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46"
> >  
> > +ERROR_QA:remove = "buildpaths"
> >  DEFAULT_PREFERENCE = "-1"
> >  COMPATIBLE_MACHINE = "^$"
> >  COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"
> 
> You may want to add that to WARN_QA so you remember to at least look at
> them a some point. They're a sign of non-reproducible builds for a
> start and break hash equivalence sstate reuse.

When I added support for these two MACHINEs in meta-rockchip
(radxa-zero-3{e|w}), support wasn't even yet available in linux-yocto-dev, I
had to use Linus' -next tree to get support (which is why I created a
linux-torvalds-next recipe). In time support will hopefully
trickle down into linux-yocto-dev, then linux-yocto, at which points I will
discard linux-torvalds-next for fully upstream oe-core support.

I could add a WARN for this, but I'm probably not going to get around to
looking into it and fixing it, I doubt anyone else will (since it's a recipe
specific to meta-rockchip), and fixing it won't be required once we switch to
something from oe-core.

> 
> Cheers,
> 
> Richard
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#430): https://lists.yoctoproject.org/g/yocto-patches/message/430
> Mute This Topic: https://lists.yoctoproject.org/mt/107232153/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>
Trevor Woerner July 16, 2024, 3:07 p.m. UTC | #4
On Mon 2024-07-15 @ 10:31:49 AM, Trevor Woerner wrote:
> oe-core has raised the status of some checks from warnings to errors. Ignore
> the "...contains references to TMPDIR..." error when building the
> torvalds-next kernel.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  recipes-kernel/linux/linux-torvalds-next_git.bb | 1 +
>  1 file changed, 1 insertion(+)

Applied to meta-rockchip, master branch.
diff mbox series

Patch

diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb
index c0ac1de22005..6f3db7c61bdf 100644
--- a/recipes-kernel/linux/linux-torvalds-next_git.bb
+++ b/recipes-kernel/linux/linux-torvalds-next_git.bb
@@ -5,6 +5,7 @@  SECTION = "kernel"
 LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46"
 
+ERROR_QA:remove = "buildpaths"
 DEFAULT_PREFERENCE = "-1"
 COMPATIBLE_MACHINE = "^$"
 COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3"