diff mbox series

[yocto-autobuilder-helper] config.json: Make meta-oe source mirror config wider coverage

Message ID 20231024110322.1239362-1-richard.purdie@linuxfoundation.org
State New
Headers show
Series [yocto-autobuilder-helper] config.json: Make meta-oe source mirror config wider coverage | expand

Commit Message

Richard Purdie Oct. 24, 2023, 11:03 a.m. UTC
Some recipes depend on DISTRO_FEATURES, commercial licensing or compiler
config like fortran. Set these things so that we get wider soruce mirror
coverage and fewer warnings.

'commercial' license usage is ok here since we're not building and then
shipping any binaries or using it, only mirroring the source code.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 config.json | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Khem Raj Oct. 24, 2023, 5:15 p.m. UTC | #1
On 10/24/23 4:03 AM, Richard Purdie wrote:
> Some recipes depend on DISTRO_FEATURES, commercial licensing or compiler
> config like fortran. Set these things so that we get wider soruce mirror
> coverage and fewer warnings.
> 
> 'commercial' license usage is ok here since we're not building and then
> shipping any binaries or using it, only mirroring the source code.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   config.json | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/config.json b/config.json
> index 0c35632..61cf374 100644
> --- a/config.json
> +++ b/config.json
> @@ -1451,6 +1451,12 @@
>                   "${BUILDDIR}/../meta-openembedded/meta-initramfs",
>                   "${BUILDDIR}/../meta-openembedded/meta-webserver"
>               ],
> +            "extravars" : [
> +                "LICENSE_FLAGS_ACCEPTED = 'commercial'",
> +                "DISTRO_FEATURES:append = ' pam systemd usrmerge'",
> +                "FORTRAN:forcevariable = ',fortran'",
> +                "RUNTIMETARGET:append:pn-gcc-runtime = ' libquadmath'"

I think RUNTIMETARGET should automatically be appended with libquadmath 
if FORTRAN is set.

> +            ],
>               "step1" : {
>                   "shortname" : "Sources pre-fetching",
>                   "BBTARGETS" : "universe -c fetch -k",
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> You automatically follow any topics you start or reply to.
> View/Reply Online (#61464): https://lists.yoctoproject.org/g/yocto/message/61464
> Mute This Topic: https://lists.yoctoproject.org/mt/102155468/1997914
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/leave/6692173/1997914/1837948400/xyzzy [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Richard Purdie Oct. 24, 2023, 8:34 p.m. UTC | #2
On Tue, 2023-10-24 at 10:15 -0700, Khem Raj wrote:
> On 10/24/23 4:03 AM, Richard Purdie wrote:
> > Some recipes depend on DISTRO_FEATURES, commercial licensing or compiler
> > config like fortran. Set these things so that we get wider soruce mirror
> > coverage and fewer warnings.
> > 
> > 'commercial' license usage is ok here since we're not building and then
> > shipping any binaries or using it, only mirroring the source code.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >   config.json | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/config.json b/config.json
> > index 0c35632..61cf374 100644
> > --- a/config.json
> > +++ b/config.json
> > @@ -1451,6 +1451,12 @@
> >                   "${BUILDDIR}/../meta-openembedded/meta-initramfs",
> >                   "${BUILDDIR}/../meta-openembedded/meta-webserver"
> >               ],
> > +            "extravars" : [
> > +                "LICENSE_FLAGS_ACCEPTED = 'commercial'",
> > +                "DISTRO_FEATURES:append = ' pam systemd usrmerge'",
> > +                "FORTRAN:forcevariable = ',fortran'",
> > +                "RUNTIMETARGET:append:pn-gcc-runtime = ' libquadmath'"
> 
> I think RUNTIMETARGET should automatically be appended with libquadmath 
> if FORTRAN is set.

Perhaps but that is a change to work on in OE-Core and isn't going to
happen overnight or in previous releases.

Improvements welcome there or perhaps a bug to track it at least.

Cheers,

Richard
Martin Jansa Oct. 27, 2023, 11:04 a.m. UTC | #3
I think RUNTIMETARGET is already set correctly when fortran is correctly
enabled as in:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/gcc/gcc-runtime.inc#n45

since 2016:
https://git.openembedded.org/openembedded-core/commit/meta/recipes-devtools/gcc/gcc-runtime.inc?id=80333155db8fa53fb52898c4312daa656de89c3b

On Tue, Oct 24, 2023 at 10:34 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2023-10-24 at 10:15 -0700, Khem Raj wrote:
> > On 10/24/23 4:03 AM, Richard Purdie wrote:
> > > Some recipes depend on DISTRO_FEATURES, commercial licensing or
> compiler
> > > config like fortran. Set these things so that we get wider soruce
> mirror
> > > coverage and fewer warnings.
> > >
> > > 'commercial' license usage is ok here since we're not building and then
> > > shipping any binaries or using it, only mirroring the source code.
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > ---
> > >   config.json | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/config.json b/config.json
> > > index 0c35632..61cf374 100644
> > > --- a/config.json
> > > +++ b/config.json
> > > @@ -1451,6 +1451,12 @@
> > >                   "${BUILDDIR}/../meta-openembedded/meta-initramfs",
> > >                   "${BUILDDIR}/../meta-openembedded/meta-webserver"
> > >               ],
> > > +            "extravars" : [
> > > +                "LICENSE_FLAGS_ACCEPTED = 'commercial'",
> > > +                "DISTRO_FEATURES:append = ' pam systemd usrmerge'",
> > > +                "FORTRAN:forcevariable = ',fortran'",
> > > +                "RUNTIMETARGET:append:pn-gcc-runtime = ' libquadmath'"
> >
> > I think RUNTIMETARGET should automatically be appended with libquadmath
> > if FORTRAN is set.
>
> Perhaps but that is a change to work on in OE-Core and isn't going to
> happen overnight or in previous releases.
>
> Improvements welcome there or perhaps a bug to track it at least.
>
> Cheers,
>
> Richard
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#61472):
> https://lists.yoctoproject.org/g/yocto/message/61472
> Mute This Topic: https://lists.yoctoproject.org/mt/102155468/3617156
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe:
> https://lists.yoctoproject.org/g/yocto/leave/6691508/3617156/1288174273/xyzzy
> [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/config.json b/config.json
index 0c35632..61cf374 100644
--- a/config.json
+++ b/config.json
@@ -1451,6 +1451,12 @@ 
                 "${BUILDDIR}/../meta-openembedded/meta-initramfs",
                 "${BUILDDIR}/../meta-openembedded/meta-webserver"
             ],
+            "extravars" : [
+                "LICENSE_FLAGS_ACCEPTED = 'commercial'",
+                "DISTRO_FEATURES:append = ' pam systemd usrmerge'",
+                "FORTRAN:forcevariable = ',fortran'",
+                "RUNTIMETARGET:append:pn-gcc-runtime = ' libquadmath'"
+            ],
             "step1" : {
                 "shortname" : "Sources pre-fetching",
                 "BBTARGETS" : "universe -c fetch -k",