diff mbox series

[autobuilder,v2,1/1] builders: update send-qa-email name

Message ID 20230123123343.37841-2-alexis.lothore@bootlin.com
State New
Headers show
Series rename send-qa-email in builder | expand

Commit Message

Alexis Lothoré Jan. 23, 2023, 12:33 p.m. UTC 
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
 builders.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Jan. 23, 2023, 1:55 p.m. UTC | #1 
On Mon, 2023-01-23 at 13:33 +0100, Alexis Lothoré via
lists.yoctoproject.org wrote:
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
>  builders.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builders.py b/builders.py
> index d942346..b052f71 100644
> --- a/builders.py
> +++ b/builders.py
> @@ -322,7 +322,7 @@ def create_parent_builder_factory(buildername, waitname):
>  
>      factory.addStep(steps.ShellCommand(
>          command=[
> -            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send-qa-email"),
> +            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send_qa_email.py"),
>              util.Property("send_email"),
>              util.Interpolate("%(prop:builddir)s/layerinfo.json"),
>              util.Interpolate("%(prop:sharedrepolocation)s"),

This gets a little tricky. Changes to autobuilder-helper are easy but
if we change autobuilder2, it has to match changes on all active
autobuilder-helper branches.

Cheers,

Richard
Richard Purdie Jan. 23, 2023, 4:04 p.m. UTC | #2 
On Mon, 2023-01-23 at 13:55 +0000, Richard Purdie via
lists.yoctoproject.org wrote:
> On Mon, 2023-01-23 at 13:33 +0100, Alexis Lothoré via
> lists.yoctoproject.org wrote:
> > Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> > ---
> >  builders.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/builders.py b/builders.py
> > index d942346..b052f71 100644
> > --- a/builders.py
> > +++ b/builders.py
> > @@ -322,7 +322,7 @@ def create_parent_builder_factory(buildername, waitname):
> >  
> >      factory.addStep(steps.ShellCommand(
> >          command=[
> > -            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send-qa-email"),
> > +            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send_qa_email.py"),
> >              util.Property("send_email"),
> >              util.Interpolate("%(prop:builddir)s/layerinfo.json"),
> >              util.Interpolate("%(prop:sharedrepolocation)s"),
> 
> This gets a little tricky. Changes to autobuilder-helper are easy but
> if we change autobuilder2, it has to match changes on all active
> autobuilder-helper branches.

Thinking about this a little, we can probably push symlinks into the
older release branches, at least until we consider backporting some
changes.

Cheers,

Richard
diff mbox series

Patch

diff --git a/builders.py b/builders.py
index d942346..b052f71 100644
--- a/builders.py
+++ b/builders.py
@@ -322,7 +322,7 @@  def create_parent_builder_factory(buildername, waitname):
 
     factory.addStep(steps.ShellCommand(
         command=[
-            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send-qa-email"),
+            util.Interpolate("%(prop:builddir)s/yocto-autobuilder-helper/scripts/send_qa_email.py"),
             util.Property("send_email"),
             util.Interpolate("%(prop:builddir)s/layerinfo.json"),
             util.Interpolate("%(prop:sharedrepolocation)s"),