diff mbox series

[2/4] xfce4-sensors-plugin: Fix aggregate init failure with gcc16

Message ID 20260609065712.2888126-2-mingli.yu@windriver.com
State Under Review
Headers show
Series [1/4] xfce4-cpufreq-plugin: Fix aggregate init failure with gcc16 | expand

Commit Message

Yu, Mingli June 9, 2026, 6:57 a.m. UTC 
From: Mingli Yu <mingli.yu@windriver.com>

Fixes:
  ../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.cc:25:37: error: no matching function for call to 'xfce4::PluginSize::PluginSize(<brace-enclosed initializer list>)'
   25 | const PluginSize      RECTANGLE{true}, SQUARE{false};
      |                                     ^
  • there are 2 candidates
 In file included from ../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.cc:21:
    • candidate 1: 'constexpr xfce4::PluginSize::PluginSize(const xfce4::PluginSize&)'
      ../../../sources/xfce4-sensors-plugin-1.5.0/xfce4++/util/gtk.h:64:8:
         64 | struct PluginSize {
            |        ^~~~~~~~~~
      • no known conversion for argument 1 from 'bool' to 'const xfce4::PluginSize&'
    • candidate 2: 'constexpr xfce4::PluginSize::PluginSize(xfce4::PluginSize&&)'
      • no known conversion for argument 1 from 'bool' to 'xfce4::PluginSize&&'

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 ...ix-aggregate-init-failure-with-gcc16.patch | 49 +++++++++++++++++++
 .../sensors/xfce4-sensors-plugin_1.5.0.bb     |  4 +-
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
diff mbox series

Patch

diff --git a/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch b/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
new file mode 100644
index 0000000000..6cace545c5
--- /dev/null
+++ b/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
@@ -0,0 +1,49 @@ 
+From 72f7f681c11d3f8a8ba0f4fb83d397108e16309a Mon Sep 17 00:00:00 2001
+From: Mingli Yu <mingli.yu@windriver.com>
+Date: Wed, 3 Jun 2026 00:00:00 -0700
+Subject: [PATCH] Fix aggregate init failure with gcc16
+
+Replace deleted default constructors with explicit bool constructors
+to fix aggregate init failure with gcc16.
+
+Upstream-Status: Submitted [https://gitlab.xfce.org/panel-plugins/xfce4-sensors-plugin/-/merge_requests/78]
+
+Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
+---
+ xfce4++/util/gtk.h | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/xfce4++/util/gtk.h b/xfce4++/util/gtk.h
+index 1443cb2..ef03dd1 100644
+--- a/xfce4++/util/gtk.h
++++ b/xfce4++/util/gtk.h
+@@ -63,22 +63,22 @@ void connect(GtkToggleButton *widget, const char *signal, const std::function<vo
+ 
+ struct PluginSize {
+     bool rectangle; /* Whether the panel plugin size is forced to be a square. Otherwise, the plugin can be a rectangle. */
+-    PluginSize() = delete;
++    constexpr explicit PluginSize(bool r) : rectangle(r) {}
+ };
+ 
+ struct Propagation {
+     bool stop; /* Whether to prevent the event from propagating to other handlers */
+-    Propagation() = delete;
++    constexpr explicit Propagation(bool s) : stop(s) {}
+ };
+ 
+ struct TimeoutResponse {
+     bool again; /* Invoke the timeout handler again, otherwise stop the timer */
+-    TimeoutResponse() = delete;
++    constexpr explicit TimeoutResponse(bool a) : again(a) {}
+ };
+ 
+ struct TooltipTime {
+     bool now; /* Whether to show the tooltip now or later */
+-    TooltipTime() = delete;
++    constexpr explicit TooltipTime(bool n) : now(n) {}
+ };
+ 
+ extern const PluginSize      RECTANGLE, SQUARE;
+-- 
+2.49.0
+
diff --git a/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin_1.5.0.bb b/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin_1.5.0.bb
index 1d9f7c205a..70e30164ae 100644
--- a/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin_1.5.0.bb
+++ b/meta-xfce/recipes-panel-plugins/sensors/xfce4-sensors-plugin_1.5.0.bb
@@ -7,7 +7,9 @@  XFCE_COMPRESS_TYPE = "xz"
 
 inherit xfce-panel-plugin
 
-SRC_URI += "file://0001-Do-not-check-for-sys-class-power_supply-we-are-cross.patch"
+SRC_URI += "file://0001-Do-not-check-for-sys-class-power_supply-we-are-cross.patch \
+            file://0001-Fix-aggregate-init-failure-with-gcc16.patch \
+"
 SRC_URI[sha256sum] = "840442b87fdddcd8595bd9f83ea8b81f771fe296bb9d2abf0e1979e208727ae9"
 
 EXTRA_OECONF = " \