diff mbox series

[1/4] xfce4-cpufreq-plugin: Fix aggregate init failure with gcc16

Message ID 20260609065712.2888126-1-mingli.yu@windriver.com
State Under Review
Headers show
Series [1/4] xfce4-cpufreq-plugin: Fix aggregate init failure with gcc16 | expand

Commit Message

Yu, Mingli June 9, 2026, 6:57 a.m. UTC
From: Mingli Yu <mingli.yu@windriver.com>

Fixes:
   ../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.cc:25:37: error: no matching function for call to 'xfce4::PluginSize::PluginSize(<brace-enclosed initializer list>)'
   25 | const PluginSize      RECTANGLE{true}, SQUARE{false};
      |                                     ^
  • there are 2 candidates
In file included from ../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.cc:21:
    • candidate 1: 'constexpr xfce4::PluginSize::PluginSize(const xfce4::PluginSize&)'
      ../../../sources/xfce4-cpufreq-plugin-1.3.0/xfce4++/util/gtk.h:64:8:
         64 | struct PluginSize {
            |        ^~~~~~~~~~
      • no known conversion for argument 1 from 'bool' to 'const xfce4::PluginSize&'
    • candidate 2: 'constexpr xfce4::PluginSize::PluginSize(xfce4::PluginSize&&)'
      • no known conversion for argument 1 from 'bool' to 'xfce4::PluginSize&&'

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 ...ix-aggregate-init-failure-with-gcc16.patch | 49 +++++++++++++++++++
 .../cpufreq/xfce4-cpufreq-plugin_1.3.0.bb     |  4 ++
 2 files changed, 53 insertions(+)
 create mode 100644 meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
diff mbox series

Patch

diff --git a/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch b/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
new file mode 100644
index 0000000000..b786d0d153
--- /dev/null
+++ b/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin/0001-Fix-aggregate-init-failure-with-gcc16.patch
@@ -0,0 +1,49 @@ 
+From b9dc593f2843bd0f18309bde4d79b88d9f37e32f Mon Sep 17 00:00:00 2001
+From: Mingli Yu <mingli.yu@windriver.com>
+Date: Tue, 2 Jun 2026 23:07:08 -0700
+Subject: [PATCH] Fix aggregate init failure with gcc16
+
+Replace deleted default constructors with explicit bool constructors
+to fix aggregate init failure with gcc16.
+
+Upstream-Status: Submitted [https://gitlab.xfce.org/panel-plugins/xfce4-cpufreq-plugin/-/merge_requests/68]
+
+Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
+---
+ xfce4++/util/gtk.h | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/xfce4++/util/gtk.h b/xfce4++/util/gtk.h
+index 1443cb2..ef03dd1 100644
+--- a/xfce4++/util/gtk.h
++++ b/xfce4++/util/gtk.h
+@@ -63,22 +63,22 @@ void connect(GtkToggleButton *widget, const char *signal, const std::function<vo
+ 
+ struct PluginSize {
+     bool rectangle; /* Whether the panel plugin size is forced to be a square. Otherwise, the plugin can be a rectangle. */
+-    PluginSize() = delete;
++    constexpr explicit PluginSize(bool r) : rectangle(r) {}
+ };
+ 
+ struct Propagation {
+     bool stop; /* Whether to prevent the event from propagating to other handlers */
+-    Propagation() = delete;
++    constexpr explicit Propagation(bool s) : stop(s) {}
+ };
+ 
+ struct TimeoutResponse {
+     bool again; /* Invoke the timeout handler again, otherwise stop the timer */
+-    TimeoutResponse() = delete;
++    constexpr explicit TimeoutResponse(bool a) : again(a) {}
+ };
+ 
+ struct TooltipTime {
+     bool now; /* Whether to show the tooltip now or later */
+-    TooltipTime() = delete;
++    constexpr explicit TooltipTime(bool n) : now(n) {}
+ };
+ 
+ extern const PluginSize      RECTANGLE, SQUARE;
+-- 
+2.49.0
+
diff --git a/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin_1.3.0.bb b/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin_1.3.0.bb
index a0b48b8671..093b43c88f 100644
--- a/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin_1.3.0.bb
+++ b/meta-xfce/recipes-panel-plugins/cpufreq/xfce4-cpufreq-plugin_1.3.0.bb
@@ -7,4 +7,8 @@  XFCE_COMPRESS_TYPE = "xz"
 
 inherit xfce-panel-plugin perlnative
 
+SRC_URI += "\
+           file://0001-Fix-aggregate-init-failure-with-gcc16.patch \
+"
+
 SRC_URI[sha256sum] = "baa5b90f72e8c262777f1e246acae125af489e2c168a5f7f890d9d2b5567ec20"