diff mbox series

fetch2/wget: remove orphaned NamedTemporaryFile in _fetch_index

Message ID 20260830102635.2402088-1-adrian.freihofer@siemens.com
State New
Headers show
Series fetch2/wget: remove orphaned NamedTemporaryFile in _fetch_index | expand

Commit Message

AdrianF Aug. 30, 2026, 10:26 a.m. UTC 
From: Adrian Freihofer <adrian.freihofer@siemens.com>

_fetch_index() created a tempfile.NamedTemporaryFile() that was
immediately shadowed by the following "with ... as f:" statement, so
it was never used or closed. The GC eventually reclaims it and prints
a ResourceWarning ("Implicitly cleaning up ...") during upstream
version checks (e.g. "devtool latest-version").

AI-Generated: Uses GitHub Copilot

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 lib/bb/fetch2/wget.py | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py
index 0d2b7f5c8..f732a0be2 100644
--- a/lib/bb/fetch2/wget.py
+++ b/lib/bb/fetch2/wget.py
@@ -562,7 +562,6 @@  class Wget(FetchMethod):
         """
         Run fetch checkstatus to get directory information
         """
-        f = tempfile.NamedTemporaryFile()
         with tempfile.TemporaryDirectory(prefix="wget-index-") as workdir, tempfile.NamedTemporaryFile(dir=workdir, prefix="wget-listing-") as f:
             fetchcmd = self.basecmd + ["--output-document=%s" % f.name, uri]
             try: