diff mbox series

[bitbake-devel,V2,2/5] fetch2/wget.py: add filter_regex parameter to latest_versionstring

Message ID 20260507061845.1460893-2-Qi.Chen@windriver.com
State New
Headers show
Series [bitbake-devel,V2,1/5] fetch2/git.py: add filter_regex parameter to latest_versionstring | expand

Commit Message

Chen, Qi May 7, 2026, 6:18 a.m. UTC 
From: Chen Qi <Qi.Chen@windriver.com>

We want to be able to do stable version upgrade for recipes. For
example, 1.0.0 -> 1.0.1 instead of 1.0.0 -> 1.1.0.

To to this, we need an extra paramter to latest_versionstring
so that we are able to filter out the versions we need. Using regex
has the advantage of adapting to different version schemes.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 lib/bb/fetch2/wget.py | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

Comments

Alexander Kanavin May 7, 2026, 10:43 a.m. UTC | #1 
On Thu, 7 May 2026 at 08:19, <Qi.Chen@windriver.com> wrote:
> +                if filter_regex:
> +                    if not re.match(filter_regex, re.sub('_', '.', newver[1])):

This needs to include a note explaining that filter_regex is derived
from PV, and so uses . as separator, while upstream may be using _ as
separator (as seen below in the code where the same conversion happens
before the discovered version is returned).

> -                            package, package_regex, current_version, ud, d)
> +                            package, package_regex, current_version, ud, d, filter_regex=filter_regex)

Here and in other places you can perhaps simply pass in filter_regex
without naming the argument?

Alex
Chen, Qi May 8, 2026, 5:26 a.m. UTC | #2 
I'll add note and simplify the function calls.

Regards,
Qi

-----Original Message-----
From: Alexander Kanavin <alex.kanavin@gmail.com> 
Sent: Thursday, May 7, 2026 6:43 PM
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: bitbake-devel@lists.openembedded.org; MacLeod, Randy <Randy.MacLeod@windriver.com>
Subject: Re: [bitbake-devel][PATCH V2 2/5] fetch2/wget.py: add filter_regex parameter to latest_versionstring

On Thu, 7 May 2026 at 08:19, <Qi.Chen@windriver.com> wrote:
> +                if filter_regex:
> +                    if not re.match(filter_regex, re.sub('_', '.', newver[1])):

This needs to include a note explaining that filter_regex is derived from PV, and so uses . as separator, while upstream may be using _ as separator (as seen below in the code where the same conversion happens before the discovered version is returned).

> -                            package, package_regex, current_version, ud, d)
> +                            package, package_regex, current_version, 
> + ud, d, filter_regex=filter_regex)

Here and in other places you can perhaps simply pass in filter_regex without naming the argument?

Alex
diff mbox series

Patch

diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py
index 6ac4306c0..1f331ba3a 100644
--- a/lib/bb/fetch2/wget.py
+++ b/lib/bb/fetch2/wget.py
@@ -492,7 +492,7 @@  class Wget(FetchMethod):
 
         return fetchresult
 
-    def _check_latest_version(self, url, package, package_regex, current_version, ud, d):
+    def _check_latest_version(self, url, package, package_regex, current_version, ud, d, filter_regex=None):
         """
         Return the latest version of a package inside a given directory path
         If error or no version, return ""
@@ -515,6 +515,9 @@  class Wget(FetchMethod):
                 newver = self._parse_path(package_regex, str(line))
 
             if newver:
+                if filter_regex:
+                    if not re.match(filter_regex, re.sub('_', '.', newver[1])):
+                        continue
                 bb.debug(3, "Upstream version found: %s" % newver[1])
                 if valid == 0:
                     version = newver
@@ -532,7 +535,7 @@  class Wget(FetchMethod):
 
         return ""
 
-    def _check_latest_version_by_dir(self, dirver, package, package_regex, current_version, ud, d):
+    def _check_latest_version_by_dir(self, dirver, package, package_regex, current_version, ud, d, filter_regex=None):
         """
         Scan every directory in order to get upstream version.
         """
@@ -576,7 +579,7 @@  class Wget(FetchMethod):
                         ud.user, ud.pswd, {}])
 
                     pupver = self._check_latest_version(uri,
-                            package, package_regex, current_version, ud, d)
+                            package, package_regex, current_version, ud, d, filter_regex=filter_regex)
                     if pupver:
                         version[1] = pupver
 
@@ -637,7 +640,7 @@  class Wget(FetchMethod):
 
         return package_custom_regex_comp
 
-    def latest_versionstring(self, ud, d):
+    def latest_versionstring(self, ud, d, filter_regex=None):
         """
         Manipulate the URL and try to obtain the latest package version
 
@@ -678,11 +681,11 @@  class Wget(FetchMethod):
                 dirver_pn_regex = re.compile(r"%s\d?" % (re.escape(pn)))
                 if not dirver_pn_regex.search(dirver):
                     return (self._check_latest_version_by_dir(dirver,
-                        package, package_regex, current_version, ud, d), '')
+                        package, package_regex, current_version, ud, d, filter_regex=filter_regex), '')
 
             uri = bb.fetch.encodeurl([ud.type, ud.host, path, ud.user, ud.pswd, {}])
         else:
             uri = regex_uri
 
         return (self._check_latest_version(uri, package, package_regex,
-                current_version, ud, d), '')
+                current_version, ud, d, filter_regex=filter_regex), '')