diff mbox series

[2/2] bitbake-getvar: use finalizeData tinfoil API to get identical result to "bitbake -e"

Message ID 20241112230559.2035910-2-yoann.congal@smile.fr
State Accepted, archived
Commit 68ae81dc93f86eab378fec2276561c5062263d7e
Headers show
Series [1/2] tinfoil: add new "finalizeData" API | expand

Commit Message

Yoann Congal Nov. 12, 2024, 11:05 p.m. UTC 
From: Yoann Congal <yoann.congal@smile.fr>

Fixes [YOCTO #15638]

Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
 bin/bitbake-getvar | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mathieu Dubois-Briand Nov. 13, 2024, 2:50 p.m. UTC | #1 
On Wed, Nov 13, 2024 at 12:05:59AM +0100, Yoann Congal via lists.openembedded.org wrote:
> From: Yoann Congal <yoann.congal@smile.fr>
> 
> Fixes [YOCTO #15638]
> 
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>

Hi Yoann,

I believe this commit is responsible of build failures on the
autobuilder, on oe-selftest* and *-tc builders:

RuntimeError: core-image-minimal - FAILED to start qemu - check the task
log and the boot log

https://valkyrie.yoctoproject.org/#/builders/28/builds/402/steps/12/logs/stdio
https://valkyrie.yoctoproject.org/#/builders/28/builds/402/steps/12/logs/stdio

Can you have a look at this issue please ?
Yoann Congal Nov. 14, 2024, 10:22 p.m. UTC | #2 
Le 13/11/2024 à 15:50, Mathieu Dubois-Briand a écrit :
> On Wed, Nov 13, 2024 at 12:05:59AM +0100, Yoann Congal via lists.openembedded.org wrote:
>> From: Yoann Congal <yoann.congal@smile.fr>
>>
>> Fixes [YOCTO #15638]
>>
>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> 
> Hi Yoann,
> 
> I believe this commit is responsible of build failures on the
> autobuilder, on oe-selftest* and *-tc builders:
> 
> RuntimeError: core-image-minimal - FAILED to start qemu - check the task
> log and the boot log
> 
> https://valkyrie.yoctoproject.org/#/builders/28/builds/402/steps/12/logs/stdio
> https://valkyrie.yoctoproject.org/#/builders/28/builds/402/steps/12/logs/stdio
> 
> Can you have a look at this issue please ?

It was indeed my patches that created the above issues. Nice catch!
I've now sent a v2 that fixes the failing test locally.

Thanks!
diff mbox series

Patch

diff --git a/bin/bitbake-getvar b/bin/bitbake-getvar
index 8901f99ae..bc0b989c8 100755
--- a/bin/bitbake-getvar
+++ b/bin/bitbake-getvar
@@ -45,6 +45,10 @@  if __name__ == "__main__":
             tinfoil.prepare(quiet=2, config_only=True)
             d = tinfoil.config_data
 
+        # Expand keys and run anonymous functions to get identical result to
+        # "bitbake -e"
+        d = tinfoil.finalizeData()
+
         value = None
         if args.flag:
             value = d.getVarFlag(args.variable, args.flag, expand=not args.unexpand)