diff mbox series

[langdale,13/27] devtool: ignore patch-fuzz errors when extracting source

Message ID aa256e62df4f31de1c2c1ce7d0a6ab8bdba4a032.1678401759.git.steve@sakoman.com
State New
Headers show
Series [langdale,01/27] tiff: fix multiple CVEs | expand

Commit Message

Steve Sakoman March 9, 2023, 10:57 p.m. UTC
From: Alexander Kanavin <alex.kanavin@gmail.com>

So that patch fuzz issues can actually be fixed,
as extracting source with 'devtool modify' is the first step
for that.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 7067abd31d9dd4b98ec70c1c7effbe2904797cd1)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 scripts/lib/devtool/standard.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Purdie March 9, 2023, 11:15 p.m. UTC | #1
On Thu, 2023-03-09 at 12:57 -1000, Steve Sakoman wrote:
> From: Alexander Kanavin <alex.kanavin@gmail.com>
> 
> So that patch fuzz issues can actually be fixed,
> as extracting source with 'devtool modify' is the first step
> for that.
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 7067abd31d9dd4b98ec70c1c7effbe2904797cd1)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  scripts/lib/devtool/standard.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
> index d64e18e179..0339d12763 100644
> --- a/scripts/lib/devtool/standard.py
> +++ b/scripts/lib/devtool/standard.py
> @@ -567,6 +567,7 @@ def _extract_source(srctree, keep_temp, devbranch, sync, config, basepath, works
>          logger.debug('writing append file %s' % appendfile)
>          with open(appendfile, 'a') as f:
>              f.write('###--- _extract_source\n')
> +            f.write('ERROR_QA:remove = "patch-fuzz"\n')
>              f.write('DEVTOOL_TEMPDIR = "%s"\n' % tempdir)
>              f.write('DEVTOOL_DEVBRANCH = "%s"\n' % devbranch)
>              if not is_kernel_yocto:

Whilst this is harmless, I'm not sure langdale has the patch-fuzz QA
test enabled as an error?

Cheers,

Richard
Steve Sakoman March 10, 2023, 2:40 a.m. UTC | #2
On Thu, Mar 9, 2023 at 1:15 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Thu, 2023-03-09 at 12:57 -1000, Steve Sakoman wrote:
> > From: Alexander Kanavin <alex.kanavin@gmail.com>
> >
> > So that patch fuzz issues can actually be fixed,
> > as extracting source with 'devtool modify' is the first step
> > for that.
> >
> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > (cherry picked from commit 7067abd31d9dd4b98ec70c1c7effbe2904797cd1)
> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> >  scripts/lib/devtool/standard.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
> > index d64e18e179..0339d12763 100644
> > --- a/scripts/lib/devtool/standard.py
> > +++ b/scripts/lib/devtool/standard.py
> > @@ -567,6 +567,7 @@ def _extract_source(srctree, keep_temp, devbranch, sync, config, basepath, works
> >          logger.debug('writing append file %s' % appendfile)
> >          with open(appendfile, 'a') as f:
> >              f.write('###--- _extract_source\n')
> > +            f.write('ERROR_QA:remove = "patch-fuzz"\n')
> >              f.write('DEVTOOL_TEMPDIR = "%s"\n' % tempdir)
> >              f.write('DEVTOOL_DEVBRANCH = "%s"\n' % devbranch)
> >              if not is_kernel_yocto:
>
> Whilst this is harmless, I'm not sure langdale has the patch-fuzz QA
> test enabled as an error?

Sigh, yes I meant to check this and forgot :-(

I didn't take https://git.openembedded.org/openembedded-core/commit/?id=76a685bfcf927593eac67157762a53259089ea8a,
so no need for this patch.

Thanks for reviewing!

Steve
diff mbox series

Patch

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index d64e18e179..0339d12763 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -567,6 +567,7 @@  def _extract_source(srctree, keep_temp, devbranch, sync, config, basepath, works
         logger.debug('writing append file %s' % appendfile)
         with open(appendfile, 'a') as f:
             f.write('###--- _extract_source\n')
+            f.write('ERROR_QA:remove = "patch-fuzz"\n')
             f.write('DEVTOOL_TEMPDIR = "%s"\n' % tempdir)
             f.write('DEVTOOL_DEVBRANCH = "%s"\n' % devbranch)
             if not is_kernel_yocto: