| Message ID | 20230213135525.3650-1-pedro.miguel.baptista@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [PATCHv2,1/2] action.py: add BBPATH in bblayers_conf path for add-layer | expand |
On Mon, 2023-02-13 at 13:55 +0000, Pedro Baptista wrote: > From: Pedro Baptista <pedro.miguel.baptista@gmail.com> > > By including the full path to bblayers.conf the add-layer > command can be executed from any location, not only from the > build directory. > > Signed-off-by: Pedro Baptista <pedro.miguel.baptista@gmail.com> > --- > bitbake/lib/bblayers/action.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/bblayers/action.py b/bitbake/lib/bblayers/action.py > index 454c251410..a2208db0bc 100644 > --- a/bitbake/lib/bblayers/action.py > +++ b/bitbake/lib/bblayers/action.py > @@ -37,7 +37,7 @@ class ActionPlugin(LayerPlugin): > sys.stderr.write("Specified layer directory %s doesn't contain a conf/layer.conf file\n" % layerdir) > return 1 > > - bblayers_conf = os.path.join('conf', 'bblayers.conf') > + bblayers_conf = os.path.join(os.environ['BBPATH'], 'conf', 'bblayers.conf') > if not os.path.exists(bblayers_conf): > sys.stderr.write("Unable to find bblayers.conf\n") > return 1 Whilst that is an improvement, I was really suggesting using something like lib/bb/cookerdata.py:findConfigFile() as done in findTopdir() in that file. That way we use the same behaviour everywhere. Cheers, Richard
diff --git a/bitbake/lib/bblayers/action.py b/bitbake/lib/bblayers/action.py index 454c251410..a2208db0bc 100644 --- a/bitbake/lib/bblayers/action.py +++ b/bitbake/lib/bblayers/action.py @@ -37,7 +37,7 @@ class ActionPlugin(LayerPlugin): sys.stderr.write("Specified layer directory %s doesn't contain a conf/layer.conf file\n" % layerdir) return 1 - bblayers_conf = os.path.join('conf', 'bblayers.conf') + bblayers_conf = os.path.join(os.environ['BBPATH'], 'conf', 'bblayers.conf') if not os.path.exists(bblayers_conf): sys.stderr.write("Unable to find bblayers.conf\n") return 1