| Message ID | 20230206094316.32352-1-p-bhagat@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [dunfell] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile | expand |
On Mon, Feb 06, 2023 at 03:13:16PM +0530, Paresh Bhagat via lists.yoctoproject.org wrote: > Command "make linux-dtbs" at SDK top-level generates incorrect overlay > dtbo file. Fix it by building every device tree binary. > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > --- > .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > index fa409d0a..a492ac84 100644 > --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > @@ -4,9 +4,7 @@ linux-dtbs: > @echo Building the Linux Kernel DTBs > @echo ===================================== > $(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG) > - @for DTB in __KERNEL_DEVICETREE__; do \ > - $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \ > - done > + $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \ This doesn't look right! What exactly do you mean by "incorrect DTBO file generated"? This is exactly how the release binaries (DTBs, DTBOs and images) are built by Yocto - going through the predefined list building them one by one. Calling "make dtbs" is a sledgehammer approach and you'll end up with hundreds of unrelated DTBs...
diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs index fa409d0a..a492ac84 100644 --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs @@ -4,9 +4,7 @@ linux-dtbs: @echo Building the Linux Kernel DTBs @echo ===================================== $(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG) - @for DTB in __KERNEL_DEVICETREE__; do \ - $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \ - done + $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \ linux-dtbs_install: @echo =======================================
Command "make linux-dtbs" at SDK top-level generates incorrect overlay dtbo file. Fix it by building every device tree binary. Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> --- .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)