diff mbox series

recipes-core/images: Build ti-core-initramfs alongside tisdk images

Message ID 20260902132838.2135551-1-m-shah@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series recipes-core/images: Build ti-core-initramfs alongside tisdk images | expand

Commit Message

Moteen Shah Sept. 2, 2026, 1:28 p.m. UTC
Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
this machine. Force ti-core-initramfs to build via an explicit
do_build dependency in arago-image.inc, the common include every
tisdk-*-image recipe require.

Signed-off-by: Moteen Shah <m-shah@ti.com>
---
This patch has a dependency on the following series: 
https://lists.yoctoproject.org/g/meta-ti/message/20235

 meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
 1 file changed, 4 insertions(+)

Comments

PRC Automation Sept. 2, 2026, 1:32 p.m. UTC | #1
meta-arago / na / 20260902132838.2135551-1-m-shah

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
    WARN: Missing branches specifier [master/scarthgap/XXXXX]. (META-2)
        patch:86
            Subject: [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
    
    For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887



=========================================================
  apply-yocto-patch: FAIL
=========================================================
master
=====================
Summary:
- Patch Series: [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
- Submitter: From: Moteen Shah <m-shah@ti.com>
- Date: Date: Wed, 2 Sep 2026 18:58:38 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 96aa2a6657c423398618f3fba7ffd61eaecddbd5

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: gstreamer1.0-plugins-good: Drop unneeded patches
- Commit SHA: 0122872fbf4cf57798351d7d0ef8f9a6a3712423

Patches
----------------------------------------
FAIL - [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
    error: patch failed: meta-arago-distro/recipes-core/images/arago-image.inc:30
    error: meta-arago-distro/recipes-core/images/arago-image.inc: patch does not apply
    Applying: recipes-core/images: Build ti-core-initramfs alongside tisdk images
    Patch failed at 0001 recipes-core/images: Build ti-core-initramfs alongside tisdk images
Moteen Shah Sept. 2, 2026, 1:41 p.m. UTC | #2
I will resend the series with the right tags, missed adding those.

Regards,
Moteen

On 02/09/26 19:02, PRC Automation wrote:
> meta-arago / na / 20260902132838.2135551-1-m-shah
>
> PRC Results: FAIL
>
> =========================================================
>    check-yocto-patches: PASS
> =========================================================
> Patches
> ----------------------------------------
> WARN - [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
>      WARN: Missing branches specifier [master/scarthgap/XXXXX]. (META-2)
>          patch:86
>              Subject: [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
>      
>      For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
>
>
>
> =========================================================
>    apply-yocto-patch: FAIL
> =========================================================
> master
> =====================
> Summary:
> - Patch Series: [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
> - Submitter: From: Moteen Shah <m-shah@ti.com>
> - Date: Date: Wed, 2 Sep 2026 18:58:38 +0530
> - Num Patches: 1
> - Mailing List (public inbox) Commit SHA: 96aa2a6657c423398618f3fba7ffd61eaecddbd5
>
> Applied to:
> - Repository: lcpd-prc-meta-arago
> - Base Branch: master
> - Commit Author: Ryan Eatmon <reatmon@ti.com>
> - Commit Subject: gstreamer1.0-plugins-good: Drop unneeded patches
> - Commit SHA: 0122872fbf4cf57798351d7d0ef8f9a6a3712423
>
> Patches
> ----------------------------------------
> FAIL - [PATCH] recipes-core/images: Build ti-core-initramfs alongside tisdk images
>      error: patch failed: meta-arago-distro/recipes-core/images/arago-image.inc:30
>      error: meta-arago-distro/recipes-core/images/arago-image.inc: patch does not apply
>      Applying: recipes-core/images: Build ti-core-initramfs alongside tisdk images
>      Patch failed at 0001 recipes-core/images: Build ti-core-initramfs alongside tisdk images
>
>
>
Ryan Eatmon Sept. 2, 2026, 2:05 p.m. UTC | #3
On 9/2/2026 8:28 AM, Moteen Shah wrote:
> Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
> TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
> TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
> this machine. Force ti-core-initramfs to build via an explicit
> do_build dependency in arago-image.inc, the common include every
> tisdk-*-image recipe require.

Why do we need to force an initramfs on every platform/image?  What is 
the point?  The point of the initramfs was that *some* boards need some 
kernel modules to boot so we only require it for those platforms.


> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
> This patch has a dependency on the following series:
> https://lists.yoctoproject.org/g/meta-ti/message/20235
> 
>   meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
> index 37b20850..398e299f 100644
> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -30,3 +30,7 @@ BAD_RECOMMENDATIONS += " \
>   BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}"
>   
>   inherit core-image remove-net-rules
> +
> +# Force ti-core-initramfs to build alongside every image based on this common include.
> +
> +do_build[depends] += "ti-core-initramfs:do_image_complete"
Yogesh Hegde Sept. 3, 2026, 8:59 a.m. UTC | #4
Hi Moteen, Thanks for the patch

On 18:58-20260902, Moteen Shah via lists.yoctoproject.org wrote:
> Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
> TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
> TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
> this machine. Force ti-core-initramfs to build via an explicit
> do_build dependency in arago-image.inc, the common include every
> tisdk-*-image recipe require.
> 
> Signed-off-by: Moteen Shah <m-shah@ti.com>

I am not sure why this patch is needed. Why does j722s need an 
empty initramfs to be built? Why does j722s need a empt initramfs?
- If it geniunely needs to be built, this fix should belong to j722s machine config by
  setting the appropriate variables, so it is limited to j722s only.
- If it not to be built, then the gate is working correctly and there is
  nothing to fix. 

-- Yogesh

> ---
> This patch has a dependency on the following series: 
> https://lists.yoctoproject.org/g/meta-ti/message/20235
> 
>  meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
> index 37b20850..398e299f 100644
> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -30,3 +30,7 @@ BAD_RECOMMENDATIONS += " \
>  BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}"
>  
>  inherit core-image remove-net-rules
> +
> +# Force ti-core-initramfs to build alongside every image based on this common include.
> +
> +do_build[depends] += "ti-core-initramfs:do_image_complete"
Moteen Shah Sept. 3, 2026, 9:45 a.m. UTC | #5
Hey Yogesh,

On 03/09/26 14:29, Yogesh Hegde wrote:
> Hi Moteen, Thanks for the patch
>
> On 18:58-20260902, Moteen Shah via lists.yoctoproject.org wrote:
>> Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
>> TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
>> TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
>> this machine. Force ti-core-initramfs to build via an explicit
>> do_build dependency in arago-image.inc, the common include every
>> tisdk-*-image recipe require.
>>
>> Signed-off-by: Moteen Shah <m-shah@ti.com>
> I am not sure why this patch is needed. Why does j722s need an
> empty initramfs to be built? Why does j722s need a empt initramfs?
> - If it geniunely needs to be built, this fix should belong to j722s machine config by
>    setting the appropriate variables, so it is limited to j722s only.
> - If it not to be built, then the gate is working correctly and there is
>    nothing to fix.
>
> -- Yogesh

Its not an empty initramfs actually, if you see the dependent series in 
meta-ti which I have linked it adds the required modules.

Regards,
Moteen

>
>> ---
>> This patch has a dependency on the following series:
>> https://lists.yoctoproject.org/g/meta-ti/message/20235
>>
>>   meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
>> index 37b20850..398e299f 100644
>> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
>> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
>> @@ -30,3 +30,7 @@ BAD_RECOMMENDATIONS += " \
>>   BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}"
>>   
>>   inherit core-image remove-net-rules
>> +
>> +# Force ti-core-initramfs to build alongside every image based on this common include.
>> +
>> +do_build[depends] += "ti-core-initramfs:do_image_complete"
Moteen Shah Sept. 3, 2026, 9:50 a.m. UTC | #6
Hey Ryan,

On 02/09/26 19:35, Ryan Eatmon wrote:
>
>
> On 9/2/2026 8:28 AM, Moteen Shah wrote:
>> Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
>> TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
>> TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
>> this machine. Force ti-core-initramfs to build via an explicit
>> do_build dependency in arago-image.inc, the common include every
>> tisdk-*-image recipe require.
>
> Why do we need to force an initramfs on every platform/image? What is 
> the point?  The point of the initramfs was that *some* boards need 
> some kernel modules to boot so we only require it for those platforms.
>

Is something like this okay?

--- a/meta-arago-distro/recipes-core/images/arago-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-image.inc
@@ -30,3 +30,11 @@ BAD_RECOMMENDATIONS += " \
  BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", 
"sysvinit", "", "busybox-syslog", d)}"

  inherit core-image remove-net-rules
+
+ARAGO_TI_CORE_INITRAMFS_STEP ?= ""
+ARAGO_TI_CORE_INITRAMFS_STEP:j722s = "ti-core-initramfs:do_image_complete"
+
+do_build[depends] += "${ARAGO_TI_CORE_INITRAMFS_STEP}"


With the above change I need to do some meta-ti fix as well.

Regards,
Moteen


>
>> Signed-off-by: Moteen Shah <m-shah@ti.com>
>> ---
>> This patch has a dependency on the following series:
>> https://lists.yoctoproject.org/g/meta-ti/message/20235
>>
>>   meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc 
>> b/meta-arago-distro/recipes-core/images/arago-image.inc
>> index 37b20850..398e299f 100644
>> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
>> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
>> @@ -30,3 +30,7 @@ BAD_RECOMMENDATIONS += " \
>>   BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", 
>> "sysvinit", "", "busybox-syslog", d)}"
>>     inherit core-image remove-net-rules
>> +
>> +# Force ti-core-initramfs to build alongside every image based on 
>> this common include.
>> +
>> +do_build[depends] += "ti-core-initramfs:do_image_complete"
>
Ryan Eatmon Sept. 3, 2026, 3:14 p.m. UTC | #7
On 9/3/2026 4:50 AM, Moteen Shah wrote:
> Hey Ryan,
> 
> On 02/09/26 19:35, Ryan Eatmon wrote:
>>
>>
>> On 9/2/2026 8:28 AM, Moteen Shah wrote:
>>> Neither image sets TI_CORE_INITRAMFS_KERNEL_MODULES or
>>> TI_CORE_INITRAMFS_EXTRA_INSTALL for j722s, so the machine-wide
>>> TI_CORE_INITRAMFS_ENABLED gate in meta-ti-bsp stays off by default for
>>> this machine. Force ti-core-initramfs to build via an explicit
>>> do_build dependency in arago-image.inc, the common include every
>>> tisdk-*-image recipe require.
>>
>> Why do we need to force an initramfs on every platform/image? What is 
>> the point?  The point of the initramfs was that *some* boards need 
>> some kernel modules to boot so we only require it for those platforms.
>>
> 
> Is something like this okay?

To be fair, I'm not 100% certain about backporting any of this.  We did 
the initramfs in response to the newer kernels (ie upstream) building 
something as modules and not built in.  And we moved to that model in 
6.18 (master/wrynose).

If there is something in scarthgap for 6.12 that requires this then we 
should just update our 6.12 kernel to build the correct thing and not 
need the initramfs.  We haven't tested any of this code under scarthgap 
and I'm not comfortable just shoving this in.  We need to try and keep 
scarthgap somewhat stable and not do things like this.

We should be able to have a config fragment that only applies for j722s 
when building the kernel to configure it exactly how we want for just 
j722s.  No need to shoehorn in the initramfs for this.


> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -30,3 +30,11 @@ BAD_RECOMMENDATIONS += " \
>   BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", 
> "sysvinit", "", "busybox-syslog", d)}"
> 
>   inherit core-image remove-net-rules
> +
> +ARAGO_TI_CORE_INITRAMFS_STEP ?= ""
> +ARAGO_TI_CORE_INITRAMFS_STEP:j722s = "ti-core-initramfs:do_image_complete"
> +
> +do_build[depends] += "${ARAGO_TI_CORE_INITRAMFS_STEP}"
> 
> 
> With the above change I need to do some meta-ti fix as well.
> 
> Regards,
> Moteen
> 
> 
>>
>>> Signed-off-by: Moteen Shah <m-shah@ti.com>
>>> ---
>>> This patch has a dependency on the following series:
>>> https://lists.yoctoproject.org/g/meta-ti/message/20235
>>>
>>>   meta-arago-distro/recipes-core/images/arago-image.inc | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc 
>>> b/meta-arago-distro/recipes-core/images/arago-image.inc
>>> index 37b20850..398e299f 100644
>>> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
>>> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
>>> @@ -30,3 +30,7 @@ BAD_RECOMMENDATIONS += " \
>>>   BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", 
>>> "sysvinit", "", "busybox-syslog", d)}"
>>>     inherit core-image remove-net-rules
>>> +
>>> +# Force ti-core-initramfs to build alongside every image based on 
>>> this common include.
>>> +
>>> +do_build[depends] += "ti-core-initramfs:do_image_complete"
>>
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
index 37b20850..398e299f 100644
--- a/meta-arago-distro/recipes-core/images/arago-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-image.inc
@@ -30,3 +30,7 @@  BAD_RECOMMENDATIONS += " \
 BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}"
 
 inherit core-image remove-net-rules
+
+# Force ti-core-initramfs to build alongside every image based on this common include.
+
+do_build[depends] += "ti-core-initramfs:do_image_complete"