| Message ID | 20260805121327.3946788-2-sputnik@on-the-web.ch |
|---|---|
| State | New |
| Headers | show |
| Series | rkbin: convert LICENSE to SPDX expressions | expand |
Hi Martin, I've read on LinkedIn you used AI/LLM for some stuff related to Rockchip and was wondering if maybe this series got some of it developed by/with AI/LLM. OE-Core and BitBake require to add an AI-Generated: <AI/LLM used> in the commit log and I think it could be nice to see it stated for meta-rockchip as well. Ultimately, it's up to Trevor to define or "enforce" this as he's the sole maintainer of meta-rockchip at the moment. See the "Acceptance of AI Generated Code" section in the contributor guide (I'm traveling so cannot provide you with a link right now) if you want to know more. On 8/5/26 2:14 PM, Martin Herren via lists.yoctoproject.org wrote: > From: Martin Herren <sputnik@on-the-web.ch> > > OE-Core now parses LICENSE as an SPDX expression and warns on legacy > non-SPDX names such as "Proprietary". > > Switch the rkbin family (rockchip-rkbin.inc, used by -ddr, -optee-os and > -tf-a) to a recipe-specific LicenseRef backed by NO_GENERIC_LICENSE, so > the SPDX manifest references the real Rockchip LICENSE at the repo root. > > References: oe-core e9d424738d6f ("classes/conf/lib: Parse LICENSE as SPDX Expression") > > Signed-off-by: Martin Herren <sputnik@on-the-web.ch> > --- > recipes-bsp/rkbin/rockchip-rkbin.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/recipes-bsp/rkbin/rockchip-rkbin.inc b/recipes-bsp/rkbin/rockchip-rkbin.inc > index 9ddd54f..d715b44 100644 > --- a/recipes-bsp/rkbin/rockchip-rkbin.inc > +++ b/recipes-bsp/rkbin/rockchip-rkbin.inc > @@ -1,7 +1,8 @@ > SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" > SRCREV = "f43a462e7a1429a9d407ae52b4745033034a6cf9" > -LICENSE = > "Proprietary" > +LICENSE = "LicenseRef-Rockchip-rkbin" > LIC_FILES_CHKSUM = "file://LICENSE;md5=11e3673115959bf596feaaa6ea7ce9a5" > +NO_GENERIC_LICENSE[Rockchip-rkbin] = "LICENSE" > This seems to follow what we've done for meta/recipes-kernel/linux-firmware/linux-firmware_*.bb so looks good to me, thus: Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
Hi Quentin, Thanks for your review. On Thursday, August 6th, 2026 at 2:42 PM, Quentin Schulz via lists.yoctoproject.org <quentin.schulz=cherry.de@lists.yoctoproject.org> wrote: > Hi Martin, > > I've read on LinkedIn you used AI/LLM for some stuff related to Rockchip > and was wondering if maybe this series got some of it developed by/with > AI/LLM. OE-Core and BitBake require to add an > > AI-Generated: <AI/LLM used> > > in the commit log and I think it could be nice to see it stated for > meta-rockchip as well. Ultimately, it's up to Trevor to define or > "enforce" this as he's the sole maintainer of meta-rockchip at the > moment. See the "Acceptance of AI Generated Code" section in the > contributor guide (I'm traveling so cannot provide you with a link right > now) if you want to know more. True, some AI was used in thi patch, I was aware about the 'Assisted-By: ' tag used in Zephyr, not about the 'AI-Generated: ' used as convention here. Missed that part of the doc although it is clearly and well documented. Will submit a v2 with that fixed. > On 8/5/26 2:14 PM, Martin Herren via lists.yoctoproject.org wrote: > > From: Martin Herren <sputnik@on-the-web.ch> > > > > OE-Core now parses LICENSE as an SPDX expression and warns on legacy > > non-SPDX names such as "Proprietary". > > > > Switch the rkbin family (rockchip-rkbin.inc, used by -ddr, -optee-os and > > -tf-a) to a recipe-specific LicenseRef backed by NO_GENERIC_LICENSE, so > > the SPDX manifest references the real Rockchip LICENSE at the repo root. > > > > References: oe-core e9d424738d6f ("classes/conf/lib: Parse LICENSE as SPDX Expression") > > > > Signed-off-by: Martin Herren <sputnik@on-the-web.ch> > > --- > > recipes-bsp/rkbin/rockchip-rkbin.inc | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/recipes-bsp/rkbin/rockchip-rkbin.inc b/recipes-bsp/rkbin/rockchip-rkbin.inc > > index 9ddd54f..d715b44 100644 > > --- a/recipes-bsp/rkbin/rockchip-rkbin.inc > > +++ b/recipes-bsp/rkbin/rockchip-rkbin.inc > > @@ -1,7 +1,8 @@ > > SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" > > SRCREV = "f43a462e7a1429a9d407ae52b4745033034a6cf9" > > -LICENSE = > > "Proprietary" > > +LICENSE = "LicenseRef-Rockchip-rkbin" > > LIC_FILES_CHKSUM = "file://LICENSE;md5=11e3673115959bf596feaaa6ea7ce9a5" > > +NO_GENERIC_LICENSE[Rockchip-rkbin] = "LICENSE" > > > > This seems to follow what we've done for > meta/recipes-kernel/linux-firmware/linux-firmware_*.bb so looks good to Yes, the goal was to follow as much as possible with how it is done elsewhere in other layers. Thanks again and a v2 will follow shorty ! /Martin > me, thus: > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > Thanks! > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#4639): https://lists.yoctoproject.org/g/yocto-patches/message/4639 > Mute This Topic: https://lists.yoctoproject.org/mt/120608960/10317775 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/15057071/10317775/2038727303/xyzzy [sputnik@on-the-web.ch] > -=-=-=-=-=-=-=-=-=-=-=- > > >
diff --git a/recipes-bsp/rkbin/rockchip-rkbin.inc b/recipes-bsp/rkbin/rockchip-rkbin.inc index 9ddd54f..d715b44 100644 --- a/recipes-bsp/rkbin/rockchip-rkbin.inc +++ b/recipes-bsp/rkbin/rockchip-rkbin.inc @@ -1,7 +1,8 @@ SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" SRCREV = "f43a462e7a1429a9d407ae52b4745033034a6cf9" -LICENSE = "Proprietary" +LICENSE = "LicenseRef-Rockchip-rkbin" LIC_FILES_CHKSUM = "file://LICENSE;md5=11e3673115959bf596feaaa6ea7ce9a5" +NO_GENERIC_LICENSE[Rockchip-rkbin] = "LICENSE" inherit bin_package deploy