| Message ID | 20260625155800.28627-1-afd@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-ti,master/wrynose] linux-firmware: Move recipe from meta-arago | expand |
meta-ti / na / 20260625155800.28627-1-afd
PRC Results: FAIL
=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed
=========================================================
apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-ti][master/wrynose][PATCH] linux-firmware: Move recipe from meta-arago
- Submitter: From: Andrew Davis <afd@ti.com>
- Date: Date: Thu, 25 Jun 2026 10:58:00 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 0299ddb1d9ece21f81362bbd840e9b679500493a
Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: master-wip
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: TEST: linux-ti-staging: Add testing dtbo and build command
- Commit SHA: 07bd4c181e2a400d4375ddad7a20fbba6578b133
Patches
----------------------------------------
All patches applied
wrynose
=====================
Summary:
- Patch Series: [meta-ti][master/wrynose][PATCH] linux-firmware: Move recipe from meta-arago
- Submitter: From: Andrew Davis <afd@ti.com>
- Date: Date: Thu, 25 Jun 2026 10:58:00 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 0299ddb1d9ece21f81362bbd840e9b679500493a
Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: wrynose-wip
- Commit Author: Suhaas Joshi <s-joshi@ti.com>
- Commit Subject: tfa: Update TF-A for K3 devices to 2.15 tag
- Commit SHA: 88ce8160ec6c5804820555e0bc29dba23059a4a1
Patches
----------------------------------------
All patches applied
=========================================================
check-yocto-repo: FAIL
=========================================================
master
=====================
FAIL
WARN: .bbappend files might need a guard to make them check-layer compliant. (GUARD-1)
meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
wrynose
=====================
FAIL
WARN: .bbappend files might need a guard to make them check-layer compliant. (GUARD-1)
meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
Is there a good reason that you dropped the guard structure that meta-arago had when you ported it over to meta-ti? Even though what you are doing is technically ok, it still stands out versus almost all other bbappend patterns that we have in both repos. On 6/25/2026 10:58 AM, Andrew Davis wrote: > The conflicting firmware packages that necessitate this bbappend are > all here in meta-ti-bsp, so this will be needed by any distro using > this layer. Move this bbappend out of meta-arago to this layer. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../linux-firmware/linux-firmware_%.bbappend | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend > > diff --git a/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend > new file mode 100644 > index 00000000..b37bec7a > --- /dev/null > +++ b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend > @@ -0,0 +1,7 @@ > +PR:append:ti-soc = ".tisoc1" > + > +# meta-ti-bsp packages newer versions on these > +do_install:append:ti-soc() { > + rm -rf ${D}${nonarch_base_libdir}/firmware/ti-connectivity/ > + rm -rf ${D}${nonarch_base_libdir}/firmware/cadence/ > +}
On 6/25/26 11:14 AM, Ryan Eatmon wrote: > > Is there a good reason that you dropped the guard structure that meta-arago had when you ported it over to meta-ti? Even though what you are doing is technically ok, it still stands out versus almost all other bbappend patterns that we have in both repos. > It just felt unnecessary to do that two file indirection thing that some other bbappends do on such a simple update, perhaps some other bbappends should look more like this one instead.. And this isn't the only bbappend like this in meta-ti, see - binutils-cross-canadian_%.bbappend - eudev_%.bbappend Andrew > > On 6/25/2026 10:58 AM, Andrew Davis wrote: >> The conflicting firmware packages that necessitate this bbappend are >> all here in meta-ti-bsp, so this will be needed by any distro using >> this layer. Move this bbappend out of meta-arago to this layer. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> .../linux-firmware/linux-firmware_%.bbappend | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend >> >> diff --git a/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend >> new file mode 100644 >> index 00000000..b37bec7a >> --- /dev/null >> +++ b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend >> @@ -0,0 +1,7 @@ >> +PR:append:ti-soc = ".tisoc1" >> + >> +# meta-ti-bsp packages newer versions on these >> +do_install:append:ti-soc() { >> + rm -rf ${D}${nonarch_base_libdir}/firmware/ti-connectivity/ >> + rm -rf ${D}${nonarch_base_libdir}/firmware/cadence/ >> +} >
diff --git a/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend new file mode 100644 index 00000000..b37bec7a --- /dev/null +++ b/meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend @@ -0,0 +1,7 @@ +PR:append:ti-soc = ".tisoc1" + +# meta-ti-bsp packages newer versions on these +do_install:append:ti-soc() { + rm -rf ${D}${nonarch_base_libdir}/firmware/ti-connectivity/ + rm -rf ${D}${nonarch_base_libdir}/firmware/cadence/ +}
The conflicting firmware packages that necessitate this bbappend are all here in meta-ti-bsp, so this will be needed by any distro using this layer. Move this bbappend out of meta-arago to this layer. Signed-off-by: Andrew Davis <afd@ti.com> --- .../linux-firmware/linux-firmware_%.bbappend | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 meta-ti-bsp/recipes-kernel/linux-firmware/linux-firmware_%.bbappend