diff mbox series

[meta-rockchip] u-boot: fix incorrect commit reference (radxa-zero-3)

Message ID 20260622134626.3616736-1-cleiton.bueno@b2open.com
State New
Headers show
Series [meta-rockchip] u-boot: fix incorrect commit reference (radxa-zero-3) | expand

Commit Message

Cleiton Bueno June 22, 2026, 1:46 p.m. UTC
The commit 8cdf606 is incorrect and does not belong to any
branch on this repository, it may belong to a fork outside of
the repository. The correct commit should be:
2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead

Signed-off-by: Cleiton Bueno <cleiton.bueno@b2open.com>
---
 recipes-bsp/u-boot/u-boot_%.bbappend | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz June 22, 2026, 4 p.m. UTC | #1
Hi Cleiton,

On 6/22/26 3:46 PM, Cleiton Bueno via lists.yoctoproject.org wrote:
> [You don't often get email from cleiton.bueno=b2open.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> The commit 8cdf606 is incorrect and does not belong to any
> branch on this repository, it may belong to a fork outside of
> the repository. The correct commit should be:
> 2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead
> 
> Signed-off-by: Cleiton Bueno <cleiton.bueno@b2open.com>
> ---
>   recipes-bsp/u-boot/u-boot_%.bbappend | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend
> index c939a48..9432e2b 100644
> --- a/recipes-bsp/u-boot/u-boot_%.bbappend
> +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
> @@ -3,8 +3,8 @@ require u-boot-rockchip.inc
>   FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
> 
>   SRC_URI:radxa-zero-3 = "git://github.com/Kwiboo/u-boot-rockchip.git;protocol=https;branch=rk3xxx-2024.07;name=Kwiboo"
> -SRCREV:radxa-zero-3 = "8cdf606e616baa36751f3b4adcfaefc781126c8c"
> -SRCREV:radxa-zero-3:rk-u-boot-env = "8cdf606e616baa36751f3b4adcfaefc781126c8c"
> +SRCREV:radxa-zero-3 = "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
> +SRCREV:radxa-zero-3:rk-u-boot-env = "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
> 

This code doesn't exist anymore since Walnascar, on which branch of 
meta-rockchip are you building?

If it's for scarthgap/styhead, I think it'd make more sense to add 
upstream 2024.10 (or later) U-Boot recipe since the board is supported 
starting that version.

Jonas (Kwiboo) is the sole owner of that repo and may freely decide to 
rebase branches or delete them, so we should really aim at not using it.

Cheers,
Quentin
Cleiton Bueno June 22, 2026, 4:06 p.m. UTC | #2
Understood!

I'll move u-boot upstream and test it. If it works, I'll send a patch with
this modification to radxa-zero-3w as soon as it's working.

Em seg., 22 de jun. de 2026 às 13:00, Quentin Schulz <
quentin.schulz@cherry.de> escreveu:

> Hi Cleiton,
>
> On 6/22/26 3:46 PM, Cleiton Bueno via lists.yoctoproject.org wrote:
> > [You don't often get email from cleiton.bueno=
> b2open.com@lists.yoctoproject.org. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> >
> > The commit 8cdf606 is incorrect and does not belong to any
> > branch on this repository, it may belong to a fork outside of
> > the repository. The correct commit should be:
> > 2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead
> >
> > Signed-off-by: Cleiton Bueno <cleiton.bueno@b2open.com>
> > ---
> >   recipes-bsp/u-boot/u-boot_%.bbappend | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend
> b/recipes-bsp/u-boot/u-boot_%.bbappend
> > index c939a48..9432e2b 100644
> > --- a/recipes-bsp/u-boot/u-boot_%.bbappend
> > +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
> > @@ -3,8 +3,8 @@ require u-boot-rockchip.inc
> >   FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
> >
> >   SRC_URI:radxa-zero-3 = "git://
> github.com/Kwiboo/u-boot-rockchip.git;protocol=https;branch=rk3xxx-2024.07;name=Kwiboo
> "
> > -SRCREV:radxa-zero-3 = "8cdf606e616baa36751f3b4adcfaefc781126c8c"
> > -SRCREV:radxa-zero-3:rk-u-boot-env =
> "8cdf606e616baa36751f3b4adcfaefc781126c8c"
> > +SRCREV:radxa-zero-3 = "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
> > +SRCREV:radxa-zero-3:rk-u-boot-env =
> "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
> >
>
> This code doesn't exist anymore since Walnascar, on which branch of
> meta-rockchip are you building?
>
> If it's for scarthgap/styhead, I think it'd make more sense to add
> upstream 2024.10 (or later) U-Boot recipe since the board is supported
> starting that version.
>
> Jonas (Kwiboo) is the sole owner of that repo and may freely decide to
> rebase branches or delete them, so we should really aim at not using it.
>
> Cheers,
> Quentin
>


--
Quentin Schulz June 22, 2026, 4:31 p.m. UTC | #3
Hi Cleiton,

On 6/22/26 6:06 PM, Cleiton Bueno wrote:
> Understood!
> 
> I'll move u-boot upstream and test it. If it works, I'll send a patch with
> this modification to radxa-zero-3w as soon as it's working.
> 

I think it works given commit 1cdcb4960374 ("u-boot: use upstream for 
radxa-zero-3{e|w}").

Please have a separate recipe though, we don't want to only change the 
SRCREV in this u-boot_%.bbappend.

Cheers,
Quentin
diff mbox series

Patch

diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend
index c939a48..9432e2b 100644
--- a/recipes-bsp/u-boot/u-boot_%.bbappend
+++ b/recipes-bsp/u-boot/u-boot_%.bbappend
@@ -3,8 +3,8 @@  require u-boot-rockchip.inc
 FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
 
 SRC_URI:radxa-zero-3 = "git://github.com/Kwiboo/u-boot-rockchip.git;protocol=https;branch=rk3xxx-2024.07;name=Kwiboo"
-SRCREV:radxa-zero-3 = "8cdf606e616baa36751f3b4adcfaefc781126c8c"
-SRCREV:radxa-zero-3:rk-u-boot-env = "8cdf606e616baa36751f3b4adcfaefc781126c8c"
+SRCREV:radxa-zero-3 = "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
+SRCREV:radxa-zero-3:rk-u-boot-env = "2e2ae1fb69a25217640bfe2fb9abaf9f4fbacead"
 
 SRC_URI:append:rk-u-boot-env = " file://rockchip-enable-environment-mmc.cfg"
 SRCREV:rk-u-boot-env = "cdfcc37428e06f4730ab9a17cc084eeb7676ea1a"