diff mbox series

arm/edk2-basetools-native: add util-linux-native to DEPENDS

Message ID 20260525130656.2119859-1-igor.opaniuk@foundries.io
State New
Headers show
Series arm/edk2-basetools-native: add util-linux-native to DEPENDS | expand

Commit Message

Igor Opaniuk May 25, 2026, 1:06 p.m. UTC
The C host tools GenFv and GenFfs include <uuid/uuid.h> from libuuid,
which is provided by util-linux. Without an explicit dependency the
build relies on the header being present in the host system, which
breaks reproducible builds and fails on hosts without uuid-dev
installed:

  GenFvInternalLib.c:21:10: fatal error: uuid/uuid.h: No such file or directory
     21 | #include <uuid/uuid.h>
        |          ^~~~~~~~~~~~~
  compilation terminated.

Add util-linux-native to DEPENDS so libuuid is staged into the native
sysroot before compilation.

Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
---
 meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jon Mason May 26, 2026, 1:46 p.m. UTC | #1
This issue was patched by Alex Chapman in
https://lists.yoctoproject.org/g/meta-arm/message/7057

Since that one looks more complete, I'm inclined to take that one.  If
you can verify and respond to it with your "Reviewed-by", then I'd be
appreciative (and you can get some credit for doing the work in the
git log).

Thanks,
Jon

On Mon, May 25, 2026 at 9:07 AM Igor Opaniuk via
lists.yoctoproject.org
<igor.opaniuk=foundries.io@lists.yoctoproject.org> wrote:
>
> The C host tools GenFv and GenFfs include <uuid/uuid.h> from libuuid,
> which is provided by util-linux. Without an explicit dependency the
> build relies on the header being present in the host system, which
> breaks reproducible builds and fails on hosts without uuid-dev
> installed:
>
>   GenFvInternalLib.c:21:10: fatal error: uuid/uuid.h: No such file or directory
>      21 | #include <uuid/uuid.h>
>         |          ^~~~~~~~~~~~~
>   compilation terminated.
>
> Add util-linux-native to DEPENDS so libuuid is staged into the native
> sysroot before compilation.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
> ---
>  meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb b/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
> index e2d927e2..35dc199c 100644
> --- a/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
> +++ b/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
> @@ -25,6 +25,8 @@ UPSTREAM_CHECK_GITTAGREGEX = "^edk2-stable(?P<pver>\d+)$"
>
>  inherit native
>
> +DEPENDS += "util-linux-native"
> +
>  RDEPENDS:${PN} += "python3-core"
>
>  do_compile() {
> --
> 2.53.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7062): https://lists.yoctoproject.org/g/meta-arm/message/7062
> Mute This Topic: https://lists.yoctoproject.org/mt/119480149/3616920
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb b/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
index e2d927e2..35dc199c 100644
--- a/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
+++ b/meta-arm/recipes-bsp/uefi/edk2-basetools-native_202602.bb
@@ -25,6 +25,8 @@  UPSTREAM_CHECK_GITTAGREGEX = "^edk2-stable(?P<pver>\d+)$"
 
 inherit native
 
+DEPENDS += "util-linux-native"
+
 RDEPENDS:${PN} += "python3-core"
 
 do_compile() {