diff mbox series

[meta-arago,master] ltp-ddt: Fix install error

Message ID 20260428144042.849713-1-reatmon@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,master] ltp-ddt: Fix install error | expand

Commit Message

Ryan Eatmon April 28, 2026, 2:40 p.m. UTC 
Something in the oe-core commit [1] is exposing an existing issue with
the ltp-ddt install flow.  The runtest/ddt sub directory was being
chmodded to 644 which stripped the execute bit make the directory, not a
directory.

Attached patch fixes the issue in ltp-ddt.  We are waiting for testing
of this patch to make sure this works before accepting the patch change
in ltp-ddt itself.

[1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=8ea63d320aba32d3894cace9e71e850bdff1d6b2

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 ...01-include-mk-Fix-installing-subdirs.patch | 49 +++++++++++++++++++
 .../recipes-devtools/ltp-ddt/ltp_20260130.inc |  1 +
 2 files changed, 50 insertions(+)
 create mode 100644 meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch

Comments

Denys Dmytriyenko April 28, 2026, 2:48 p.m. UTC | #1 
On Tue, Apr 28, 2026 at 09:40:42AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> Something in the oe-core commit [1] is exposing an existing issue with
> the ltp-ddt install flow.  The runtest/ddt sub directory was being
> chmodded to 644 which stripped the execute bit make the directory, not a
> directory.
> 
> Attached patch fixes the issue in ltp-ddt.  We are waiting for testing
> of this patch to make sure this works before accepting the patch change
> in ltp-ddt itself.
> 
> [1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=8ea63d320aba32d3894cace9e71e850bdff1d6b2
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  ...01-include-mk-Fix-installing-subdirs.patch | 49 +++++++++++++++++++
>  .../recipes-devtools/ltp-ddt/ltp_20260130.inc |  1 +
>  2 files changed, 50 insertions(+)
>  create mode 100644 meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
> 
> diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
> new file mode 100644
> index 00000000..5f970a12
> --- /dev/null
> +++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
> @@ -0,0 +1,49 @@
> +From 5907227ad86a93b084a52a7ff8dd8cb791c228a5 Mon Sep 17 00:00:00 2001
> +From: Ryan Eatmon <reatmon@ti.com>
> +Date: Mon, 27 Apr 2026 11:02:32 -0500
> +Subject: [PATCH] include/mk: Fix installing subdirs
> +
> +When installing sub directories, the INSTALL_MODE was being used for the
> +dirs as well.  But in runtest/Makefile the INSTALL_MODE is being set to
> +00644.  This causes the ddt dir to lose the execute bits and stop acting
> +like a directory.
> +
> +Simple fix is create INSTALL_MODE_DIR and use it when installing
> +directories.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> +---
> + include/mk/env_post.mk  | 1 +
> + include/mk/functions.mk | 2 +-
> + 2 files changed, 2 insertions(+), 1 deletion(-)
> +
> +diff --git a/include/mk/env_post.mk b/include/mk/env_post.mk
> +index ab31da73a..c2e85439a 100644
> +--- a/include/mk/env_post.mk
> ++++ b/include/mk/env_post.mk
> +@@ -58,6 +58,7 @@ INSTALL_TARGETS			:= $(patsubst $(abs_srcdir)/%,%,$(INSTALL_TARGETS))
> + # The large majority of the files that we install are going to be apps and
> + # scripts, so let's chmod them like that.
> + INSTALL_MODE			?= 00775
> ++INSTALL_MODE_DIR		?= 00775
> + 
> + $(abspath $(addprefix $(DESTDIR)/$(INSTALL_DIR)/,$(sort $(dir $(INSTALL_TARGETS) $(MAKE_TARGETS))))):
> + 	mkdir -p "$@"
> +diff --git a/include/mk/functions.mk b/include/mk/functions.mk
> +index 60dbed395..8e4bc973c 100644
> +--- a/include/mk/functions.mk
> ++++ b/include/mk/functions.mk
> +@@ -18,7 +18,7 @@ INSTALL_FILES		+= $$(abspath $$(DESTDIR)/$(3)/$(1))
> + 
> + $$(abspath $$(DESTDIR)/$(3)/$(1)): \
> +     $$(abspath $$(dir $$(DESTDIR)/$(3)/$(1)))
> +-	install -m $$(INSTALL_MODE) $(shell test -d "$(2)/$(1)" && echo "-d") $(PARAM) "$(2)/$(1)" $$@
> ++	install $(shell test -d "$(2)/$(1)" || echo "-m $(INSTALL_MODE)") $(shell test -d "$(2)/$(1)" && echo "-m $(INSTALL_MODE_DIR) -d") $(PARAM) "$(2)/$(1)" $$@
> + 	$(shell test -d "$(2)/$(1)" && echo "install -m "'$$(INSTALL_MODE) $(PARAM)' "$(2)/$(1)/*" -t '$$@')
> + endef
> + 
> +-- 
> +2.43.0
> +
> diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
> index 4c19d870..560e9b4e 100644
> --- a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
> +++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
> @@ -31,6 +31,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=ht
>             file://0001-Add-__clear_cache-declaration-for-clang.patch \
>             file://0001-syscalls-semctl08-Skip-semctl08-when-__USE_TIME64_RE.patch \
>             file://0001-ltp-fix-build-failure-with-glibc-2.43.patch \
> +           file://0001-include-mk-Fix-installing-subdirs.patch \

If this is fixing ltp-ddt, then the patch should go to ltp-ddt recipe, not 
upstream ltp.

It could be applicable to upstream ltp, but I believe "ddt" is the only 
directory under runtest, so seems to be specific to ltp-ddt.


>            "
>  
>  inherit autotools-brokensep pkgconfig
> -- 
> 2.43.0
Ryan Eatmon April 28, 2026, 3:06 p.m. UTC | #2 
On 4/28/2026 9:48 AM, Denys Dmytriyenko wrote:
> On Tue, Apr 28, 2026 at 09:40:42AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
>> Something in the oe-core commit [1] is exposing an existing issue with
>> the ltp-ddt install flow.  The runtest/ddt sub directory was being
>> chmodded to 644 which stripped the execute bit make the directory, not a
>> directory.
>>
>> Attached patch fixes the issue in ltp-ddt.  We are waiting for testing
>> of this patch to make sure this works before accepting the patch change
>> in ltp-ddt itself.
>>
>> [1] https://git.openembedded.org/openembedded-core/commit/?h=master&id=8ea63d320aba32d3894cace9e71e850bdff1d6b2
>>
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>>   ...01-include-mk-Fix-installing-subdirs.patch | 49 +++++++++++++++++++
>>   .../recipes-devtools/ltp-ddt/ltp_20260130.inc |  1 +
>>   2 files changed, 50 insertions(+)
>>   create mode 100644 meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
>>
>> diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
>> new file mode 100644
>> index 00000000..5f970a12
>> --- /dev/null
>> +++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
>> @@ -0,0 +1,49 @@
>> +From 5907227ad86a93b084a52a7ff8dd8cb791c228a5 Mon Sep 17 00:00:00 2001
>> +From: Ryan Eatmon <reatmon@ti.com>
>> +Date: Mon, 27 Apr 2026 11:02:32 -0500
>> +Subject: [PATCH] include/mk: Fix installing subdirs
>> +
>> +When installing sub directories, the INSTALL_MODE was being used for the
>> +dirs as well.  But in runtest/Makefile the INSTALL_MODE is being set to
>> +00644.  This causes the ddt dir to lose the execute bits and stop acting
>> +like a directory.
>> +
>> +Simple fix is create INSTALL_MODE_DIR and use it when installing
>> +directories.
>> +
>> +Upstream-Status: Pending
>> +
>> +Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> +---
>> + include/mk/env_post.mk  | 1 +
>> + include/mk/functions.mk | 2 +-
>> + 2 files changed, 2 insertions(+), 1 deletion(-)
>> +
>> +diff --git a/include/mk/env_post.mk b/include/mk/env_post.mk
>> +index ab31da73a..c2e85439a 100644
>> +--- a/include/mk/env_post.mk
>> ++++ b/include/mk/env_post.mk
>> +@@ -58,6 +58,7 @@ INSTALL_TARGETS			:= $(patsubst $(abs_srcdir)/%,%,$(INSTALL_TARGETS))
>> + # The large majority of the files that we install are going to be apps and
>> + # scripts, so let's chmod them like that.
>> + INSTALL_MODE			?= 00775
>> ++INSTALL_MODE_DIR		?= 00775
>> +
>> + $(abspath $(addprefix $(DESTDIR)/$(INSTALL_DIR)/,$(sort $(dir $(INSTALL_TARGETS) $(MAKE_TARGETS))))):
>> + 	mkdir -p "$@"
>> +diff --git a/include/mk/functions.mk b/include/mk/functions.mk
>> +index 60dbed395..8e4bc973c 100644
>> +--- a/include/mk/functions.mk
>> ++++ b/include/mk/functions.mk
>> +@@ -18,7 +18,7 @@ INSTALL_FILES		+= $$(abspath $$(DESTDIR)/$(3)/$(1))
>> +
>> + $$(abspath $$(DESTDIR)/$(3)/$(1)): \
>> +     $$(abspath $$(dir $$(DESTDIR)/$(3)/$(1)))
>> +-	install -m $$(INSTALL_MODE) $(shell test -d "$(2)/$(1)" && echo "-d") $(PARAM) "$(2)/$(1)" $$@
>> ++	install $(shell test -d "$(2)/$(1)" || echo "-m $(INSTALL_MODE)") $(shell test -d "$(2)/$(1)" && echo "-m $(INSTALL_MODE_DIR) -d") $(PARAM) "$(2)/$(1)" $$@
>> + 	$(shell test -d "$(2)/$(1)" && echo "install -m "'$$(INSTALL_MODE) $(PARAM)' "$(2)/$(1)/*" -t '$$@')
>> + endef
>> +
>> +--
>> +2.43.0
>> +
>> diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
>> index 4c19d870..560e9b4e 100644
>> --- a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
>> +++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
>> @@ -31,6 +31,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=ht
>>              file://0001-Add-__clear_cache-declaration-for-clang.patch \
>>              file://0001-syscalls-semctl08-Skip-semctl08-when-__USE_TIME64_RE.patch \
>>              file://0001-ltp-fix-build-failure-with-glibc-2.43.patch \
>> +           file://0001-include-mk-Fix-installing-subdirs.patch \
> 
> If this is fixing ltp-ddt, then the patch should go to ltp-ddt recipe, not
> upstream ltp.
> 
> It could be applicable to upstream ltp, but I believe "ddt" is the only
> directory under runtest, so seems to be specific to ltp-ddt.

Agreed.  I'll send a v2.  but this will likely be a very short lived 
patch as we are patching the ltp-ddt repo itself too.


> 
>>             "
>>   
>>   inherit autotools-brokensep pkgconfig
>> -- 
>> 2.43.0
PRC Automation April 28, 2026, 3:08 p.m. UTC | #3 
meta-arago / na / 20260428144042.849713-1-reatmon

PRC Results: PASS

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [meta-arago][master][PATCH] ltp-ddt: Fix install error
    WARN: Commit message should not include directory path to recipe: ltp-ddt: Fix install error.
              ltp-ddt (COMMIT-MESSAGE-3)
        patch
    
    For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887



=========================================================
  apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master][PATCH] ltp-ddt: Fix install error
- Submitter: From: Ryan Eatmon <reatmon@ti.com>
+From: Ryan Eatmon <reatmon@ti.com>
- Date: Date: Tue, 28 Apr 2026 09:40:42 -0500
+Date: Mon, 27 Apr 2026 11:02:32 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 1b779ee9a6009d5c573183143d2faeddeaa70051

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Randolph Sapp <rs@ti.com>
- Commit Subject: qtbase: remove serial event 0 handling
- Commit SHA: 5ac854ed85c79c1756aac168dc38f78591c2cbd1

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: PASS
=========================================================
master
=====================
PASS



=========================================================
  yocto-check-layers: PASS
=========================================================
master - PASS
=====================
All checks passed
diff mbox series

Patch

diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
new file mode 100644
index 00000000..5f970a12
--- /dev/null
+++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt/0001-include-mk-Fix-installing-subdirs.patch
@@ -0,0 +1,49 @@ 
+From 5907227ad86a93b084a52a7ff8dd8cb791c228a5 Mon Sep 17 00:00:00 2001
+From: Ryan Eatmon <reatmon@ti.com>
+Date: Mon, 27 Apr 2026 11:02:32 -0500
+Subject: [PATCH] include/mk: Fix installing subdirs
+
+When installing sub directories, the INSTALL_MODE was being used for the
+dirs as well.  But in runtest/Makefile the INSTALL_MODE is being set to
+00644.  This causes the ddt dir to lose the execute bits and stop acting
+like a directory.
+
+Simple fix is create INSTALL_MODE_DIR and use it when installing
+directories.
+
+Upstream-Status: Pending
+
+Signed-off-by: Ryan Eatmon <reatmon@ti.com>
+---
+ include/mk/env_post.mk  | 1 +
+ include/mk/functions.mk | 2 +-
+ 2 files changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/include/mk/env_post.mk b/include/mk/env_post.mk
+index ab31da73a..c2e85439a 100644
+--- a/include/mk/env_post.mk
++++ b/include/mk/env_post.mk
+@@ -58,6 +58,7 @@ INSTALL_TARGETS			:= $(patsubst $(abs_srcdir)/%,%,$(INSTALL_TARGETS))
+ # The large majority of the files that we install are going to be apps and
+ # scripts, so let's chmod them like that.
+ INSTALL_MODE			?= 00775
++INSTALL_MODE_DIR		?= 00775
+ 
+ $(abspath $(addprefix $(DESTDIR)/$(INSTALL_DIR)/,$(sort $(dir $(INSTALL_TARGETS) $(MAKE_TARGETS))))):
+ 	mkdir -p "$@"
+diff --git a/include/mk/functions.mk b/include/mk/functions.mk
+index 60dbed395..8e4bc973c 100644
+--- a/include/mk/functions.mk
++++ b/include/mk/functions.mk
+@@ -18,7 +18,7 @@ INSTALL_FILES		+= $$(abspath $$(DESTDIR)/$(3)/$(1))
+ 
+ $$(abspath $$(DESTDIR)/$(3)/$(1)): \
+     $$(abspath $$(dir $$(DESTDIR)/$(3)/$(1)))
+-	install -m $$(INSTALL_MODE) $(shell test -d "$(2)/$(1)" && echo "-d") $(PARAM) "$(2)/$(1)" $$@
++	install $(shell test -d "$(2)/$(1)" || echo "-m $(INSTALL_MODE)") $(shell test -d "$(2)/$(1)" && echo "-m $(INSTALL_MODE_DIR) -d") $(PARAM) "$(2)/$(1)" $$@
+ 	$(shell test -d "$(2)/$(1)" && echo "install -m "'$$(INSTALL_MODE) $(PARAM)' "$(2)/$(1)/*" -t '$$@')
+ endef
+ 
+-- 
+2.43.0
+
diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
index 4c19d870..560e9b4e 100644
--- a/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
+++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp_20260130.inc
@@ -31,6 +31,7 @@  SRC_URI = "git://github.com/linux-test-project/ltp.git;branch=master;protocol=ht
            file://0001-Add-__clear_cache-declaration-for-clang.patch \
            file://0001-syscalls-semctl08-Skip-semctl08-when-__USE_TIME64_RE.patch \
            file://0001-ltp-fix-build-failure-with-glibc-2.43.patch \
+           file://0001-include-mk-Fix-installing-subdirs.patch \
           "
 
 inherit autotools-brokensep pkgconfig