| Message ID | 20220512152846.661-1-a-m1@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,dunfell] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK | expand |
On 5/12/2022 10:28, Aparna M wrote: > Add ti-sci-firmware binaries required for uboot build to the > prebuilt-images directory of SDK. > > Signed-off-by: Aparna M <a-m1@ti.com> > --- > meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++ > 1 file changed, 3 insertions(+) > > This patch is dependent on > https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 > > diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > index 9ebcbb0e..d5a11f36 100644 > --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb" > DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb" > DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb" > DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin" > +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin" > +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its" > +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f" > > ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle" > export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}" Same as the other patch on meta-ti. I think the ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this file. The other changes are fine, but remove that one.
On 10:35-20220512, Ryan Eatmon wrote: > > > On 5/12/2022 10:28, Aparna M wrote: > > Add ti-sci-firmware binaries required for uboot build to the > > prebuilt-images directory of SDK. > > > > Signed-off-by: Aparna M <a-m1@ti.com> > > --- > > meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++ > > 1 file changed, 3 insertions(+) > > > > This patch is dependent on > > https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 > > > > diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > > index 9ebcbb0e..d5a11f36 100644 > > --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > > +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > > @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb" > > DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb" > > DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb" > > DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin" > > +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin" > > +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its" > > +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f" > > ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle" > > export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}" > > > Same as the other patch on meta-ti. I think the > ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this file. > The other changes are fine, but remove that one. I do NOT understand what purpose this serves! these are embedded in the boot images already. $commit message claims if you dont copy these files, system wont build? that is not true! Agreed these files are tiny, but they confuse the user as to what are the real images used to boot. Just switching this binary has 0 function on the deployed images!
On 12/05/22 21:05, Ryan Eatmon wrote: > > > On 5/12/2022 10:28, Aparna M wrote: >> Add ti-sci-firmware binaries required for uboot build to the >> prebuilt-images directory of SDK. >> >> Signed-off-by: Aparna M <a-m1@ti.com> >> --- >> meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++ >> 1 file changed, 3 insertions(+) >> >> This patch is dependent on >> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 >> As per suggestions on previous patch, this is the new patch dependency: https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133 >> >> diff --git >> a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb >> b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb >> index 9ebcbb0e..d5a11f36 100644 >> --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb >> +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb >> @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb" >> DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb" >> DEPLOY_IMAGES_NAME_append_am65xx-evm = " >> ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb >> sysfw-am65x_sr2-evm.itb" >> DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin" >> +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin" >> +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " >> ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin >> fitImage-its.its" >> +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin >> ipc_echo_testb_mcu1_0_release_strip.xer5f" >> ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle" >> export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}" > > > Same as the other patch on meta-ti. I think the > ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this > file. The other changes are fine, but remove that one. The ipc_echo_testb_mcu1_0_release_strip.xer5f file is required in the SDK for toplevel makefile uboot build for am62xx-evm. So it needs to be packaged in the prebuilt-images folder of the SDK. -- Aparna
On 02:57-20220513, M, Aparna wrote: > > On 12/05/22 21:05, Ryan Eatmon wrote: > > > > > > On 5/12/2022 10:28, Aparna M wrote: > >> Add ti-sci-firmware binaries required for uboot build to the > >> prebuilt-images directory of SDK. > >> > >> Signed-off-by: Aparna M <a-m1@ti.com> > >> --- > >> meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> This patch is dependent on > >> https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279 > >> > > As per suggestions on previous patch, this is the new patch dependency: > https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133 > > >> > >> diff --git > >> a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > >> b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > >> index 9ebcbb0e..d5a11f36 100644 > >> --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > >> +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb > >> @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb" > >> DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb" > >> DEPLOY_IMAGES_NAME_append_am65xx-evm = " > >> ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb > >> sysfw-am65x_sr2-evm.itb" > >> DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin" > >> +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin" > >> +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " > >> ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin > >> fitImage-its.its" > >> +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin > >> ipc_echo_testb_mcu1_0_release_strip.xer5f" > >> ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle" > >> export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}" > > > > > > Same as the other patch on meta-ti. I think the > > ipc_echo_testb_mcu1_0_release_strip.xer5f file needs to not be in this > > file. The other changes are fine, but remove that one. > > The ipc_echo_testb_mcu1_0_release_strip.xer5f file is required in the > SDK for toplevel makefile uboot build for am62xx-evm. So it needs to be > packaged in the prebuilt-images folder of the SDK. I dont understand why are we forcing this dependency? u-boot is built from source, the firmwares are in linux-firmware repositories. why are'nt the top level makefiles using the linux-firmware repo to pick up the correct binaries?
meta-arago / na / 20220512152846.661-1-a-m1
PRC Results: FAIL
=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed
=========================================================
apply-yocto-patch: FAIL
=========================================================
dunfell
=====================
Summary:
- Patch Series: [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
- Submitter: From: Aparna M <a-m1@ti.com>
- Date: Date: Thu, 12 May 2022 20:58:46 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 83a78130c6358a105f1334a7120232ee754e2c34
Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: dunfell
- Commit Author: Randolph Sapp <rs@ti.com>
- Commit Subject: meta-arago-distro: linux-firmware: remove cadence firmware
- Commit SHA: 86d19ced20934c8383c8a39f88d97c72e7e929ee
Patches
----------------------------------------
FAIL - [meta-arago][dunfell][PATCH] tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
Applying: tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
Patch failed at 0001 tisdk-core-bundle: Add ti-sci-firmware binary to prebuilt-images directory of SDK
error: patch failed: meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb:21
error: meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb: patch does not apply
diff --git a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb index 9ebcbb0e..d5a11f36 100644 --- a/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb +++ b/meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb @@ -21,6 +21,9 @@ DEPLOY_IMAGES_NAME_append_j7-evm = " sysfw.itb" DEPLOY_IMAGES_NAME_append_j7-hs-evm = " sysfw.itb" DEPLOY_IMAGES_NAME_append_am65xx-evm = " ti-sci-firmware-am65x-gp.bin sysfw-am65x-evm.itb sysfw-am65x_sr2-evm.itb" DEPLOY_IMAGES_NAME_append_j7-evm = " ti-fs-firmware-j721e-gp.bin" +DEPLOY_IMAGES_NAME_append_am64xx-evm = " ti-sci-firmware-am64x-gp.bin" +DEPLOY_IMAGES_NAME_append_am64xx-hs-evm = " ti-sci-firmware-am64x-hs-cert.bin ti-sci-firmware-am64x-hs-enc.bin fitImage-its.its" +DEPLOY_IMAGES_NAME_append_am62xx-evm = " ti-fs-firmware-am62x-gp.bin ipc_echo_testb_mcu1_0_release_strip.xer5f" ARAGO_TISDK_IMAGE ?= "tisdk-core-bundle" export IMAGE_BASENAME = "${ARAGO_TISDK_IMAGE}"
Add ti-sci-firmware binaries required for uboot build to the prebuilt-images directory of SDK. Signed-off-by: Aparna M <a-m1@ti.com> --- meta-arago-distro/recipes-core/images/tisdk-core-bundle.bb | 3 +++ 1 file changed, 3 insertions(+) This patch is dependent on https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch_ti_sci_fw/91058279