diff mbox series

[yocto-autobuilder2] schedulers: add meta-webosose scheduled build for scarthgap

Message ID 20250429021622.309740-1-hieu2.nguyen@lge.com
State New
Headers show
Series [yocto-autobuilder2] schedulers: add meta-webosose scheduled build for scarthgap | expand

Commit Message

Hieu Van Nguyen April 29, 2025, 2:16 a.m. UTC
From: Hieu Van Nguyen <hieu2.nguyen@lge.com>

Support to build meta-webosose for both of kirkstone and scarthgap
branches.

Signed-off-by: Hieu Van Nguyen <hieu2.nguyen@lge.com>
---
 schedulers.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Mathieu Dubois-Briand April 29, 2025, 6:37 a.m. UTC | #1
On Tue Apr 29, 2025 at 4:16 AM CEST, Hieu Van Nguyen via lists.yoctoproject.org wrote:
> From: Hieu Van Nguyen <hieu2.nguyen@lge.com>
>
> Support to build meta-webosose for both of kirkstone and scarthgap
> branches.
>
> Signed-off-by: Hieu Van Nguyen <hieu2.nguyen@lge.com>
> ---
>  schedulers.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/schedulers.py b/schedulers.py
> index fd2cad6..1fead60 100644
> --- a/schedulers.py
> +++ b/schedulers.py
> @@ -642,7 +642,10 @@ schedulers.append(sched.AnyBranchScheduler(name="bitbake-docs-changed",
>              properties=repos_dict_for_scheduler("docs"),
>              builderNames=["docs"]))
>  
> -# Run meta-webosose for kirkstone once a week on weekends (2am on Friday)
> +# Run meta-webosose for kirkstone and scarthgap once a week on weekends (2am on Friday)
>  schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='kirkstone', properties=parent_default_props('meta-webosose', 'kirkstone'),
>                                  codebases = {'' : {'branch' : 'kirkstone'}},
>                                  builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))
> +schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='scarthgap', properties=parent_default_props('meta-webosose', 'scarthgap'),
> +                                codebases = {'' : {'branch' : 'scarthgap'}},
> +                                builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))

Hi Hieu,

IIRC in your previous version you also had changes about meta-qt6
versions. Are these changes not needed anymore?
Martin Jansa April 29, 2025, 6:47 a.m. UTC | #2
On Tue, Apr 29, 2025 at 8:37 AM Mathieu Dubois-Briand
<mathieu.dubois-briand@bootlin.com> wrote:
>
> On Tue Apr 29, 2025 at 4:16 AM CEST, Hieu Van Nguyen via lists.yoctoproject.org wrote:
> > From: Hieu Van Nguyen <hieu2.nguyen@lge.com>
> >
> > Support to build meta-webosose for both of kirkstone and scarthgap
> > branches.
> >
> > Signed-off-by: Hieu Van Nguyen <hieu2.nguyen@lge.com>
> > ---
> >  schedulers.py | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/schedulers.py b/schedulers.py
> > index fd2cad6..1fead60 100644
> > --- a/schedulers.py
> > +++ b/schedulers.py
> > @@ -642,7 +642,10 @@ schedulers.append(sched.AnyBranchScheduler(name="bitbake-docs-changed",
> >              properties=repos_dict_for_scheduler("docs"),
> >              builderNames=["docs"]))
> >
> > -# Run meta-webosose for kirkstone once a week on weekends (2am on Friday)
> > +# Run meta-webosose for kirkstone and scarthgap once a week on weekends (2am on Friday)
> >  schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='kirkstone', properties=parent_default_props('meta-webosose', 'kirkstone'),
> >                                  codebases = {'' : {'branch' : 'kirkstone'}},
> >                                  builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))
> > +schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='scarthgap', properties=parent_default_props('meta-webosose', 'scarthgap'),
> > +                                codebases = {'' : {'branch' : 'scarthgap'}},
> > +                                builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))
>
> Hi Hieu,
>
> IIRC in your previous version you also had changes about meta-qt6
> versions. Are these changes not needed anymore?

Maybe you mean this commit:
https://web.git.yoctoproject.org/yocto-autobuilder2/commit/?id=21b5aa780ea79c32b340d53aaef808520983b88b
which was already merged and the same version should be used for both
kirkstone and scarthgap based builds.

Cheers,
Mathieu Dubois-Briand April 29, 2025, 8:35 a.m. UTC | #3
On Tue Apr 29, 2025 at 8:47 AM CEST, Martin Jansa wrote:
> On Tue, Apr 29, 2025 at 8:37 AM Mathieu Dubois-Briand
> <mathieu.dubois-briand@bootlin.com> wrote:
>>
>> IIRC in your previous version you also had changes about meta-qt6
>> versions. Are these changes not needed anymore?
>
> Maybe you mean this commit:
> https://web.git.yoctoproject.org/yocto-autobuilder2/commit/?id=21b5aa780ea79c32b340d53aaef808520983b88b
> which was already merged and the same version should be used for both
> kirkstone and scarthgap based builds.
>
> Cheers,

Oh yes, it was that!

So everything is fine, I'm OK to merge this patch.
Hieu Van Nguyen May 7, 2025, 1:06 p.m. UTC | #4
Hi Mathieu & Richard,

Could you please consider merging this patch? Let's see how the build goes, and we'll make further updates if necessary.

Thanks and best regards,

Hieu
Richard Purdie May 14, 2025, 10 a.m. UTC | #5
On Tue, 2025-04-29 at 11:16 +0900, Hieu Van Nguyen via lists.yoctoproject.org wrote:
> From: Hieu Van Nguyen <hieu2.nguyen@lge.com>
> 
> Support to build meta-webosose for both of kirkstone and scarthgap
> branches.
> 
> Signed-off-by: Hieu Van Nguyen <hieu2.nguyen@lge.com>
> ---
>  schedulers.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/schedulers.py b/schedulers.py
> index fd2cad6..1fead60 100644
> --- a/schedulers.py
> +++ b/schedulers.py
> @@ -642,7 +642,10 @@ schedulers.append(sched.AnyBranchScheduler(name="bitbake-docs-changed",
>              properties=repos_dict_for_scheduler("docs"),
>              builderNames=["docs"]))
>  
> -# Run meta-webosose for kirkstone once a week on weekends (2am on Friday)
> +# Run meta-webosose for kirkstone and scarthgap once a week on weekends (2am on Friday)
>  schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='kirkstone', properties=parent_default_props('meta-webosose', 'kirkstone'),
>                                  codebases = {'' : {'branch' : 'kirkstone'}},
>                                  builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))
> +schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='scarthgap', properties=parent_default_props('meta-webosose', 'scarthgap'),
> +                                codebases = {'' : {'branch' : 'scarthgap'}},
> +                                builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))

The patch breaks things since it has two schedulers with the same name.
I've tweaked the patch to fix that and applied it, sorry about the
delay.

Cheers,

Richard
diff mbox series

Patch

diff --git a/schedulers.py b/schedulers.py
index fd2cad6..1fead60 100644
--- a/schedulers.py
+++ b/schedulers.py
@@ -642,7 +642,10 @@  schedulers.append(sched.AnyBranchScheduler(name="bitbake-docs-changed",
             properties=repos_dict_for_scheduler("docs"),
             builderNames=["docs"]))
 
-# Run meta-webosose for kirkstone once a week on weekends (2am on Friday)
+# Run meta-webosose for kirkstone and scarthgap once a week on weekends (2am on Friday)
 schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='kirkstone', properties=parent_default_props('meta-webosose', 'kirkstone'),
                                 codebases = {'' : {'branch' : 'kirkstone'}},
                                 builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))
+schedulers.append(sched.Nightly(name='nightly-meta-webosose', branch='scarthgap', properties=parent_default_props('meta-webosose', 'scarthgap'),
+                                codebases = {'' : {'branch' : 'scarthgap'}},
+                                builderNames=['meta-webosose'], hour=2, minute=0, dayOfWeek=4))