[v2] zstd: add zstd-bin package

Message ID 20220325122950.1148-1-stefan.herbrechtsmeier-oss@weidmueller.com
State New
Headers show
Series [v2] zstd: add zstd-bin package | expand

Commit Message

Stefan Herbrechtsmeier March 25, 2022, 12:29 p.m. UTC
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

Add a zstd-bin package to remove libstdc++ runtime dependency from
library users and reduce the dependencies and size of the library
package.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

---

Changes in v2:
- Add zstd-bin package instead of libzstd package

 meta/recipes-extended/zstd/zstd_1.5.2.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Alexandre Belloni March 25, 2022, 7 p.m. UTC | #1
Hello,

On 25/03/2022 13:29:50+0100, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 
> Add a zstd-bin package to remove libstdc++ runtime dependency from
> library users and reduce the dependencies and size of the library
> package.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 

I believe this is the cause of:
https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/4954/steps/11/logs/stdio

Can you check?

> ---
> 
> Changes in v2:
> - Add zstd-bin package instead of libzstd package
> 
>  meta/recipes-extended/zstd/zstd_1.5.2.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-extended/zstd/zstd_1.5.2.bb b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> index 0ddff469b8..2fdb9b6950 100644
> --- a/meta/recipes-extended/zstd/zstd_1.5.2.bb
> +++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> @@ -18,6 +18,8 @@ CVE_PRODUCT = "zstandard"
>  
>  S = "${WORKDIR}/git"
>  
> +inherit lib_package
> +
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[lz4] = "HAVE_LZ4=1,HAVE_LZ4=0,lz4"
>  PACKAGECONFIG[lzma] = "HAVE_LZMA=1,HAVE_LZMA=0,xz"
> -- 
> 2.30.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#163639): https://lists.openembedded.org/g/openembedded-core/message/163639
> Mute This Topic: https://lists.openembedded.org/mt/90021107/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Alexandre Belloni March 25, 2022, 7:37 p.m. UTC | #2
On 25/03/2022 20:00:46+0100, Alexandre Belloni wrote:
> Hello,
> 
> On 25/03/2022 13:29:50+0100, Stefan Herbrechtsmeier wrote:
> > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> > 
> > Add a zstd-bin package to remove libstdc++ runtime dependency from
> > library users and reduce the dependencies and size of the library
> > package.
> > 
> > Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> > 
> 
> I believe this is the cause of:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/4954/steps/11/logs/stdio
> 
> Can you check?
> 

This also caused:
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20220325-3jr0bu2m/packages/diff-html/

> > ---
> > 
> > Changes in v2:
> > - Add zstd-bin package instead of libzstd package
> > 
> >  meta/recipes-extended/zstd/zstd_1.5.2.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-extended/zstd/zstd_1.5.2.bb b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> > index 0ddff469b8..2fdb9b6950 100644
> > --- a/meta/recipes-extended/zstd/zstd_1.5.2.bb
> > +++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> > @@ -18,6 +18,8 @@ CVE_PRODUCT = "zstandard"
> >  
> >  S = "${WORKDIR}/git"
> >  
> > +inherit lib_package
> > +
> >  PACKAGECONFIG ??= ""
> >  PACKAGECONFIG[lz4] = "HAVE_LZ4=1,HAVE_LZ4=0,lz4"
> >  PACKAGECONFIG[lzma] = "HAVE_LZMA=1,HAVE_LZMA=0,xz"
> > -- 
> > 2.30.2
> > 
> 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#163639): https://lists.openembedded.org/g/openembedded-core/message/163639
> > Mute This Topic: https://lists.openembedded.org/mt/90021107/3617179
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 
> 
> 
> -- 
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Stefan Herbrechtsmeier March 28, 2022, 8:17 a.m. UTC | #3
Hi,

Am 25.03.2022 um 20:00 schrieb Alexandre Belloni:
> On 25/03/2022 13:29:50+0100, Stefan Herbrechtsmeier wrote:
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> Add a zstd-bin package to remove libstdc++ runtime dependency from
>> library users and reduce the dependencies and size of the library
>> package.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
> 
> I believe this is the cause of:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/4954/steps/11/logs/stdio
> 
> Can you check?

The debian.bbclass renames the packages to libzstd-*. What is the 
correct way to handle this?

Should I rename nativesdk-zstd to nativesdk-libzstd-bin in 
buildtools-tarball.bb or should we take the first patch version which 
add a libzstd package only.

Regards
   Stefan

Patch

diff --git a/meta/recipes-extended/zstd/zstd_1.5.2.bb b/meta/recipes-extended/zstd/zstd_1.5.2.bb
index 0ddff469b8..2fdb9b6950 100644
--- a/meta/recipes-extended/zstd/zstd_1.5.2.bb
+++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
@@ -18,6 +18,8 @@  CVE_PRODUCT = "zstandard"
 
 S = "${WORKDIR}/git"
 
+inherit lib_package
+
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[lz4] = "HAVE_LZ4=1,HAVE_LZ4=0,lz4"
 PACKAGECONFIG[lzma] = "HAVE_LZMA=1,HAVE_LZMA=0,xz"