diff mbox series

[pseudo,1/2] ports/linux: Report SELinux as disabled under pseudo

Message ID 20261116190244.2205781-2-mark.hatle@amd.com
State New
Headers show
Series Attempt to prevent selinux related failures | expand

Commit Message

Mark Hatle Nov. 16, 2026, 7:02 p.m. UTC
SELinux-aware programs such as install label the files they create from
the host's policy.  pseudo only records the label, which is wrong for
target files and lets the host's policy leak into the build.  Programs
which then pass a recorded label to the kernel through
/proc/self/attr/fscreate, as sed -i does, can be refused when the build
runs in a confined SELinux domain, and fail.

Wrap is_selinux_enabled() and is_selinux_mls_enabled() to report SELinux
as disabled, so these programs behave as on a host without SELinux.
Labels set explicitly, e.g. by setfiles when labelling an image, are
still recorded.  The host's answer is only given while pseudo is
disabled; libselinux may not be loaded then, so it is looked up when
needed, and SELinux is reported as disabled without it.

test-selinux-disabled checks both answers with the host's libselinux,
and with a stand-in reporting SELinux as enabled, to emulate a host
where it is.  It is skipped if the host has no libselinux.

Based on a patch by Enrico Scholz attached to the bug.

[YOCTO #6580]

Reported-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
AI-Generated: Uses GitHub Copilot
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
---
 .gitignore                                |  1 +
 Makefile.in                               | 10 ++++-
 ports/linux/guts/is_selinux_enabled.c     | 24 +++++++++++
 ports/linux/guts/is_selinux_mls_enabled.c | 16 ++++++++
 ports/linux/pseudo_wrappers.c             | 23 +++++++++++
 ports/linux/wrapfuncs.in                  |  2 +
 test/fake-selinux.c                       | 15 +++++++
 test/test-selinux-disabled.c              | 49 +++++++++++++++++++++++
 test/test-selinux-disabled.sh             | 20 +++++++++
 9 files changed, 159 insertions(+), 1 deletion(-)
 create mode 100644 ports/linux/guts/is_selinux_enabled.c
 create mode 100644 ports/linux/guts/is_selinux_mls_enabled.c
 create mode 100644 test/fake-selinux.c
 create mode 100644 test/test-selinux-disabled.c
 create mode 100755 test/test-selinux-disabled.sh
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index bc4cbe8..79c0328 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,3 +17,4 @@  func_deps.mk
 port_deps.mk
 test/test-*
 !test/test-*.*
+test/*.so
diff --git a/Makefile.in b/Makefile.in
index 4c873d6..38ec23f 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -84,6 +84,14 @@  test-verbose: all $(TESTS) | $(BIN) $(LIB)
 test/test-%: test/test-%.c
 	$(CC) $(CFLAGS) $(CFLAGS_PSEUDO) -o $@ $<
 
+# test-selinux-disabled loads libselinux, or a stand-in reporting SELinux as
+# enabled, at run time.
+test/libfake-selinux.so: test/fake-selinux.c
+	$(CC) $(CFLAGS) $(CFLAGS_PSEUDO) -shared -o $@ $<
+
+test/test-selinux-disabled: test/test-selinux-disabled.c test/libfake-selinux.so
+	$(CC) $(CFLAGS) $(CFLAGS_PSEUDO) -o $@ $< -ldl
+
 install-lib: $(LIBPSEUDO)
 	mkdir -p $(DESTDIR)$(LIBDIR)
 	cp $(LIBPSEUDO) $(DESTDIR)$(LIBDIR)
@@ -176,7 +184,7 @@  pseudo_profile: Makefile pseudo_profile.c tables wrappers
 
 clean:
 	rm -f *.o $(LIBPSEUDO) $(PSEUDO) $(PSEUDODB) $(PSEUDOLOG) \
-		$(TESTS) \
+		$(TESTS) test/libfake-selinux.so \
 		pseudo_wrapfuncs.h pseudo_wrapfuncs.c \
 		pseudo_wrapper_table.c \
 		pseudo_tables.c pseudo_tables.h \
diff --git a/ports/linux/guts/is_selinux_enabled.c b/ports/linux/guts/is_selinux_enabled.c
new file mode 100644
index 0000000..de96da2
--- /dev/null
+++ b/ports/linux/guts/is_selinux_enabled.c
@@ -0,0 +1,24 @@ 
+/*
+ * Copyright (c) 2026 Yocto Project
+ * guts/COPYRIGHT for information.
+ *
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
+ * int is_selinux_enabled(void)
+ *	int rc = -1;
+ */
+
+	/* SELinux-aware programs label the files they create or install
+	 * using the host's policy.  pseudo only records the label, which is
+	 * wrong for target files and leaks the host policy into the build,
+	 * and programs which then hand it back to the kernel, e.g. through
+	 * /proc/self/attr/fscreate, can be refused (YOCTO #6580).  So report
+	 * SELinux as disabled, as on a host without it.  Labels set
+	 * explicitly, e.g. by setfiles, are still recorded.  The host's
+	 * answer is only given while pseudo is disabled.
+	 */
+	rc = 0;
+
+/*	return rc;
+ * }
+ */
diff --git a/ports/linux/guts/is_selinux_mls_enabled.c b/ports/linux/guts/is_selinux_mls_enabled.c
new file mode 100644
index 0000000..fff934f
--- /dev/null
+++ b/ports/linux/guts/is_selinux_mls_enabled.c
@@ -0,0 +1,16 @@ 
+/*
+ * Copyright (c) 2026 Yocto Project
+ * guts/COPYRIGHT for information.
+ *
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
+ * int is_selinux_mls_enabled(void)
+ *	int rc = -1;
+ */
+
+	/* see is_selinux_enabled() */
+	rc = 0;
+
+/*	return rc;
+ * }
+ */
diff --git a/ports/linux/pseudo_wrappers.c b/ports/linux/pseudo_wrappers.c
index bba1577..ebf73b3 100644
--- a/ports/linux/pseudo_wrappers.c
+++ b/ports/linux/pseudo_wrappers.c
@@ -47,6 +47,29 @@  pseudo_mknodat(int dirfd, const char *path, mode_t mode, dev_t dev) {
 	return real___xmknodat(_MKNOD_VER, dirfd, path, mode, &dev);
 }
 
+/* The host's is_selinux_enabled() and is_selinux_mls_enabled(), used only
+ * while pseudo is disabled.  They are in libselinux, which may not be loaded
+ * when the wrappers are set up, or at all, so look them up when they are
+ * needed.  Without libselinux, SELinux isn't in use.
+ */
+int
+pseudo_is_selinux_enabled(void) {
+	static int (*f)(void) = NULL;
+
+	if (!f)
+		f = (int (*)(void)) dlsym(RTLD_NEXT, "is_selinux_enabled");
+	return f ? f() : 0;
+}
+
+int
+pseudo_is_selinux_mls_enabled(void) {
+	static int (*f)(void) = NULL;
+
+	if (!f)
+		f = (int (*)(void)) dlsym(RTLD_NEXT, "is_selinux_mls_enabled");
+	return f ? f() : 0;
+}
+
 int pseudo_capset(cap_user_header_t hdrp, const cap_user_data_t datap) {
 	(void)hdrp;
 	(void)datap;
diff --git a/ports/linux/wrapfuncs.in b/ports/linux/wrapfuncs.in
index dbbf2f7..9f1e013 100644
--- a/ports/linux/wrapfuncs.in
+++ b/ports/linux/wrapfuncs.in
@@ -14,6 +14,8 @@  int open_tree(int dirfd, const char *path, unsigned int flags); /* preserve_path
 int open_tree_attr(int dirfd, const char *path, unsigned int flags, struct mount_attr *attr, size_t size); /* preserve_paths=1, noignore_path=1*/
 int name_to_handle_at(int dirfd, const char *name, struct file_handle *handle, int *mount_id, int flags);
 int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags);
+int is_selinux_enabled(void); /* real_func=pseudo_is_selinux_enabled */
+int is_selinux_mls_enabled(void); /* real_func=pseudo_is_selinux_mls_enabled */
 int mknod(const char *path, mode_t mode, dev_t dev); /* real_func=pseudo_mknod, path_lock=1 */
 int mknodat(int dirfd, const char *path, mode_t mode, dev_t dev); /* real_func=pseudo_mknodat, path_lock=1 */
 int __xmknod(int ver, const char *path, mode_t mode, dev_t *dev); /* flags=AT_SYMLINK_NOFOLLOW, path_lock=1 */
diff --git a/test/fake-selinux.c b/test/fake-selinux.c
new file mode 100644
index 0000000..8f3253d
--- /dev/null
+++ b/test/fake-selinux.c
@@ -0,0 +1,15 @@ 
+/*
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
+ * A stand-in for libselinux which reports SELinux as enabled, so that
+ * test-selinux-disabled can emulate a host where it is.
+ */
+int
+is_selinux_enabled(void) {
+	return 1;
+}
+
+int
+is_selinux_mls_enabled(void) {
+	return 1;
+}
diff --git a/test/test-selinux-disabled.c b/test/test-selinux-disabled.c
new file mode 100644
index 0000000..b8486ca
--- /dev/null
+++ b/test/test-selinux-disabled.c
@@ -0,0 +1,49 @@ 
+/*
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
+ * Under pseudo, SELinux-aware programs are told SELinux is disabled
+ * (YOCTO #6580), and only get the host's answer while pseudo is disabled.
+ *
+ * Usage: test-selinux-disabled <libselinux> <expected>|print
+ *
+ * Loads <libselinux> the way a program using it would, then calls
+ * is_selinux_enabled() and is_selinux_mls_enabled() through the normal
+ * symbol lookup, so pseudo's wrappers are used when pseudo is loaded.  The
+ * answers are compared with <expected>, given as "enabled,mls", or printed.
+ * Returns 77 if <libselinux> can't be loaded.
+ */
+#define _GNU_SOURCE
+#include <dlfcn.h>
+#include <stdio.h>
+#include <string.h>
+
+int
+main(int argc, char *argv[]) {
+	int (*enabled)(void), (*mls)(void);
+	char result[32];
+
+	if (argc != 3) {
+		fprintf(stderr, "usage: %s <libselinux> <expected>|print\n", argv[0]);
+		return 2;
+	}
+	if (!dlopen(argv[1], RTLD_NOW | RTLD_GLOBAL)) {
+		printf("can't load %s, skipping\n", argv[1]);
+		return 77;
+	}
+	enabled = (int (*)(void)) dlsym(RTLD_DEFAULT, "is_selinux_enabled");
+	mls = (int (*)(void)) dlsym(RTLD_DEFAULT, "is_selinux_mls_enabled");
+	if (!enabled || !mls) {
+		printf("%s doesn't provide is_selinux_enabled()\n", argv[1]);
+		return 1;
+	}
+	snprintf(result, sizeof(result), "%d,%d", enabled(), mls());
+	if (!strcmp(argv[2], "print")) {
+		printf("%s\n", result);
+		return 0;
+	}
+	if (strcmp(result, argv[2])) {
+		printf("%s: got %s, expected %s\n", argv[1], result, argv[2]);
+		return 1;
+	}
+	return 0;
+}
diff --git a/test/test-selinux-disabled.sh b/test/test-selinux-disabled.sh
new file mode 100755
index 0000000..fdace34
--- /dev/null
+++ b/test/test-selinux-disabled.sh
@@ -0,0 +1,20 @@ 
+#!/bin/sh
+#
+# SPDX-License-Identifier: LGPL-2.1-only
+#
+# SELinux is reported as disabled under pseudo, and the host's answer is
+# given while PSEUDO_DISABLED is set.  Skipped without libselinux.
+
+t=./test/test-selinux-disabled
+lib=libselinux.so.1
+
+# The host's libselinux: pseudo reports SELinux as disabled, and with
+# PSEUDO_DISABLED gives the same answer as without pseudo at all.
+$t $lib 0,0
+case $? in 0) ;; 77) exit 255 ;; *) exit 1 ;; esac
+host=$(PSEUDO_UNLOAD=1 $t $lib print) || exit 1
+PSEUDO_DISABLED=1 $t $lib "$host" || exit 1
+
+# Emulate a host with SELinux enabled, whatever this one does.
+$t ./test/libfake-selinux.so 0,0 || exit 1
+PSEUDO_DISABLED=1 $t ./test/libfake-selinux.so 1,1 || exit 1