diff mbox series

[error-report-web,1/3] Apply common_context through TEMPLATES.

Message ID 20261018015326.73748-3-tim.orling@konsulko.com
State New
Headers show
Series Minor fixes; drop broken account pages | expand

Commit Message

Tim Orling Oct. 18, 2026, 1:50 a.m. UTC 
TEMPLATE_CONTEXT_PROCESSORS has been ignored since Django 1.10, so
common_context never ran and the SPECIAL_SUBMITTER tab never showed.

AI-Generated: Claude Opus 5.5
Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 Post/test.py               | 11 +++++++++++
 project/settings.py        |  7 +------
 project/settings.py.docker |  7 +------
 3 files changed, 13 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/Post/test.py b/Post/test.py
index 2a98bfc..d33cf97 100755
--- a/Post/test.py
+++ b/Post/test.py
@@ -400,6 +400,17 @@  class PaginationTest(TestCase):
             self.assertEqual(response.status_code, 200)
 
 
+@override_settings(ALLOWED_HOSTS=["testhost"])
+class SpecialSubmitterTest(TestCase):
+    def test_tab_shown_only_when_configured(self):
+        client = Client(HTTP_HOST="testhost")
+        self.assertNotContains(client.get("/Errors/Latest/"), "Latest Autobuilder errors")
+        with self.settings(SPECIAL_SUBMITTER={"name": "yocto-autobuilder",
+                                              "title": "Autobuilder",
+                                              "link": "Autobuilder"}):
+            self.assertContains(client.get("/Errors/Latest/"), "Latest Autobuilder errors")
+
+
 @patch("Post.management.commands.culldb.time.sleep")
 class CullDbTest(TestCase):
     def setUp(self):
diff --git a/project/settings.py b/project/settings.py
index bc63c49..529086b 100644
--- a/project/settings.py
+++ b/project/settings.py
@@ -159,6 +159,7 @@  TEMPLATES = [
                 'django.template.context_processors.request',
                 'django.contrib.auth.context_processors.auth',
                 'django.contrib.messages.context_processors.messages',
+                'Post.views.common_context',
             ],
        },
     },
@@ -208,12 +209,6 @@  LOGGING = {
     }
 }
 
-TEMPLATE_CONTEXT_PROCESSORS = (
-  'django.contrib.auth.context_processors.auth',
-  'django.core.context_processors.request',
-  'Post.views.common_context',
-)
-
 BUGZILLA_URL = 'https://bugzilla.yoctoproject.org'
 
 ACCOUNT_ACTIVATION_DAYS = 2
diff --git a/project/settings.py.docker b/project/settings.py.docker
index 680b485..b98006e 100644
--- a/project/settings.py.docker
+++ b/project/settings.py.docker
@@ -153,6 +153,7 @@  TEMPLATES = [
                 'django.template.context_processors.request',
                 'django.contrib.auth.context_processors.auth',
                 'django.contrib.messages.context_processors.messages',
+                'Post.views.common_context',
             ],
        },
     },
@@ -202,12 +203,6 @@  LOGGING = {
     }
 }
 
-TEMPLATE_CONTEXT_PROCESSORS = (
-  'django.contrib.auth.context_processors.auth',
-  'django.core.context_processors.request',
-  'Post.views.common_context',
-)
-
 BUGZILLA_URL = 'https://bugzilla.yoctoproject.org'
 
 ACCOUNT_ACTIVATION_DAYS = 2