| Message ID | 20260717183507.3539287-2-twoerner@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/unit/test_ksparser_parse: parse the .wks file, fix a diskid crash | expand |
diff --git a/src/wic/ksparser.py b/src/wic/ksparser.py index dcf26f788083..a1276af8d3c6 100644 --- a/src/wic/ksparser.py +++ b/src/wic/ksparser.py @@ -322,9 +322,9 @@ class KickStart(): try: self.bootloader.diskid = int(parsed.diskid, 0) except ValueError: - err = "with --ptbale msdos only 32bit integers " \ + err = "with --ptable msdos only 32bit integers " \ "are allowed for --diskid. %s could not " \ - "be parsed" % self.ptable + "be parsed" % parsed.diskid raise KickStartError(err) else: try:
When a bootloader line sets --ptable msdos with a --diskid that is not a 32-bit integer, the error path builds its message with "... % self.ptable". self is the KickStart instance, which has no ptable attribute, so the interpolation raises AttributeError before the intended KickStartError is raised. Instead of a described error naming the bad value, the user sees an opaque traceback. Interpolate the offending value (parsed.diskid) into the message, matching the gpt branch just below, so a bad msdos --diskid raises a KickStartError that names it. Fix the "--ptbale" typo in the same message while here. AI-Generated: codex/claude-opus 4.8 (xhigh) Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- src/wic/ksparser.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)