| Message ID | 20260106070544.3668128-1-quic_jaihindy@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-selinux,PATCH/V1] systemd: remove creation of backlight directory during build | expand |
Gentle Reminder !! can someone please review the pattch.
On 1/6/26 15:05, quic_jaihindy via lists.yoctoproject.org wrote: > From: Jaihind Yadav <quic_jaihindy@quicinc.com> > > The recipe previously created ${localstatedir}/lib/systemd/backlight at > build time when PACKAGECONFIG included 'backlight'.I Tested it on myboard > and can see directory is correctly labeled by SELinux at runtime and the backlight > service starts successfully without this step. Removing it simplifies > the install process. > > Example SELinux labeling: > ls -laZ /var/lib/systemd/ > drwxr-xr-x. 2 root root system_u:object_r:systemd_backlight_var_lib_t:s0 backlight > > Reference: > Previous discussion and initial change: > https://docs.yoctoproject.org/pipermail/yocto/2018-April/040854.html > > Signed-off-by: Jaihind Yadav <quic_jaihindy@quicinc.com> > --- > recipes-core/systemd/systemd_selinux.inc | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/recipes-core/systemd/systemd_selinux.inc b/recipes-core/systemd/systemd_selinux.inc > index 7d466ee..35411b2 100644 > --- a/recipes-core/systemd/systemd_selinux.inc > +++ b/recipes-core/systemd/systemd_selinux.inc > @@ -1,7 +1 @@ > inherit enable-selinux enable-audit I think we can move the line above to systemd_%.bbappend, like this: inherit ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'enable-selinux enable-audit', '', d)} Then we can drop systemd_selinux.inc file. //Yi > - > -do_install:append() { > - if ${@bb.utils.contains('PACKAGECONFIG', 'backlight', 'true', 'false', d)}; then > - install -d ${D}${localstatedir}/lib/systemd/backlight > - fi > -} > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#2901): https://lists.yoctoproject.org/g/yocto-patches/message/2901 > Mute This Topic: https://lists.yoctoproject.org/mt/117101833/7283133 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13170635/7283133/1683771902/xyzzy [yi.zhao@eng.windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Sat, Jan 10, 2026 at 08:11 PM, Yi Zhao wrote: > > > > Hi Yi Zhao, > > > > Thank you for your suggestion. I have incorporated the changes as per your > recommendation in the patch: > *[meta-selinux,PATCH/V2] systemd: remove creation of backlight directory > during build ( https://lists.yoctoproject.org/g/yocto-patches/message/2942 > ).* > > > > Could you please review it . > > > > Thanks & Regards, > Jaihind Yadav > > >
diff --git a/recipes-core/systemd/systemd_selinux.inc b/recipes-core/systemd/systemd_selinux.inc index 7d466ee..35411b2 100644 --- a/recipes-core/systemd/systemd_selinux.inc +++ b/recipes-core/systemd/systemd_selinux.inc @@ -1,7 +1 @@ inherit enable-selinux enable-audit - -do_install:append() { - if ${@bb.utils.contains('PACKAGECONFIG', 'backlight', 'true', 'false', d)}; then - install -d ${D}${localstatedir}/lib/systemd/backlight - fi -}