| Message ID | 20251208223609.378679-1-t.f.g.geelen@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [auh,1/2] testimage: update package installation logic to use groups | expand |
Thanks, applied and pushed. Alex On Mon, 8 Dec 2025 at 23:36, Tom Geelen <t.f.g.geelen@gmail.com> wrote: > > Incorrect variable pkgs_ctx was passed to _get_pkgs_to_install. It’s undefined in testimage(). > _get_pkgs_to_install iterates groups of upgrade results and extracts PN and PTEST_ENABLED from per-recipe context via bitbake -e. Passing the wrong or undefined variable prevents building an image with the upgraded packages and their -ptest addons. > > Signed-off-by: Tom Geelen <t.f.g.geelen@gmail.com> > --- > modules/testimage.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/modules/testimage.py b/modules/testimage.py > index 6377368..849a9f1 100644 > --- a/modules/testimage.py > +++ b/modules/testimage.py > @@ -74,7 +74,7 @@ class TestImage(): > > def testimage(self, groups, machine, image): > os.environ['CORE_IMAGE_EXTRA_INSTALL'] = \ > - self._get_pkgs_to_install(pkgs_ctx) > + self._get_pkgs_to_install(groups) > os.environ['TEST_LOG_DIR'] = self.logdir > os.environ['TESTIMAGE_UPDATE_VARS'] = 'TEST_LOG_DIR' > I( " Installing additional packages to the image: {}".format(os.environ['CORE_IMAGE_EXTRA_INSTALL'])) > -- > 2.43.0 >
diff --git a/modules/testimage.py b/modules/testimage.py index 6377368..849a9f1 100644 --- a/modules/testimage.py +++ b/modules/testimage.py @@ -74,7 +74,7 @@ class TestImage(): def testimage(self, groups, machine, image): os.environ['CORE_IMAGE_EXTRA_INSTALL'] = \ - self._get_pkgs_to_install(pkgs_ctx) + self._get_pkgs_to_install(groups) os.environ['TEST_LOG_DIR'] = self.logdir os.environ['TESTIMAGE_UPDATE_VARS'] = 'TEST_LOG_DIR' I( " Installing additional packages to the image: {}".format(os.environ['CORE_IMAGE_EXTRA_INSTALL']))
Incorrect variable pkgs_ctx was passed to _get_pkgs_to_install. It’s undefined in testimage(). _get_pkgs_to_install iterates groups of upgrade results and extracts PN and PTEST_ENABLED from per-recipe context via bitbake -e. Passing the wrong or undefined variable prevents building an image with the upgraded packages and their -ptest addons. Signed-off-by: Tom Geelen <t.f.g.geelen@gmail.com> --- modules/testimage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)