| Message ID | 20250904194529.22656-2-twoerner@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip,1/2] nanopi-r4s: remove 2nd eth work-around | expand |
Hi Trevor, On 9/4/25 9:45 PM, Trevor Woerner via lists.yoctoproject.org wrote: > Since the Realtek RTL8169 is part of this board, enable it unconditionally in The FriendlyElec wiki and product page doesn't mention this part number, weird (but armbian and openwrt forums do). FYI, it seems the default value when using "defconfig" defconfig from upstream is R8169 driver built as a module, so you could simply install the kernel module instead of marking it as Y. (But then you hit some corner cases when you want to use NFS for rootfs for example). While many devices supported by this driver seem to require (?) a firmware, the R8169 seemingly doesn't seem to require one, so I guess this is fine :) > the kernel. > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> Acked-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On Fri 2025-09-05 @ 11:10:45 AM, Quentin Schulz via lists.yoctoproject.org wrote: > Hi Trevor, > > On 9/4/25 9:45 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > Since the Realtek RTL8169 is part of this board, enable it unconditionally in > > The FriendlyElec wiki and product page doesn't mention this part number, > weird (but armbian and openwrt forums do). ...and so does the output of lspci. > FYI, it seems the default value when using "defconfig" defconfig from > upstream is R8169 driver built as a module, so you could simply install the > kernel module instead of marking it as Y. (But then you hit some corner > cases when you want to use NFS for rootfs for example). Exactly. If it is a device that is built into the board, I think it should be built into the kernel rather than a module. I didn't provide this in the commit message, but while testing with it enabled as a module, it is the driver that is installed automatically by the system, that's how/why I chose this driver to convert to =y. > While many devices supported by this driver seem to require (?) a firmware, > the R8169 seemingly doesn't seem to require one, so I guess this is fine :) > > > the kernel. > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > Acked-by: Quentin Schulz <quentin.schulz@cherry.de> > > Thanks! > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#2138): https://lists.yoctoproject.org/g/yocto-patches/message/2138 > Mute This Topic: https://lists.yoctoproject.org/mt/115070708/900817 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Thu 2025-09-04 @ 03:45:29 PM, Trevor Woerner wrote: > Since the Realtek RTL8169 is part of this board, enable it unconditionally in > the kernel. > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > --- > recipes-kernel/linux/linux-yocto/realtek-r8169.cfg | 1 + > recipes-kernel/linux/linux-yocto_%.bbappend | 1 + > 2 files changed, 2 insertions(+) > create mode 100644 recipes-kernel/linux/linux-yocto/realtek-r8169.cfg Applied to meta-rockchip, master branch.
diff --git a/recipes-kernel/linux/linux-yocto/realtek-r8169.cfg b/recipes-kernel/linux/linux-yocto/realtek-r8169.cfg new file mode 100644 index 000000000000..811d42a79bf3 --- /dev/null +++ b/recipes-kernel/linux/linux-yocto/realtek-r8169.cfg @@ -0,0 +1 @@ +CONFIG_R8169=y diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend b/recipes-kernel/linux/linux-yocto_%.bbappend index 5d68c7d56e2b..da1b172294e7 100644 --- a/recipes-kernel/linux/linux-yocto_%.bbappend +++ b/recipes-kernel/linux/linux-yocto_%.bbappend @@ -31,3 +31,4 @@ COMPATIBLE_MACHINE:rock64 = "rock64" COMPATIBLE_MACHINE:soquartz = "soquartz" SRC_URI:append:rockchip = " file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta" +SRC_URI:append:nanopi-r4s = " file://realtek-r8169.cfg"
Since the Realtek RTL8169 is part of this board, enable it unconditionally in the kernel. Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- recipes-kernel/linux/linux-yocto/realtek-r8169.cfg | 1 + recipes-kernel/linux/linux-yocto_%.bbappend | 1 + 2 files changed, 2 insertions(+) create mode 100644 recipes-kernel/linux/linux-yocto/realtek-r8169.cfg