@@ -457,17 +457,11 @@ def builderNamesFromConfigFull(props):
return builders
-# Upstream Triggerable class will rasise NotImplementedError() which will mean triggers abort upon reconfig
-# Hack to intercept and ignore this, we'd rather they just survive in our case.
-class ourTriggerable(sched.Triggerable):
- def reconfigService(self, name=None, *args, **kwargs):
- return
-
# nightly builder triggers various other builders
-wait_quick = ourTriggerable(name="wait-quick",
+wait_quick = sched.Triggerable(name="wait-quick",
builderNames=builderNamesFromConfigQuick)
schedulers.append(wait_quick)
-wait_full = ourTriggerable(name="wait-full",
+wait_full = sched.Triggerable(name="wait-full",
builderNames=builderNamesFromConfigFull)
schedulers.append(wait_full)
https://github.com/buildbot/buildbot/commit/c8393c1b0df442d7603fb2212c11a50d163bfdc5 eliminates the need for ourTriggerable reconfigure safe class. Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org> --- schedulers.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)