diff mbox series

[psplash,1/2] configure.ac: standardize default-enabled options

Message ID 20250512160500.244466-2-florent.allard@savoirfairelinux.com
State New
Headers show
Series Fixing autoconf options handling | expand

Commit Message

Florent Allard May 12, 2025, 4:04 p.m. UTC
This commit makes the features progress-bar and startup-msg enabled by
default, and enabled when respectively `--enable-progress-bar` or
`--enable-startup-msg` is passed.

To do so, the default variable name `enable_feature` is used, as well as
the default variable values `yes` and `no`.

This is linked to this issue on buildroot
https://gitlab.com/buildroot.org/buildroot/-/issues/112

The documentation for this feature of autoconf is available here:
https://autotools.info/autoconf/arguments.html

Signed-off-by: Florent Allard <florent.allard@savoirfairelinux.com>
---
 configure.ac | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 2a7da91..4543d1d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,17 +31,17 @@  AC_SUBST([FONT_NAME])
 
 AC_ARG_ENABLE([startup-msg],
     AS_HELP_STRING([--disable-startup-msg], [Disable text banner output on startup]),
-    [disable_startup_msg=true],
-    [disable_startup_msg=false])
-AS_IF([test x$disable_startup_msg = xtrue], [
+    [enable_startup_msg=$enableval],
+    [enable_startup_msg=yes])
+AS_IF([test "x$enable_startup_msg" = "xno"], [
     EXTRA_GCC_FLAGS="$EXTRA_GCC_FLAGS -DPSPLASH_DISABLE_STARTUP_MSG"
 ])
 
 AC_ARG_ENABLE([progress-bar],
     AS_HELP_STRING([--disable-progress-bar], [Disable progress bar]),
-    [disable_progress_bar=true],
-    [disable_progress_bar=false])
-AS_IF([test x$disable_progress_bar = xtrue], [
+    [enable_progress_bar=$enableval],
+    [enable_progress_bar=yes])
+AS_IF([test "x$enable_progress_bar" = "xno"], [
     EXTRA_GCC_FLAGS="$EXTRA_GCC_FLAGS -DPSPLASH_DISABLE_PROGRESS_BAR"
 ])