diff mbox series

[error-report-web] views.py: fix test failure

Message ID 20250506110604.1596570-1-changqing.li@windriver.com
State New
Headers show
Series [error-report-web] views.py: fix test failure | expand

Commit Message

Changqing Li May 6, 2025, 11:06 a.m. UTC 
From: Changqing Li <changqing.li@windriver.com>

Fix following failure:
$python -Wa manage.py test
...
File "/path/to/error-report-web/Post/views.py", line 55, in addData
    version = re.search(r"send-error-report/(\d+\.\d+)", user_agent).group(1)
AttributeError: 'NoneType' object has no attribute 'group'

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 Post/views.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/Post/views.py b/Post/views.py
index f4e16df..c294afd 100644
--- a/Post/views.py
+++ b/Post/views.py
@@ -52,9 +52,13 @@  def addData(request, return_json=False):
     if request.method == 'POST':
         user_agent = request.META.get("HTTP_USER_AGENT", "")
 
-        version = re.search(r"send-error-report/(\d+\.\d+)", user_agent).group(1)
-        version_parts = [int(part) for part in version.split('.')]
-        if version_parts >= [0, 3]:
+        version = None
+        version_parts = None
+        m = re.search(r"send-error-report/(\d+\.\d+)", user_agent)
+        if m:
+            version = m.group(1)
+            version_parts = [int(part) for part in version.split('.')]
+        if version_parts and version_parts >= [0, 3]:
             data = request.body
         else:
             # Backward compatibility with send-error-report < 0.3