diff mbox series

[meta-cgl] ocfs2-tools: Add missing readline dependency

Message ID 20241118153117.307424-1-ryosuke.saito@linaro.org
State New
Headers show
Series [meta-cgl] ocfs2-tools: Add missing readline dependency | expand

Commit Message

Ryosuke Saito Nov. 18, 2024, 3:31 p.m. UTC
This patch fixes a build error during the ./configure phase:

| checking for readline in -lreadline... no
| configure: error: Unable to find readline library

Adds readline to DEPENDS to resolve the issue, enabling proper linking
during the build process.

Signed-off-by: Ryosuke Saito <ryosuke.saito@linaro.org>
---
 meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Nov. 18, 2024, 7:14 p.m. UTC | #1
On Mon, Nov 18, 2024 at 7:31 AM Ryosuke Saito via lists.yoctoproject.org
<ryosuke.saito=linaro.org@lists.yoctoproject.org> wrote:

> This patch fixes a build error during the ./configure phase:
>
> | checking for readline in -lreadline... no
> | configure: error: Unable to find readline library
>
> Adds readline to DEPENDS to resolve the issue, enabling proper linking
> during the build process.
>
> Signed-off-by: Ryosuke Saito <ryosuke.saito@linaro.org>
> ---
>  meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> index 28b82c2cda94..69daff031a04 100644
> --- a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> +++ b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> @@ -31,7 +31,7 @@ inherit autotools-brokensep pkgconfig systemd
>
>  DEPENDS = "corosync pacemaker \
>      libxml2 linux-libc-headers libaio \
> -    e2fsprogs e2fsprogs-native \
> +    e2fsprogs e2fsprogs-native readline \
>  "


Is there a configure knob to enable/disable it ? If so that might be used
via a packageconfig

>
>
>
> --
> 2.47.0
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#819):
> https://lists.yoctoproject.org/g/yocto-patches/message/819
> Mute This Topic: https://lists.yoctoproject.org/mt/109646026/1997914
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe:
> https://lists.yoctoproject.org/g/yocto-patches/leave/13340786/1997914/645821814/xyzzy
> [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
Ryosuke Saito Nov. 19, 2024, 3:08 a.m. UTC | #2
On Tue, 19 Nov 2024 00:44:54 +0530
"Khem Raj via lists.yoctoproject.org" <raj.khem=gmail.com@lists.yoctoproject.org> wrote:

Hi Khem,

> On Mon, Nov 18, 2024 at 7:31 AM Ryosuke Saito via lists.yoctoproject.org
> <ryosuke.saito=linaro.org@lists.yoctoproject.org> wrote:
> 
> > This patch fixes a build error during the ./configure phase:
> >
> > | checking for readline in -lreadline... no
> > | configure: error: Unable to find readline library
> >
> > Adds readline to DEPENDS to resolve the issue, enabling proper linking
> > during the build process.
> >
> > Signed-off-by: Ryosuke Saito <ryosuke.saito@linaro.org>
> > ---
> >  meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> > b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> > index 28b82c2cda94..69daff031a04 100644
> > --- a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> > +++ b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
> > @@ -31,7 +31,7 @@ inherit autotools-brokensep pkgconfig systemd
> >
> >  DEPENDS = "corosync pacemaker \
> >      libxml2 linux-libc-headers libaio \
> > -    e2fsprogs e2fsprogs-native \
> > +    e2fsprogs e2fsprogs-native readline \
> >  "
> 
> 
> Is there a configure knob to enable/disable it ? If so that might be used
> via a packageconfig

I can't see such 'readline' knob in ocfs2 configure script.

Thanks,
Ryosuke
diff mbox series

Patch

diff --git a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
index 28b82c2cda94..69daff031a04 100644
--- a/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
+++ b/meta-cgl-common/recipes-cgl/ocfs2-tools/ocfs2-tools_1.8.6.bb
@@ -31,7 +31,7 @@  inherit autotools-brokensep pkgconfig systemd
 
 DEPENDS = "corosync pacemaker \
     libxml2 linux-libc-headers libaio \
-    e2fsprogs e2fsprogs-native \
+    e2fsprogs e2fsprogs-native readline \
 "