Message ID | 20240626133913.790145-3-gael.portay@rtone.fr |
---|---|
State | New |
Headers | show |
Series | sssd: fix python3 support | expand |
On 6/26/24 9:39 AM, "Gaël PORTAY via lists.yoctoproject.org wrote: > The variable HAVE_PYTHON3 expects a boolean value[1] and the configure > script raises an error if the option --with-python3-bindings is set and > if the value HAVE_PYTHON3 is not "yes"[2]. > > The recipe sets a non-boolean value to ac_cv_prog_HAVE_PYTHON3 and thus > causes the task do_configure to fail. Does this apply to master? - armin > > This fixes the value set to ac_cv_prog_HAVE_PYTHON3 by setting it to yes > instead of $(PYTHON_DIR). > > Fixes: > > | checking for python3... (cached) python3.10 > | configure: error: > | The program python3 was not found in search path. > | Please ensure that it is installed and its directory is included in the search > | path. It is required for building python3 bindings. If you do not want to build > | them please use argument --without-python3-bindings when running configure. > | NOTE: The following config.log files may provide further information. > > [1]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L323-L325 > [2]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L353-L377 > > Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr> > --- > recipes-security/sssd/sssd_2.5.2.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb > index fe82452..98a4b5e 100644 > --- a/recipes-security/sssd/sssd_2.5.2.bb > +++ b/recipes-security/sssd/sssd_2.5.2.bb > @@ -41,7 +41,7 @@ SSSD_UID ?= "root" > SSSD_GID ?= "root" > > CACHED_CONFIGUREVARS = "ac_cv_member_struct_ldap_conncb_lc_arg=no \ > - ac_cv_prog_HAVE_PYTHON3=${PYTHON_DIR} \ > + ac_cv_prog_HAVE_PYTHON3=yes \ > " > > PACKAGECONFIG ?="nss nscd autofs sudo infopipe"
Hello, On Mon Jul 1, 2024 at 1:12 PM CEST, Armin Kuster via lists.yoctoproject.org wrote: > > > On 6/26/24 9:39 AM, "Gaël PORTAY via lists.yoctoproject.org wrote: > > The variable HAVE_PYTHON3 expects a boolean value[1] and the configure > > script raises an error if the option --with-python3-bindings is set and > > if the value HAVE_PYTHON3 is not "yes"[2]. > > > > The recipe sets a non-boolean value to ac_cv_prog_HAVE_PYTHON3 and thus > > causes the task do_configure to fail. > > Does this apply to master? > The change does not apply as is because of the context has changed a bit: the line below has been modified since kirkstone. > - armin > > > > This fixes the value set to ac_cv_prog_HAVE_PYTHON3 by setting it to yes > > instead of $(PYTHON_DIR). > > > > Fixes: > > > > | checking for python3... (cached) python3.10 > > | configure: error: > > | The program python3 was not found in search path. > > | Please ensure that it is installed and its directory is included in the search > > | path. It is required for building python3 bindings. If you do not want to build > > | them please use argument --without-python3-bindings when running configure. > > | NOTE: The following config.log files may provide further information. > > > > [1]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L323-L325 > > [2]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L353-L377 > > > > Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr> > > --- > > recipes-security/sssd/sssd_2.5.2.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb > > index fe82452..98a4b5e 100644 > > --- a/recipes-security/sssd/sssd_2.5.2.bb > > +++ b/recipes-security/sssd/sssd_2.5.2.bb > > @@ -41,7 +41,7 @@ SSSD_UID ?= "root" > > SSSD_GID ?= "root" > > > > CACHED_CONFIGUREVARS = "ac_cv_member_struct_ldap_conncb_lc_arg=no \ > > - ac_cv_prog_HAVE_PYTHON3=${PYTHON_DIR} \ > > + ac_cv_prog_HAVE_PYTHON3=yes \ > > " > > > > PACKAGECONFIG ?="nss nscd autofs sudo infopipe" The line is now: PACKAGECONFIG ?="nss autofs sudo infopipe" > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#395): https://lists.yoctoproject.org/g/yocto-patches/message/395 > Mute This Topic: https://lists.yoctoproject.org/mt/106889412/8642966 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13404021/8642966/1905432541/xyzzy [gael.portay+yocto@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- Regards, Gaël Here is the change (untested): ----- >8 --------------------------------------------------------------- .../networking-layer/recipes-security/sssd/sssd_2.9.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb b/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb index 058d80d..2ab72ae 100644 --- a/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb +++ b/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb @@ -38,7 +38,7 @@ SSSD_UID ?= "root" SSSD_GID ?= "root" CACHED_CONFIGUREVARS = "ac_cv_member_struct_ldap_conncb_lc_arg=no \ - ac_cv_prog_HAVE_PYTHON3=${PYTHON_DIR} \ + ac_cv_prog_HAVE_PYTHON3=yes \ " PACKAGECONFIG ?="nss autofs sudo infopipe"
diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb index fe82452..98a4b5e 100644 --- a/recipes-security/sssd/sssd_2.5.2.bb +++ b/recipes-security/sssd/sssd_2.5.2.bb @@ -41,7 +41,7 @@ SSSD_UID ?= "root" SSSD_GID ?= "root" CACHED_CONFIGUREVARS = "ac_cv_member_struct_ldap_conncb_lc_arg=no \ - ac_cv_prog_HAVE_PYTHON3=${PYTHON_DIR} \ + ac_cv_prog_HAVE_PYTHON3=yes \ " PACKAGECONFIG ?="nss nscd autofs sudo infopipe"
The variable HAVE_PYTHON3 expects a boolean value[1] and the configure script raises an error if the option --with-python3-bindings is set and if the value HAVE_PYTHON3 is not "yes"[2]. The recipe sets a non-boolean value to ac_cv_prog_HAVE_PYTHON3 and thus causes the task do_configure to fail. This fixes the value set to ac_cv_prog_HAVE_PYTHON3 by setting it to yes instead of $(PYTHON_DIR). Fixes: | checking for python3... (cached) python3.10 | configure: error: | The program python3 was not found in search path. | Please ensure that it is installed and its directory is included in the search | path. It is required for building python3 bindings. If you do not want to build | them please use argument --without-python3-bindings when running configure. | NOTE: The following config.log files may provide further information. [1]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L323-L325 [2]: https://github.com/SSSD/sssd/blob/2.5.2/configure.ac#L353-L377 Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr> --- recipes-security/sssd/sssd_2.5.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)