diff mbox series

[meta-security,kirkstone,1/5] sssd: fix missing python3.X-config script

Message ID 20240626133913.790145-2-gael.portay@rtone.fr
State New
Headers show
Series sssd: fix python3 support | expand

Commit Message

Gaël PORTAY June 26, 2024, 1:39 p.m. UTC
The configure script checks for the utility python3.X-config to be in
$PATH; that script is shipped by the package python3-native.

The recipe does not depend on the package python3-native which causes
the task do_configure to fail.

The recipe inherits from the bbclass python3-dir that does not install
the required script to the sysroot. The bbclass python3native inherits
from (the already inherited bbclass) python3-dir and it adds the missing
dependency to python3-native.

This fixes the configure error by "upgrading" the inherit bbclass from
python3-dir to python3-native.

Fixes:

	| checking for python3.10-config... no
	| configure: error:
	| The program python3.10-config was not found in search path.
	| Please ensure that it is installed and its directory is included in the search
	| path. If you want to build sssd without python3 bindings then specify
	| --without-python3-bindings when running configure.
	| NOTE: The following config.log files may provide further information.

Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
---
 recipes-security/sssd/sssd_2.5.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

akuster808 July 1, 2024, 11:14 a.m. UTC | #1
On 6/26/24 9:39 AM, "Gaël PORTAY via lists.yoctoproject.org wrote:
> The configure script checks for the utility python3.X-config to be in
> $PATH; that script is shipped by the package python3-native.
>
> The recipe does not depend on the package python3-native which causes
> the task do_configure to fail.
>
> The recipe inherits from the bbclass python3-dir that does not install
> the required script to the sysroot. The bbclass python3native inherits
> from (the already inherited bbclass) python3-dir and it adds the missing
> dependency to python3-native.\

Does this apply to master?

- armin
>
> This fixes the configure error by "upgrading" the inherit bbclass from
> python3-dir to python3-native.
>
> Fixes:
>
> 	| checking for python3.10-config... no
> 	| configure: error:
> 	| The program python3.10-config was not found in search path.
> 	| Please ensure that it is installed and its directory is included in the search
> 	| path. If you want to build sssd without python3 bindings then specify
> 	| --without-python3-bindings when running configure.
> 	| NOTE: The following config.log files may provide further information.
>
> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
> ---
>   recipes-security/sssd/sssd_2.5.2.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb
> index c07559c..fe82452 100644
> --- a/recipes-security/sssd/sssd_2.5.2.bb
> +++ b/recipes-security/sssd/sssd_2.5.2.bb
> @@ -33,7 +33,7 @@ CVE_CHECK_IGNORE += "\
>       CVE-2018-16838 \
>   "
>   
> -inherit autotools pkgconfig gettext python3-dir features_check systemd
> +inherit autotools pkgconfig gettext python3native features_check systemd
>   
>   REQUIRED_DISTRO_FEATURES = "pam"
>
Gaël PORTAY July 1, 2024, 12:39 p.m. UTC | #2
Hello,

On Mon Jul 1, 2024 at 1:14 PM CEST, akuster808 wrote:
>
>
> On 6/26/24 9:39 AM, "Gaël PORTAY via lists.yoctoproject.org wrote:
> > The configure script checks for the utility python3.X-config to be in
> > $PATH; that script is shipped by the package python3-native.
> >
> > The recipe does not depend on the package python3-native which causes
> > the task do_configure to fail.
> >
> > The recipe inherits from the bbclass python3-dir that does not install
> > the required script to the sysroot. The bbclass python3native inherits
> > from (the already inherited bbclass) python3-dir and it adds the missing
> > dependency to python3-native.\
>
> Does this apply to master?
>

The change does not apply as is because of the context has changed a
bit: the two lines above have been modified since kirkstone.

> - armin
> >
> > This fixes the configure error by "upgrading" the inherit bbclass from
> > python3-dir to python3-native.
> >
> > Fixes:
> >
> > 	| checking for python3.10-config... no
> > 	| configure: error:
> > 	| The program python3.10-config was not found in search path.
> > 	| Please ensure that it is installed and its directory is included in the search
> > 	| path. If you want to build sssd without python3 bindings then specify
> > 	| --without-python3-bindings when running configure.
> > 	| NOTE: The following config.log files may provide further information.
> >
> > Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
> > ---
> >   recipes-security/sssd/sssd_2.5.2.bb | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb
> > index c07559c..fe82452 100644
> > --- a/recipes-security/sssd/sssd_2.5.2.bb
> > +++ b/recipes-security/sssd/sssd_2.5.2.bb
> > @@ -33,7 +33,7 @@ CVE_CHECK_IGNORE += "\
> >       CVE-2018-16838 \

The two lines are now:
 
 UPSTREAM_CHECK_URI = "https://github.com/SSSD/${BPN}/releases"

> >   "
> >   
> > -inherit autotools pkgconfig gettext python3-dir features_check systemd
> > +inherit autotools pkgconfig gettext python3native features_check systemd
> >   
> >   REQUIRED_DISTRO_FEATURES = "pam"
> >   

Regards,
Gaël

Here is the change (untested):

----- >8 ---------------------------------------------------------------

 .../networking-layer/recipes-security/sssd/sssd_2.9.2.bb        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb b/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb
index 0c75d8f..058d80d 100644
--- a/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb
+++ b/dynamic-layers/networking-layer/recipes-security/sssd/sssd_2.9.2.bb
@@ -30,7 +30,7 @@ SRC_URI[sha256sum] = "827bc65d64132410e6dd3df003f04829d60387ec30e72b2d4e22d93bb6

 UPSTREAM_CHECK_URI = "https://github.com/SSSD/${BPN}/releases"

-inherit autotools pkgconfig gettext python3-dir features_check systemd
+inherit autotools pkgconfig gettext python3native features_check systemd

 REQUIRED_DISTRO_FEATURES = "pam"
diff mbox series

Patch

diff --git a/recipes-security/sssd/sssd_2.5.2.bb b/recipes-security/sssd/sssd_2.5.2.bb
index c07559c..fe82452 100644
--- a/recipes-security/sssd/sssd_2.5.2.bb
+++ b/recipes-security/sssd/sssd_2.5.2.bb
@@ -33,7 +33,7 @@  CVE_CHECK_IGNORE += "\
     CVE-2018-16838 \
 "
 
-inherit autotools pkgconfig gettext python3-dir features_check systemd
+inherit autotools pkgconfig gettext python3native features_check systemd
 
 REQUIRED_DISTRO_FEATURES = "pam"