| Message ID | 20240618171619.9303-1-twoerner@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip,v2] linux-torvalds-next: use tag | expand |
Hi Trevor, On 6/18/24 7:16 PM, Trevor Woerner via lists.yoctoproject.org wrote: > Use the tag name specifically; note that it is no longer reachable from any > branch. > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > --- > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > index 9a95eb5bc4d8..1369ba1d707f 100644 > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" > COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" > > LINUX_VERSION = "6.10-rc3" > +KERNEL_VERSION_SANITY_SKIP = "1" > PV = "${LINUX_VERSION}+git${SRCPV}" > SRC_URI = " \ > - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > " > -# this is tag 'next-20240611' > -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On Tue 2024-06-18 @ 01:16:19 PM, Trevor Woerner wrote: > Use the tag name specifically; note that it is no longer reachable from any > branch. > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > --- > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Added to meta-rockchip, master branch. Thanks for the review!
Why is this better? Now bitbake will always run git ls-remote to covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and break parsing this recipe without network access. On Wed, Jun 19, 2024 at 10:59 AM Quentin Schulz via lists.yoctoproject.org <quentin.schulz=cherry.de@lists.yoctoproject.org> wrote: > > Hi Trevor, > > On 6/18/24 7:16 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > Use the tag name specifically; note that it is no longer reachable from any > > branch. > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > --- > > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > > index 9a95eb5bc4d8..1369ba1d707f 100644 > > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb > > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > > @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" > > COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" > > > > LINUX_VERSION = "6.10-rc3" > > +KERNEL_VERSION_SANITY_SKIP = "1" > > PV = "${LINUX_VERSION}+git${SRCPV}" > > SRC_URI = " \ > > - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ > > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > > " > > -# this is tag 'next-20240611' > > -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" > > > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > Thanks! > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#348): https://lists.yoctoproject.org/g/yocto-patches/message/348 > Mute This Topic: https://lists.yoctoproject.org/mt/106745214/3617156 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13388836/3617156/66960823/xyzzy [martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Wed 2024-06-19 @ 01:56:14 PM, Martin Jansa via lists.yoctoproject.org wrote: > Why is this better? Because in a repository like linux-next a957267fa7e9159d3d2ee1421359ebf228570c68 could be rebased out of existence? Although now that makes we wonder what would happen to the tag in this situation. Three days ago this hash was reachable from master, now it is not. That's a lot of churn. > Now bitbake will always run git ls-remote to > covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and > break parsing this recipe without network access. Is that how you're building with meta-rockchip? > On Wed, Jun 19, 2024 at 10:59 AM Quentin Schulz via > lists.yoctoproject.org > <quentin.schulz=cherry.de@lists.yoctoproject.org> wrote: > > > > Hi Trevor, > > > > On 6/18/24 7:16 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > > Use the tag name specifically; note that it is no longer reachable from any > > > branch. > > > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > > --- > > > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > > > index 9a95eb5bc4d8..1369ba1d707f 100644 > > > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb > > > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > > > @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" > > > COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" > > > > > > LINUX_VERSION = "6.10-rc3" > > > +KERNEL_VERSION_SANITY_SKIP = "1" > > > PV = "${LINUX_VERSION}+git${SRCPV}" > > > SRC_URI = " \ > > > - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > > > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ > > > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > > > " > > > -# this is tag 'next-20240611' > > > -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" > > > > > > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > > > Thanks! > > Quentin > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#351): https://lists.yoctoproject.org/g/yocto-patches/message/351 > Mute This Topic: https://lists.yoctoproject.org/mt/106745214/900817 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Wed, Jun 19, 2024 at 2:17 PM Trevor Woerner via lists.yoctoproject.org <twoerner=gmail.com@lists.yoctoproject.org> wrote: > > On Wed 2024-06-19 @ 01:56:14 PM, Martin Jansa via lists.yoctoproject.org wrote: > > Why is this better? > > Because in a repository like linux-next > a957267fa7e9159d3d2ee1421359ebf228570c68 could be rebased out of existence? Really? It shouldn't disappear while the tag is still referencing it and if the tag is deleted than this change won't help you as well after first gc in upstream repo. > Although now that makes we wonder what would happen to the tag in this > situation. > > Three days ago this hash was reachable from master, now it is not. That's a > lot of churn. > > > Now bitbake will always run git ls-remote to > > covert next-20240611 into a957267fa7e9159d3d2ee1421359ebf228570c68 and > > break parsing this recipe without network access. > > Is that how you're building with meta-rockchip? I don't even use meta-rockchip, but I'm a bit allergic to ls-remote while parsing recipes I'm not using (and random build failures caused by that when there is a network glitch or something during re-parsing of the recipes), especially when I notice a change like this which IMHO made it worse. Regards, > > On Wed, Jun 19, 2024 at 10:59 AM Quentin Schulz via > > lists.yoctoproject.org > > <quentin.schulz=cherry.de@lists.yoctoproject.org> wrote: > > > > > > Hi Trevor, > > > > > > On 6/18/24 7:16 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > > > Use the tag name specifically; note that it is no longer reachable from any > > > > branch. > > > > > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > > > --- > > > > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > > > > index 9a95eb5bc4d8..1369ba1d707f 100644 > > > > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb > > > > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > > > > @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" > > > > COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" > > > > > > > > LINUX_VERSION = "6.10-rc3" > > > > +KERNEL_VERSION_SANITY_SKIP = "1" > > > > PV = "${LINUX_VERSION}+git${SRCPV}" > > > > SRC_URI = " \ > > > > - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > > > > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ > > > > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > > > > " > > > > -# this is tag 'next-20240611' > > > > -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" > > > > > > > > > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > > > > > Thanks! > > > Quentin > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#352): https://lists.yoctoproject.org/g/yocto-patches/message/352 > Mute This Topic: https://lists.yoctoproject.org/mt/106745214/3617156 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13388836/3617156/66960823/xyzzy [martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
Why use tags ? they are floating SHA1 and bitbake will need n/w access all the time. On Wed, Jun 19, 2024 at 1:59 AM Quentin Schulz via lists.yoctoproject.org <quentin.schulz=cherry.de@lists.yoctoproject.org> wrote: > > Hi Trevor, > > On 6/18/24 7:16 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > Use the tag name specifically; note that it is no longer reachable from any > > branch. > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > --- > > recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb > > index 9a95eb5bc4d8..1369ba1d707f 100644 > > --- a/recipes-kernel/linux/linux-torvalds-next_git.bb > > +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb > > @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" > > COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" > > > > LINUX_VERSION = "6.10-rc3" > > +KERNEL_VERSION_SANITY_SKIP = "1" > > PV = "${LINUX_VERSION}+git${SRCPV}" > > SRC_URI = " \ > > - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ > > + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ > > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ > > " > > -# this is tag 'next-20240611' > > -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" > > > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > Thanks! > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#348): https://lists.yoctoproject.org/g/yocto-patches/message/348 > Mute This Topic: https://lists.yoctoproject.org/mt/106745214/1997914 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13340786/1997914/645821814/xyzzy [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/recipes-kernel/linux/linux-torvalds-next_git.bb b/recipes-kernel/linux/linux-torvalds-next_git.bb index 9a95eb5bc4d8..1369ba1d707f 100644 --- a/recipes-kernel/linux/linux-torvalds-next_git.bb +++ b/recipes-kernel/linux/linux-torvalds-next_git.bb @@ -10,13 +10,12 @@ COMPATIBLE_MACHINE = "^$" COMPATIBLE_MACHINE:radxa-zero-3 = "radxa-zero-3" LINUX_VERSION = "6.10-rc3" +KERNEL_VERSION_SANITY_SKIP = "1" PV = "${LINUX_VERSION}+git${SRCPV}" SRC_URI = " \ - git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;branch=master \ + git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git;protocol=https;nobranch=1;tag=next-20240611 \ file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta \ " -# this is tag 'next-20240611' -SRCREV = "a957267fa7e9159d3d2ee1421359ebf228570c68" inherit kernel inherit kernel-yocto
Use the tag name specifically; note that it is no longer reachable from any branch. Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- recipes-kernel/linux/linux-torvalds-next_git.bb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)