| Message ID | 20240613133544.21164-1-twoerner@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip,v2,1/2] rockchip-rkbin: bump SRCREV | expand |
Hi Trevor, On 6/13/24 3:35 PM, Trevor Woerner via lists.yoctoproject.org wrote: > Update to a newer release. > > Boot tested on: > - rock-3a > - rock-5a > - rock-5b > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > --- > v2 changes: > - added > - break out the SRCREV bump and make it applicable to all builds/boards > --- > recipes-bsp/rkbin/rockchip-rkbin_git.bb | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > index 7929c6ac3a10..f9724ddd5cd5 100644 > --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb > +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > @@ -3,7 +3,7 @@ LICENSE = "Proprietary" > LIC_FILES_CHKSUM = "file://LICENSE;md5=15faa4a01e7eb0f5d33f9f2bcc7bff62" > > SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" > -SRCREV = "b4558da0860ca48bf1a571dd33ccba580b9abe23" > +SRCREV = "a2a0b89b6c8c612dca5ed9ed8a68db8a07f68bc0" > > PROVIDES += "trusted-firmware-a" > PROVIDES += "optee-os" > @@ -42,7 +42,7 @@ do_deploy:rk3568() { > # Prebuilt OPTEE-OS > install -m 644 ${S}/bin/rk35/rk3568_bl32_v*.bin ${DEPLOYDIR}/tee-rk3568.bin > # Prebuilt U-Boot TPL (DDR init) > - install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.18.bin ${DEPLOYDIR}/ddr-rk3568.bin > + install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3568.bin What about using '*' like the others? e.g. install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v*.bin ${DEPLOYDIR}/ddr-rk3568.bin > } > > do_deploy:rk3588s() { > @@ -51,7 +51,7 @@ do_deploy:rk3588s() { > # Prebuilt OPTEE-OS > install -m 644 ${S}/bin/rk35/rk3588_bl32_v*.bin ${DEPLOYDIR}/tee-rk3588.bin > # Prebuilt U-Boot TPL (DDR init) > - install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2736MHz_v*.bin ${DEPLOYDIR}/ddr-rk3588.bin > + install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.16.bin ${DEPLOYDIR}/ddr-rk3588.bin Same here, maybe we want to keep '*' in there? It'd be nice to put in the commit log that the binary prefix changed in commit https://github.com/rockchip-linux/rkbin/commit/f02d10e468d8c783c45137d230ff33d42ca670b4 where they changed the frequency of LPDDR5 to 2400MHz to "improve stability" as justification in the commit log. Otherwise, looks good to me. Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Tested myself with master U-Boot on RK3588 Jaguar, compiled by hand outside of Yocto. Tested-by: Quentin Schulz <quentin.schulz@cherry.de> #RK3588 Jaguar, manual U-Boot compilation Thanks! Quentin
On Thu 2024-06-13 @ 04:03:31 PM, Quentin Schulz via lists.yoctoproject.org wrote: > Hi Trevor, > > On 6/13/24 3:35 PM, Trevor Woerner via lists.yoctoproject.org wrote: > > Update to a newer release. > > > > Boot tested on: > > - rock-3a > > - rock-5a > > - rock-5b > > > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > > --- > > v2 changes: > > - added > > - break out the SRCREV bump and make it applicable to all builds/boards > > --- > > recipes-bsp/rkbin/rockchip-rkbin_git.bb | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > index 7929c6ac3a10..f9724ddd5cd5 100644 > > --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb > > @@ -3,7 +3,7 @@ LICENSE = "Proprietary" > > LIC_FILES_CHKSUM = "file://LICENSE;md5=15faa4a01e7eb0f5d33f9f2bcc7bff62" > > SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" > > -SRCREV = "b4558da0860ca48bf1a571dd33ccba580b9abe23" > > +SRCREV = "a2a0b89b6c8c612dca5ed9ed8a68db8a07f68bc0" > > PROVIDES += "trusted-firmware-a" > > PROVIDES += "optee-os" > > @@ -42,7 +42,7 @@ do_deploy:rk3568() { > > # Prebuilt OPTEE-OS > > install -m 644 ${S}/bin/rk35/rk3568_bl32_v*.bin ${DEPLOYDIR}/tee-rk3568.bin > > # Prebuilt U-Boot TPL (DDR init) > > - install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.18.bin ${DEPLOYDIR}/ddr-rk3568.bin > > + install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3568.bin > > What about using '*' like the others? e.g. > > install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v*.bin > ${DEPLOYDIR}/ddr-rk3568.bin Wasn't it just yesterday you were advocating strongly *against* using tags for this exact same reason? (i.e. they can move) These components won't change unless we do a SRCREV bump, and if we do a SRCREV bump I'd prefer to see which ones, specifically, change so they can be explicitly tested. > > } > > do_deploy:rk3588s() { > > @@ -51,7 +51,7 @@ do_deploy:rk3588s() { > > # Prebuilt OPTEE-OS > > install -m 644 ${S}/bin/rk35/rk3588_bl32_v*.bin ${DEPLOYDIR}/tee-rk3588.bin > > # Prebuilt U-Boot TPL (DDR init) > > - install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2736MHz_v*.bin ${DEPLOYDIR}/ddr-rk3588.bin > > + install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.16.bin ${DEPLOYDIR}/ddr-rk3588.bin > > Same here, maybe we want to keep '*' in there? > > It'd be nice to put in the commit log that the binary prefix changed in > commit https://github.com/rockchip-linux/rkbin/commit/f02d10e468d8c783c45137d230ff33d42ca670b4 > where they changed the frequency of LPDDR5 to 2400MHz to "improve stability" > as justification in the commit log. Good idea. > Otherwise, looks good to me. > > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> > > Tested myself with master U-Boot on RK3588 Jaguar, compiled by hand outside > of Yocto. > > Tested-by: Quentin Schulz <quentin.schulz@cherry.de> #RK3588 Jaguar, manual > U-Boot compilation > > Thanks! > Quentin > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#320): https://lists.yoctoproject.org/g/yocto-patches/message/320 > Mute This Topic: https://lists.yoctoproject.org/mt/106651708/900817 > Group Owner: yocto-patches+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb index 7929c6ac3a10..f9724ddd5cd5 100644 --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb @@ -3,7 +3,7 @@ LICENSE = "Proprietary" LIC_FILES_CHKSUM = "file://LICENSE;md5=15faa4a01e7eb0f5d33f9f2bcc7bff62" SRC_URI = "git://github.com/rockchip-linux/rkbin;protocol=https;branch=master" -SRCREV = "b4558da0860ca48bf1a571dd33ccba580b9abe23" +SRCREV = "a2a0b89b6c8c612dca5ed9ed8a68db8a07f68bc0" PROVIDES += "trusted-firmware-a" PROVIDES += "optee-os" @@ -42,7 +42,7 @@ do_deploy:rk3568() { # Prebuilt OPTEE-OS install -m 644 ${S}/bin/rk35/rk3568_bl32_v*.bin ${DEPLOYDIR}/tee-rk3568.bin # Prebuilt U-Boot TPL (DDR init) - install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.18.bin ${DEPLOYDIR}/ddr-rk3568.bin + install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3568.bin } do_deploy:rk3588s() { @@ -51,7 +51,7 @@ do_deploy:rk3588s() { # Prebuilt OPTEE-OS install -m 644 ${S}/bin/rk35/rk3588_bl32_v*.bin ${DEPLOYDIR}/tee-rk3588.bin # Prebuilt U-Boot TPL (DDR init) - install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2736MHz_v*.bin ${DEPLOYDIR}/ddr-rk3588.bin + install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.16.bin ${DEPLOYDIR}/ddr-rk3588.bin } do_deploy() {
Update to a newer release. Boot tested on: - rock-3a - rock-5a - rock-5b Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- v2 changes: - added - break out the SRCREV bump and make it applicable to all builds/boards --- recipes-bsp/rkbin/rockchip-rkbin_git.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)