| Message ID | 20240514-rk3588-family-v1-1-5366b1534a10@cherry.de |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip] rk3588/rk3588s: add SOC_FAMILY | expand |
Hi all, Please do not merge this patch. meta/conf/machine/include/soc-family.inc adds SOC_FAMILY to MACHINEOVERRIDES. We obviously do not want rk3588 in OVERRIDES of rk3588s machines otherwise we won't be able to distinguish between the two of them. I suggest to add SOC_FAMILY to rk3588.inc and rk3588s.inc and figure out what we need to do the day we need to do something that uses SOC_FAMILY but should match both tk3588 and rk3588s? Cheers, Quentin On 5/14/24 9:26 AM, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@cherry.de> > > The RK3588S is a stripped down version of the RK3588 but all prebuilt > binaries and most documentation from Rockchip use "RK3588" as an > identifier for both, so let's make this the SOC_FAMILY for both RK3588S > and RK3588. > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > conf/machine/include/rk3588s.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/conf/machine/include/rk3588s.inc b/conf/machine/include/rk3588s.inc > index 878f7a8..b570d46 100644 > --- a/conf/machine/include/rk3588s.inc > +++ b/conf/machine/include/rk3588s.inc > @@ -1,3 +1,5 @@ > +SOC_FAMILY = "rk3588" > + > MACHINEOVERRIDES =. "rk3588s:" > DEFAULTTUNE ?= "cortexa76-cortexa55-crypto" > > > --- > base-commit: 88f2064ca2b83b42a7c8a59616ab80b763ef2485 > change-id: 20240514-rk3588-family-6f322d5f1034 > > Best regards,
diff --git a/conf/machine/include/rk3588s.inc b/conf/machine/include/rk3588s.inc index 878f7a8..b570d46 100644 --- a/conf/machine/include/rk3588s.inc +++ b/conf/machine/include/rk3588s.inc @@ -1,3 +1,5 @@ +SOC_FAMILY = "rk3588" + MACHINEOVERRIDES =. "rk3588s:" DEFAULTTUNE ?= "cortexa76-cortexa55-crypto"