diff mbox series

[meta-selinux] rpm: remove incorrect packageconfig spec

Message ID 20240212201455.3627475-1-alex.stewart@ni.com
State New
Headers show
Series [meta-selinux] rpm: remove incorrect packageconfig spec | expand

Commit Message

Alex Stewart Feb. 12, 2024, 8:14 p.m. UTC
As of recent recipe versions, this layer's bbappend fails rpm-native
recipe configuration, with an error that `--with-selinux` is an invalid
flag.

OE-core's upstream rpm recipe uses cmake flags to enable/disable
features, including selinux support. The upstream recipe already has a
PACKAGECONFIG[selinux] spec which uses the correct cmake terms.

Remove this layer's attempt at using the old flag style.

Signed-off-by: Alex Stewart <alex.stewart@ni.com>
---
 recipes-devtools/rpm/rpm_selinux.inc | 1 -
 1 file changed, 1 deletion(-)

Comments

Alex Stewart Feb. 13, 2024, 6:15 p.m. UTC | #1
Retracted.

I neglected to check the list before posting this and didn't realize 
that Denys D. already had a duplicate patch [1]. My mistake.

[1] https://lists.yoctoproject.org/g/yocto/message/62421

On 2/12/24 15:14, Alex Stewart wrote:
> As of recent recipe versions, this layer's bbappend fails rpm-native
> recipe configuration, with an error that `--with-selinux` is an invalid
> flag.
>
> OE-core's upstream rpm recipe uses cmake flags to enable/disable
> features, including selinux support. The upstream recipe already has a
> PACKAGECONFIG[selinux] spec which uses the correct cmake terms.
>
> Remove this layer's attempt at using the old flag style.
>
> Signed-off-by: Alex Stewart <alex.stewart@ni.com>
> ---
>   recipes-devtools/rpm/rpm_selinux.inc | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/recipes-devtools/rpm/rpm_selinux.inc b/recipes-devtools/rpm/rpm_selinux.inc
> index b6e0e7c..8c11cac 100644
> --- a/recipes-devtools/rpm/rpm_selinux.inc
> +++ b/recipes-devtools/rpm/rpm_selinux.inc
> @@ -1,2 +1 @@
>   inherit enable-selinux
> -PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
diff mbox series

Patch

diff --git a/recipes-devtools/rpm/rpm_selinux.inc b/recipes-devtools/rpm/rpm_selinux.inc
index b6e0e7c..8c11cac 100644
--- a/recipes-devtools/rpm/rpm_selinux.inc
+++ b/recipes-devtools/rpm/rpm_selinux.inc
@@ -1,2 +1 @@ 
 inherit enable-selinux
-PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"