diff mbox series

[ptest-runner,2/2] utils: run_child fix security flags build

Message ID 20240127192338.776610-2-anibal@limonsoftware.com
State New
Headers show
Series [ptest-runner,1/2] utils.c: get_available_ptests fix security flags compilation | expand

Commit Message

Anibal Limon Jan. 27, 2024, 7:23 p.m. UTC 
Move chdir outside run_child to better handle when fails output an error
message plus remove the need to strdup inside run_child (already have
ptest_dir).

Signed-off-by: Anibal Limon <anibal@limonsoftware.com>
---
 utils.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/utils.c b/utils.c
index 54394cc..472520f 100644
--- a/utils.c
+++ b/utils.c
@@ -327,7 +327,6 @@  static inline void
 run_child(char *run_ptest, int fd_stdout, int fd_stderr)
 {
 	char *const argv[2] = {run_ptest, NULL};
-	chdir(dirname(strdup(run_ptest)));
 
 	dup2(fd_stdout, STDOUT_FILENO);
 	// XXX: Redirect stderr to stdout to avoid buffer ordering problems.
@@ -466,7 +465,11 @@  run_ptests(struct ptest_list *head, const struct ptest_options opts,
 					fprintf(fp, "ERROR: Unable to attach to controlling tty, %s\n", strerror(errno));
 				}
 
-				run_child(p->run_ptest, pipefd_stdout[PIPE_WRITE], pipefd_stderr[PIPE_WRITE]);
+				if (chdir(ptest_dir) == -1) {
+					fprintf(fp, "ERROR: Unable to chdir(%s), %s\n", ptest_dir, strerror(errno));
+				} else {
+					run_child(p->run_ptest, pipefd_stdout[PIPE_WRITE], pipefd_stderr[PIPE_WRITE]);
+				}
 
 			} else {
 				bool timedout = false;