| Message ID | 20240114144618.30935-1-twoerner@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip] remove adding all kernel modules by default | expand |
Hi Trevor, On January 14, 2024 3:46:18 PM GMT+01:00, Trevor Woerner <twoerner@gmail.com> wrote: >A BSP layer shouldn't be deciding to include all kernel modules. That's more >of a distro decision, or for local.conf at a minimum. Modules that are >required for the basic functioning of a board are fine, but doing a blanket >"install all" is overreach and inflates images unnecessarily (~45MB, by one >measurement). > It's only a RRECOMMENDS, so I'd say this is fine as is? This allows to have a working system without spending too much time figuring out what's exactly needed. If someone needs to have a smaller image, they can then play with kernel defconfig or kernel-modules- in packages to install. Up to you though :) Cheers, Quentin >I expect patches will probably roll in after this one to add back necessary >modules, but it will be easier to figure out which ones when starting with >having none of them included by default. > >Signed-off-by: Trevor Woerner <twoerner@gmail.com> >--- > conf/machine/include/rock-pi-4.inc | 2 -- > conf/machine/nanopi-m4b.conf | 2 -- > conf/machine/nanopi-r2s.conf | 1 - > conf/machine/nanopi-r4s.conf | 2 -- > conf/machine/rock-5a.conf | 1 - > conf/machine/rock-5b.conf | 1 - > conf/machine/rock-pi-e.conf | 1 - > conf/machine/rock-pi-s.conf | 1 - > 8 files changed, 11 deletions(-) > >diff --git a/conf/machine/include/rock-pi-4.inc b/conf/machine/include/rock-pi-4.inc >index 0a868463bc64..02dfb18fc775 100644 >--- a/conf/machine/include/rock-pi-4.inc >+++ b/conf/machine/include/rock-pi-4.inc >@@ -2,5 +2,3 @@ > MACHINEOVERRIDES =. "rock-pi-4:" > > require conf/machine/include/rk3399.inc >- >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" >diff --git a/conf/machine/nanopi-m4b.conf b/conf/machine/nanopi-m4b.conf >index 35cd8f68e82e..b924b0018867 100644 >--- a/conf/machine/nanopi-m4b.conf >+++ b/conf/machine/nanopi-m4b.conf >@@ -5,7 +5,5 @@ > > require conf/machine/include/rk3399.inc > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" >- > KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-m4b.dtb" > UBOOT_MACHINE = "nanopi-m4b-rk3399_defconfig" >diff --git a/conf/machine/nanopi-r2s.conf b/conf/machine/nanopi-r2s.conf >index 4472c21f0217..0451002ecff5 100644 >--- a/conf/machine/nanopi-r2s.conf >+++ b/conf/machine/nanopi-r2s.conf >@@ -6,6 +6,5 @@ > require conf/machine/include/rk3328.inc > > KERNEL_DEVICETREE = "rockchip/rk3328-nanopi-r2s.dtb" >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > UBOOT_MACHINE = "nanopi-r2s-rk3328_defconfig" >diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf >index 21be4400c89d..161f4b4e4609 100644 >--- a/conf/machine/nanopi-r4s.conf >+++ b/conf/machine/nanopi-r4s.conf >@@ -5,7 +5,5 @@ > > require conf/machine/include/rk3399.inc > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" >- > KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-r4s.dtb" > UBOOT_MACHINE = "nanopi-r4s-rk3399_defconfig" >diff --git a/conf/machine/rock-5a.conf b/conf/machine/rock-5a.conf >index 5ace4dac8fe4..28e06486eda3 100644 >--- a/conf/machine/rock-5a.conf >+++ b/conf/machine/rock-5a.conf >@@ -7,6 +7,5 @@ require conf/machine/include/rk3588s.inc > > PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" > KERNEL_DEVICETREE = "rockchip/rk3588s-rock-5a.dtb" >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > UBOOT_MACHINE = "rock5a-rk3588s_defconfig" >diff --git a/conf/machine/rock-5b.conf b/conf/machine/rock-5b.conf >index d1371084becc..ea2cf219e153 100644 >--- a/conf/machine/rock-5b.conf >+++ b/conf/machine/rock-5b.conf >@@ -7,6 +7,5 @@ require conf/machine/include/rk3588.inc > > PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" > KERNEL_DEVICETREE = "rockchip/rk3588-rock-5b.dtb" >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > UBOOT_MACHINE = "rock5b-rk3588_defconfig" >diff --git a/conf/machine/rock-pi-e.conf b/conf/machine/rock-pi-e.conf >index 517956c4b9db..1e2169b01993 100644 >--- a/conf/machine/rock-pi-e.conf >+++ b/conf/machine/rock-pi-e.conf >@@ -6,6 +6,5 @@ > require conf/machine/include/rk3328.inc > > KERNEL_DEVICETREE = "rockchip/rk3328-rock-pi-e.dtb" >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > UBOOT_MACHINE = "rock-pi-e-rk3328_defconfig" >diff --git a/conf/machine/rock-pi-s.conf b/conf/machine/rock-pi-s.conf >index 79ea73c6b47e..3aa868b7ec7c 100644 >--- a/conf/machine/rock-pi-s.conf >+++ b/conf/machine/rock-pi-s.conf >@@ -6,6 +6,5 @@ > require conf/machine/include/rk3308.inc > > KERNEL_DEVICETREE = "rockchip/rk3308-rock-pi-s.dtb" >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > UBOOT_MACHINE = "rock-pi-s-rk3308_defconfig"
On Mon, Jan 15, 2024 at 4:57 AM Quentin Schulz <foss@0leil.net> wrote: > > Hi Trevor, > > On January 14, 2024 3:46:18 PM GMT+01:00, Trevor Woerner <twoerner@gmail.com> wrote: > >A BSP layer shouldn't be deciding to include all kernel modules. That's more > >of a distro decision, or for local.conf at a minimum. Modules that are > >required for the basic functioning of a board are fine, but doing a blanket > >"install all" is overreach and inflates images unnecessarily (~45MB, by one > >measurement). > > > > It's only a RRECOMMENDS, so I'd say this is fine as is? This allows to have a working system without spending too much time figuring out what's exactly needed. If someone needs to have a smaller image, they can then play with kernel defconfig or kernel-modules- in packages to install. > Yeah on one thought, BSP users may not be well versed in OE speak and this adds to their bad starting experience but it also has a bad effect where the images are bloated. So IMO if it is well documented how to enable/disable it easily could be useful. I don't have strong leanings on which way you want to go w.r.t defaults. > Up to you though :) > > Cheers, > Quentin > > >I expect patches will probably roll in after this one to add back necessary > >modules, but it will be easier to figure out which ones when starting with > >having none of them included by default. > > > >Signed-off-by: Trevor Woerner <twoerner@gmail.com> > >--- > > conf/machine/include/rock-pi-4.inc | 2 -- > > conf/machine/nanopi-m4b.conf | 2 -- > > conf/machine/nanopi-r2s.conf | 1 - > > conf/machine/nanopi-r4s.conf | 2 -- > > conf/machine/rock-5a.conf | 1 - > > conf/machine/rock-5b.conf | 1 - > > conf/machine/rock-pi-e.conf | 1 - > > conf/machine/rock-pi-s.conf | 1 - > > 8 files changed, 11 deletions(-) > > > >diff --git a/conf/machine/include/rock-pi-4.inc b/conf/machine/include/rock-pi-4.inc > >index 0a868463bc64..02dfb18fc775 100644 > >--- a/conf/machine/include/rock-pi-4.inc > >+++ b/conf/machine/include/rock-pi-4.inc > >@@ -2,5 +2,3 @@ > > MACHINEOVERRIDES =. "rock-pi-4:" > > > > require conf/machine/include/rk3399.inc > >- > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > >diff --git a/conf/machine/nanopi-m4b.conf b/conf/machine/nanopi-m4b.conf > >index 35cd8f68e82e..b924b0018867 100644 > >--- a/conf/machine/nanopi-m4b.conf > >+++ b/conf/machine/nanopi-m4b.conf > >@@ -5,7 +5,5 @@ > > > > require conf/machine/include/rk3399.inc > > > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > >- > > KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-m4b.dtb" > > UBOOT_MACHINE = "nanopi-m4b-rk3399_defconfig" > >diff --git a/conf/machine/nanopi-r2s.conf b/conf/machine/nanopi-r2s.conf > >index 4472c21f0217..0451002ecff5 100644 > >--- a/conf/machine/nanopi-r2s.conf > >+++ b/conf/machine/nanopi-r2s.conf > >@@ -6,6 +6,5 @@ > > require conf/machine/include/rk3328.inc > > > > KERNEL_DEVICETREE = "rockchip/rk3328-nanopi-r2s.dtb" > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > > > UBOOT_MACHINE = "nanopi-r2s-rk3328_defconfig" > >diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf > >index 21be4400c89d..161f4b4e4609 100644 > >--- a/conf/machine/nanopi-r4s.conf > >+++ b/conf/machine/nanopi-r4s.conf > >@@ -5,7 +5,5 @@ > > > > require conf/machine/include/rk3399.inc > > > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > >- > > KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-r4s.dtb" > > UBOOT_MACHINE = "nanopi-r4s-rk3399_defconfig" > >diff --git a/conf/machine/rock-5a.conf b/conf/machine/rock-5a.conf > >index 5ace4dac8fe4..28e06486eda3 100644 > >--- a/conf/machine/rock-5a.conf > >+++ b/conf/machine/rock-5a.conf > >@@ -7,6 +7,5 @@ require conf/machine/include/rk3588s.inc > > > > PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" > > KERNEL_DEVICETREE = "rockchip/rk3588s-rock-5a.dtb" > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > > > UBOOT_MACHINE = "rock5a-rk3588s_defconfig" > >diff --git a/conf/machine/rock-5b.conf b/conf/machine/rock-5b.conf > >index d1371084becc..ea2cf219e153 100644 > >--- a/conf/machine/rock-5b.conf > >+++ b/conf/machine/rock-5b.conf > >@@ -7,6 +7,5 @@ require conf/machine/include/rk3588.inc > > > > PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" > > KERNEL_DEVICETREE = "rockchip/rk3588-rock-5b.dtb" > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > > > UBOOT_MACHINE = "rock5b-rk3588_defconfig" > >diff --git a/conf/machine/rock-pi-e.conf b/conf/machine/rock-pi-e.conf > >index 517956c4b9db..1e2169b01993 100644 > >--- a/conf/machine/rock-pi-e.conf > >+++ b/conf/machine/rock-pi-e.conf > >@@ -6,6 +6,5 @@ > > require conf/machine/include/rk3328.inc > > > > KERNEL_DEVICETREE = "rockchip/rk3328-rock-pi-e.dtb" > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > > > UBOOT_MACHINE = "rock-pi-e-rk3328_defconfig" > >diff --git a/conf/machine/rock-pi-s.conf b/conf/machine/rock-pi-s.conf > >index 79ea73c6b47e..3aa868b7ec7c 100644 > >--- a/conf/machine/rock-pi-s.conf > >+++ b/conf/machine/rock-pi-s.conf > >@@ -6,6 +6,5 @@ > > require conf/machine/include/rk3308.inc > > > > KERNEL_DEVICETREE = "rockchip/rk3308-rock-pi-s.dtb" > >-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" > > > > UBOOT_MACHINE = "rock-pi-s-rk3308_defconfig" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > You automatically follow any topics you start or reply to. > View/Reply Online (#62145): https://lists.yoctoproject.org/g/yocto/message/62145 > Mute This Topic: https://lists.yoctoproject.org/mt/103719387/1997914 > Group Owner: yocto+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/conf/machine/include/rock-pi-4.inc b/conf/machine/include/rock-pi-4.inc index 0a868463bc64..02dfb18fc775 100644 --- a/conf/machine/include/rock-pi-4.inc +++ b/conf/machine/include/rock-pi-4.inc @@ -2,5 +2,3 @@ MACHINEOVERRIDES =. "rock-pi-4:" require conf/machine/include/rk3399.inc - -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" diff --git a/conf/machine/nanopi-m4b.conf b/conf/machine/nanopi-m4b.conf index 35cd8f68e82e..b924b0018867 100644 --- a/conf/machine/nanopi-m4b.conf +++ b/conf/machine/nanopi-m4b.conf @@ -5,7 +5,5 @@ require conf/machine/include/rk3399.inc -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" - KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-m4b.dtb" UBOOT_MACHINE = "nanopi-m4b-rk3399_defconfig" diff --git a/conf/machine/nanopi-r2s.conf b/conf/machine/nanopi-r2s.conf index 4472c21f0217..0451002ecff5 100644 --- a/conf/machine/nanopi-r2s.conf +++ b/conf/machine/nanopi-r2s.conf @@ -6,6 +6,5 @@ require conf/machine/include/rk3328.inc KERNEL_DEVICETREE = "rockchip/rk3328-nanopi-r2s.dtb" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" UBOOT_MACHINE = "nanopi-r2s-rk3328_defconfig" diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf index 21be4400c89d..161f4b4e4609 100644 --- a/conf/machine/nanopi-r4s.conf +++ b/conf/machine/nanopi-r4s.conf @@ -5,7 +5,5 @@ require conf/machine/include/rk3399.inc -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" - KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-r4s.dtb" UBOOT_MACHINE = "nanopi-r4s-rk3399_defconfig" diff --git a/conf/machine/rock-5a.conf b/conf/machine/rock-5a.conf index 5ace4dac8fe4..28e06486eda3 100644 --- a/conf/machine/rock-5a.conf +++ b/conf/machine/rock-5a.conf @@ -7,6 +7,5 @@ require conf/machine/include/rk3588s.inc PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" KERNEL_DEVICETREE = "rockchip/rk3588s-rock-5a.dtb" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" UBOOT_MACHINE = "rock5a-rk3588s_defconfig" diff --git a/conf/machine/rock-5b.conf b/conf/machine/rock-5b.conf index d1371084becc..ea2cf219e153 100644 --- a/conf/machine/rock-5b.conf +++ b/conf/machine/rock-5b.conf @@ -7,6 +7,5 @@ require conf/machine/include/rk3588.inc PREFERRED_PROVIDER_virtual/kernel = "linux-yocto-dev" KERNEL_DEVICETREE = "rockchip/rk3588-rock-5b.dtb" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" UBOOT_MACHINE = "rock5b-rk3588_defconfig" diff --git a/conf/machine/rock-pi-e.conf b/conf/machine/rock-pi-e.conf index 517956c4b9db..1e2169b01993 100644 --- a/conf/machine/rock-pi-e.conf +++ b/conf/machine/rock-pi-e.conf @@ -6,6 +6,5 @@ require conf/machine/include/rk3328.inc KERNEL_DEVICETREE = "rockchip/rk3328-rock-pi-e.dtb" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" UBOOT_MACHINE = "rock-pi-e-rk3328_defconfig" diff --git a/conf/machine/rock-pi-s.conf b/conf/machine/rock-pi-s.conf index 79ea73c6b47e..3aa868b7ec7c 100644 --- a/conf/machine/rock-pi-s.conf +++ b/conf/machine/rock-pi-s.conf @@ -6,6 +6,5 @@ require conf/machine/include/rk3308.inc KERNEL_DEVICETREE = "rockchip/rk3308-rock-pi-s.dtb" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" UBOOT_MACHINE = "rock-pi-s-rk3308_defconfig"
A BSP layer shouldn't be deciding to include all kernel modules. That's more of a distro decision, or for local.conf at a minimum. Modules that are required for the basic functioning of a board are fine, but doing a blanket "install all" is overreach and inflates images unnecessarily (~45MB, by one measurement). I expect patches will probably roll in after this one to add back necessary modules, but it will be easier to figure out which ones when starting with having none of them included by default. Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- conf/machine/include/rock-pi-4.inc | 2 -- conf/machine/nanopi-m4b.conf | 2 -- conf/machine/nanopi-r2s.conf | 1 - conf/machine/nanopi-r4s.conf | 2 -- conf/machine/rock-5a.conf | 1 - conf/machine/rock-5b.conf | 1 - conf/machine/rock-pi-e.conf | 1 - conf/machine/rock-pi-s.conf | 1 - 8 files changed, 11 deletions(-)