| Message ID | 20230720182935.1089619-1-vivien.didelot@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-raspberrypi] rpi-libcamera-apps: fix Illegal Instruction | expand |
Hi, On Thu, Jul 20, 2023 at 7:30 PM Vivien Didelot <vivien.didelot@gmail.com> wrote: > With armv8-neon being enforced for all ARM based machines, running > any libcamera app on raspberrypi (e.g. Raspberry Pi B Rev 2) results > in Illegal Instruction. > > To fix this, defaults to TARGET_ARCH for non-aarch64 machines. > > Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com> > --- > recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb > b/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb > index 062ded9..3460065 100644 > --- a/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb > +++ b/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb > @@ -30,7 +30,6 @@ EXTRA_OECMAKE = "\ > > LIBCAMERA_ARCH = "${TARGET_ARCH}" > LIBCAMERA_ARCH:aarch64 = "arm64" > -LIBCAMERA_ARCH:arm = "armv8-neon" > EXTRA_OECMAKE += "-DENABLE_COMPILE_FLAGS_FOR_TARGET=${LIBCAMERA_ARCH}" > Thanks for this. It looks good. Would you be able to send it as an MR in Github so we can CI it as well? Andrei
diff --git a/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb b/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb index 062ded9..3460065 100644 --- a/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb +++ b/recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb @@ -30,7 +30,6 @@ EXTRA_OECMAKE = "\ LIBCAMERA_ARCH = "${TARGET_ARCH}" LIBCAMERA_ARCH:aarch64 = "arm64" -LIBCAMERA_ARCH:arm = "armv8-neon" EXTRA_OECMAKE += "-DENABLE_COMPILE_FLAGS_FOR_TARGET=${LIBCAMERA_ARCH}" PACKAGECONFIG[x11] = "-DENABLE_X11=1,-DENABLE_X11=0"
With armv8-neon being enforced for all ARM based machines, running any libcamera app on raspberrypi (e.g. Raspberry Pi B Rev 2) results in Illegal Instruction. To fix this, defaults to TARGET_ARCH for non-aarch64 machines. Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com> --- recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb | 1 - 1 file changed, 1 deletion(-)