diff mbox series

[meta-raspberrypi] xserver-xorg: remove xshmfence configure option

Message ID 20211209025956.41679-1-mingli.yu@windriver.com
State New
Headers show
Series [meta-raspberrypi] xserver-xorg: remove xshmfence configure option | expand

Commit Message

Yu, Mingli Dec. 9, 2021, 2:59 a.m. UTC 
From: Mingli Yu <mingli.yu@windriver.com>

After the commit [1] introduced in openembedded-core layer,
some configure options is't carried over include xshmfence
option, so remove the xshmfence configure option to silence
the below warning.
  WARNING: xserver-xorg-2_21.1.1-r0 do_configure: QA Issue: xserver-xorg: invalid PACKAGECONFIG: xshmfence [invalid-packageconfig]

[1] https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Dec. 9, 2021, 5:37 a.m. UTC | #1 
On Wed, Dec 8, 2021 at 7:03 PM Yu, Mingli <mingli.yu@windriver.com> wrote:

> From: Mingli Yu <mingli.yu@windriver.com>
>
> After the commit [1] introduced in openembedded-core layer,
> some configure options is't carried over include xshmfence
> option, so remove the xshmfence configure option to silence
> the below warning.
>   WARNING: xserver-xorg-2_21.1.1-r0 do_configure: QA Issue: xserver-xorg:
> invalid PACKAGECONFIG: xshmfence [invalid-packageconfig]
>

That’s ok to remove it but more importantly does it work now without this
option

>
> [1]
> https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
> b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
> index 25829c2..ee4812f 100644
> --- a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
> +++ b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
> @@ -1,4 +1,4 @@
> -OPENGL_PKGCONFIGS:rpi = "dri glx ${@bb.utils.contains('MACHINE_FEATURES',
> 'vc4graphics', 'dri3 xshmfence glamor', '', d)}"
> +OPENGL_PKGCONFIGS:rpi = "dri glx ${@bb.utils.contains('MACHINE_FEATURES',
> 'vc4graphics', 'dri3 glamor', '', d)}"
>
>  # when using userland graphic KHR/khrplatform.h is provided by userland
> but virtual/libgl is provided by mesa-gl where
>  # we explicitly delete KHR/khrplatform.h since its already coming from
> userland package
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> You automatically follow any topics you start or reply to.
> View/Reply Online (#55531):
> https://lists.yoctoproject.org/g/yocto/message/55531
> Mute This Topic: https://lists.yoctoproject.org/mt/87605115/1997914
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Yu, Mingli Dec. 23, 2021, 2:25 a.m. UTC | #2 
On 12/9/21 1:37 PM, Khem Raj wrote:
> **[Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> 
> 
> On Wed, Dec 8, 2021 at 7:03 PM Yu, Mingli <mingli.yu@windriver.com 
> <mailto:mingli.yu@windriver.com>> wrote:
> 
>     From: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
> 
>     After the commit [1] introduced in openembedded-core layer,
>     some configure options is't carried over include xshmfence
>     option, so remove the xshmfence configure option to silence
>     the below warning.
>        WARNING: xserver-xorg-2_21.1.1-r0 do_configure: QA Issue:
>     xserver-xorg: invalid PACKAGECONFIG: xshmfence [invalid-packageconfig]
> 
> 
> That’s ok to remove it but more importantly does it work now without 
> this option

First we should keep consistent with the change with 
openembedded-core(https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8) 
and also not found any issue related to this option until now.

Thanks,

> 
> 
>     [1]
>     https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8
>     <https://urldefense.com/v3/__https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8__;!!AjveYdw8EvQ!O1dnnmQhKwEt9e40TMNLjFCci501QrS-7Erm4Fz5co01OzoGEk8NfXDGEi2vpfa5oCE$>
> 
>     Signed-off-by: Mingli Yu <mingli.yu@windriver.com
>     <mailto:mingli.yu@windriver.com>>
>     ---
>       recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
>     b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
>     index 25829c2..ee4812f 100644
>     --- a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
>     +++ b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
>     @@ -1,4 +1,4 @@
>     -OPENGL_PKGCONFIGS:rpi = "dri glx
>     ${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'dri3
>     xshmfence glamor', '', d)}"
>     +OPENGL_PKGCONFIGS:rpi = "dri glx
>     ${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'dri3
>     glamor', '', d)}"
> 
>       # when using userland graphic KHR/khrplatform.h is provided by
>     userland but virtual/libgl is provided by mesa-gl where
>       # we explicitly delete KHR/khrplatform.h since its already coming
>     from userland package
>     -- 
>     2.17.1
> 
> 
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     You automatically follow any topics you start or reply to.
>     View/Reply Online (#55531):
>     https://lists.yoctoproject.org/g/yocto/message/55531
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/g/yocto/message/55531__;!!AjveYdw8EvQ!O1dnnmQhKwEt9e40TMNLjFCci501QrS-7Erm4Fz5co01OzoGEk8NfXDGEi2vXmKGDl8$>
>     Mute This Topic: https://lists.yoctoproject.org/mt/87605115/1997914
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/87605115/1997914__;!!AjveYdw8EvQ!O1dnnmQhKwEt9e40TMNLjFCci501QrS-7Erm4Fz5co01OzoGEk8NfXDGEi2vWeRAtqk$>
>     Group Owner: yocto+owner@lists.yoctoproject.org
>     <mailto:yocto%2Bowner@lists.yoctoproject.org>
>     Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub
>     <https://urldefense.com/v3/__https://lists.yoctoproject.org/g/yocto/unsub__;!!AjveYdw8EvQ!O1dnnmQhKwEt9e40TMNLjFCci501QrS-7Erm4Fz5co01OzoGEk8NfXDGEi2vSS7YAOE$>
>     [raj.khem@gmail.com <mailto:raj.khem@gmail.com>]
>     -=-=-=-=-=-=-=-=-=-=-=-
>
Andreas Müller Dec. 29, 2021, 3:57 p.m. UTC | #3 
On Thu, Dec 9, 2021 at 6:37 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> On Wed, Dec 8, 2021 at 7:03 PM Yu, Mingli <mingli.yu@windriver.com> wrote:
>>
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> After the commit [1] introduced in openembedded-core layer,
>> some configure options is't carried over include xshmfence
>> option, so remove the xshmfence configure option to silence
>> the below warning.
>>   WARNING: xserver-xorg-2_21.1.1-r0 do_configure: QA Issue: xserver-xorg: invalid PACKAGECONFIG: xshmfence [invalid-packageconfig]
>
>
> That’s ok to remove it but more importantly does it work now without this option
Looked into xserver's meson.build: As soon as dri3  is added - which
we do - libxshmfence turns into a mandatory dependency. So this patch
is correct.
Somehow libxshmfence is added to sysroot - maybe we should add it
explicitly to dri3 PACKAGECONFIG in oe-core to be more explicit.

Slightly off-topic but we are on xserver on Raspi: Has anybody tested
xserver recently? I see nasty issues on raspi4-64 / XFCE (haven't
tried other desktops yet):

* As soon as a window is opened, screen turns black for 1-2 seconds.
Have not yet found helpful in logs yet.
* There are two mouse devices detected with name 'vc4'. What?

Cheers

Andreas
Andrei Gherzan Jan. 4, 2022, 12:10 p.m. UTC | #4 
On Thu, 9 Dec 2021, at 02:59, Yu, Mingli wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
>
> After the commit [1] introduced in openembedded-core layer,
> some configure options is't carried over include xshmfence
> option, so remove the xshmfence configure option to silence
> the below warning.
>   WARNING: xserver-xorg-2_21.1.1-r0 do_configure: QA Issue: 
> xserver-xorg: invalid PACKAGECONFIG: xshmfence [invalid-packageconfig]
>
> [1] 
> https://git.openembedded.org/openembedded-core/commit/?id=e05abd87ee5d23750c641d0129d9c83db68ee2e8
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>

I have merged this to master.

Thanks,
Andrei
diff mbox series

Patch

diff --git a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
index 25829c2..ee4812f 100644
--- a/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
+++ b/recipes-graphics/xorg-xserver/xserver-xorg_%.bbappend
@@ -1,4 +1,4 @@ 
-OPENGL_PKGCONFIGS:rpi = "dri glx ${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'dri3 xshmfence glamor', '', d)}"
+OPENGL_PKGCONFIGS:rpi = "dri glx ${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'dri3 glamor', '', d)}"
 
 # when using userland graphic KHR/khrplatform.h is provided by userland but virtual/libgl is provided by mesa-gl where
 # we explicitly delete KHR/khrplatform.h since its already coming from userland package