[meta-security,1/2] openssl-tpm-engine: fix warning for append operator combined with +=

Message ID 20211119151825.530200-1-yi.zhao@windriver.com
State New
Headers show
Series [meta-security,1/2] openssl-tpm-engine: fix warning for append operator combined with += | expand

Commit Message

Yi Zhao Nov. 19, 2021, 3:18 p.m. UTC
Fixes:
WARNING: openssl-tpm-engine_0.5.0.bb: CFLAGS:append += is not a
recommended operator combination, please replace it.

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
 .../openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

akuster808 Nov. 29, 2021, 12:17 a.m. UTC | #1
merged.

thanks

On 11/19/21 7:18 AM, Yi Zhao wrote:
> Fixes:
> WARNING: openssl-tpm-engine_0.5.0.bb: CFLAGS:append += is not a
> recommended operator combination, please replace it.
>
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
>  .../openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb            | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb b/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
> index ef663eb..2b969ed 100644
> --- a/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
> +++ b/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
> @@ -35,10 +35,10 @@ inherit autotools-brokensep pkgconfig
>  srk_dec_pw ?= "\\"\\\x1\\"\\"nc\\"\\"\\\x3\\"\\"nd\\"\\"\\\x1\\"\\"a\\""
>  srk_dec_salt ?= "\\"r\\"\\"\\\x00\\\x00\\"\\"t\\""
>  
> -CFLAGS:append += "-DSRK_DEC_PW=${srk_dec_pw} -DSRK_DEC_SALT=${srk_dec_salt}"
> +CFLAGS:append = " -DSRK_DEC_PW=${srk_dec_pw} -DSRK_DEC_SALT=${srk_dec_salt}"
>  
>  # Uncomment below line if using the plain srk password for development
> -#CFLAGS_append += "-DTPM_SRK_PLAIN_PW"
> +#CFLAGS:append = " -DTPM_SRK_PLAIN_PW"
>  
>  do_configure:prepend() {
>      cd ${B}
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#55378): https://lists.yoctoproject.org/g/yocto/message/55378
> Mute This Topic: https://lists.yoctoproject.org/mt/87169937/3616698
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [akuster808@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb b/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
index ef663eb..2b969ed 100644
--- a/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
+++ b/meta-tpm/recipes-tpm/openssl-tpm-engine/openssl-tpm-engine_0.5.0.bb
@@ -35,10 +35,10 @@  inherit autotools-brokensep pkgconfig
 srk_dec_pw ?= "\\"\\\x1\\"\\"nc\\"\\"\\\x3\\"\\"nd\\"\\"\\\x1\\"\\"a\\""
 srk_dec_salt ?= "\\"r\\"\\"\\\x00\\\x00\\"\\"t\\""
 
-CFLAGS:append += "-DSRK_DEC_PW=${srk_dec_pw} -DSRK_DEC_SALT=${srk_dec_salt}"
+CFLAGS:append = " -DSRK_DEC_PW=${srk_dec_pw} -DSRK_DEC_SALT=${srk_dec_salt}"
 
 # Uncomment below line if using the plain srk password for development
-#CFLAGS_append += "-DTPM_SRK_PLAIN_PW"
+#CFLAGS:append = " -DTPM_SRK_PLAIN_PW"
 
 do_configure:prepend() {
     cd ${B}