diff mbox series

[pseudo,13/34] ports/linux: Drop redundant PSEUDO_LINK_SYMLINK_BEHAVIOR override

Message ID 1794370862-30908-14-git-send-email-mark.hatle@kernel.crashing.org
State New
Headers show
Series Various fixes | expand

Commit Message

Mark Hatle Nov. 11, 2026, 4:20 a.m. UTC 
From: Mark Hatle <mark.hatle@amd.com>

ports/linux/portdefs.h redefined PSEUDO_LINK_SYMLINK_BEHAVIOR to 0,
the default already set in pseudo.h.  Remove it, and move its note that
0 means not following symlinks, because linkat() rejects
AT_SYMLINK_NOFOLLOW, into the comment in pseudo.h.

AI-Generated: Uses GitHub Copilot
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
---
 ports/linux/portdefs.h | 9 ---------
 pseudo.h               | 3 ++-
 2 files changed, 2 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/ports/linux/portdefs.h b/ports/linux/portdefs.h
index 3ac9466..97ddcb6 100644
--- a/ports/linux/portdefs.h
+++ b/ports/linux/portdefs.h
@@ -15,15 +15,6 @@ 
 #define base_stat real_stat64
 #define base_fstatat(dirfd, path, buf, flags) real___fxstatat64(_STAT_VER, dirfd, path, buf, flags)
 #define PSEUDO_LINKPATH_SEPARATOR " "
-/* Linux NEVER follows symlinks for link(2)... except on old kernels
- * I don't care about.
- */
-#undef PSEUDO_LINK_SYMLINK_BEHAVIOR
-/* Note: 0, here, really means AT_SYMLINK_NOFOLLOW, but specifying that
- * causes errors; you have to leave it empty or specify AT_SYMLINK_FOLLOW.
- */
-#define PSEUDO_LINK_SYMLINK_BEHAVIOR 0
-
 /* There were symbol changes that can cause the linker to request
  * newer versions of glibc, which causes problems occasionally on
  * older hosts if pseudo is built against a newer glibc and then
diff --git a/pseudo.h b/pseudo.h
index d83281c..13249bf 100644
--- a/pseudo.h
+++ b/pseudo.h
@@ -155,7 +155,8 @@  extern char *pseudo_version;
  * would ever do that? Well, Linux did, and possibly as a result, linkat()
  * does by default too; if you are on a host with the historical Unix
  * behavior of following symlinks to find the link target, you will want
- * to set this to AT_SYMLINK_FOLLOW.
+ * to set this to AT_SYMLINK_FOLLOW.  0 means not following them; it can't
+ * be AT_SYMLINK_NOFOLLOW, as linkat() rejects that flag.
  */
 #define PSEUDO_LINK_SYMLINK_BEHAVIOR 0