mbox series

[pseudo,0/3] Memory management fixes and b4 config

Message ID 20260320-some-fixes-v1-0-f5ca33dbf180@pbarker.dev
Headers show
Series Memory management fixes and b4 config | expand

Message

Paul Barker March 20, 2026, 12:01 p.m. UTC
Fix memory management issues found by Claude Opus 4.6, and add
configuration for b4 to simplify sending patches.

---
Paul Barker (3):
      pseudo_setupenvp: Allocate space for new env vars if needed
      pseudo_setupenvp: Handle malloc failure safely
      Add b4 configuration

 .b4-config    |  4 ++++
 pseudo_util.c | 18 ++++++++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)
---
base-commit: 56e1f8df4761da60e41812fc32b1de797d1765e9
change-id: 20260320-some-fixes-d87097cdbeb5

Best regards,

Comments

Mark Hatle March 20, 2026, 2:32 p.m. UTC | #1
The set looks good to me.  I'm surprised about the possible alloc/buffer overflow.

I suspect it's never triggered because we over allocate for the PSEUDO variables 
just before that, but relying on that behavior is not safe, so your change 
should ensure we have enough space at all times.

--Mark

On 3/20/26 7:01 AM, Paul Barker wrote:
> Fix memory management issues found by Claude Opus 4.6, and add
> configuration for b4 to simplify sending patches.
> 
> ---
> Paul Barker (3):
>        pseudo_setupenvp: Allocate space for new env vars if needed
>        pseudo_setupenvp: Handle malloc failure safely
>        Add b4 configuration
> 
>   .b4-config    |  4 ++++
>   pseudo_util.c | 18 ++++++++++++++----
>   2 files changed, 18 insertions(+), 4 deletions(-)
> ---
> base-commit: 56e1f8df4761da60e41812fc32b1de797d1765e9
> change-id: 20260320-some-fixes-d87097cdbeb5
> 
> Best regards,