mbox series

[meta-rockchip,0/2] bsp: rkbin: fix build issues around S and WORKDIR

Message ID 20250625-s-unpackdir-v1-0-6f45466478d8@cherry.de
Headers show
Series bsp: rkbin: fix build issues around S and WORKDIR | expand

Message

Quentin Schulz June 25, 2025, 12:07 p.m. UTC
Since commit 46480a5e6674 ("insane/do_qa_unpack: add checks that ensure
S is set correctly"), three recipes fail to build because they either:

- set S to WORKDIR/git which isn't allowed anymore for git-fetched
  recipes,
- have WORKDIR in S which isn't allowed anymore, UNPACKDIR should be
  used instead,

This fixes the build issues seen on master.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
Quentin Schulz (2):
      bsp: rkbin: fix build since S = "${WORKDIR}/git" is implied by OE-Core
      bsp: rkbin-native: fix build since ${WORKDIR} isn't allowed in S anymore

 recipes-bsp/rkbin/rk3308-rkbin_git.bb          | 2 --
 recipes-bsp/rkbin/rockchip-rkbin-native_git.bb | 2 +-
 recipes-bsp/rkbin/rockchip-rkbin.inc           | 2 --
 3 files changed, 1 insertion(+), 5 deletions(-)
---
base-commit: 961768ccd13630a4b98701f5821372a9ede86e85
change-id: 20250625-s-unpackdir-8fee740998d0

Best regards,

Comments

Trevor Woerner June 25, 2025, 3:53 p.m. UTC | #1
On Wed 2025-06-25 @ 02:07:12 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> Since commit 46480a5e6674 ("insane/do_qa_unpack: add checks that ensure
> S is set correctly"), three recipes fail to build because they either:
> 
> - set S to WORKDIR/git which isn't allowed anymore for git-fetched
>   recipes,
> - have WORKDIR in S which isn't allowed anymore, UNPACKDIR should be
>   used instead,
> 
> This fixes the build issues seen on master.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
> Quentin Schulz (2):
>       bsp: rkbin: fix build since S = "${WORKDIR}/git" is implied by OE-Core
>       bsp: rkbin-native: fix build since ${WORKDIR} isn't allowed in S anymore
> 
>  recipes-bsp/rkbin/rk3308-rkbin_git.bb          | 2 --
>  recipes-bsp/rkbin/rockchip-rkbin-native_git.bb | 2 +-
>  recipes-bsp/rkbin/rockchip-rkbin.inc           | 2 --
>  3 files changed, 1 insertion(+), 5 deletions(-)
> ---
> base-commit: 961768ccd13630a4b98701f5821372a9ede86e85
> change-id: 20250625-s-unpackdir-8fee740998d0

Applied to meta-rockchip, master branch. Thanks!