mbox series

[meta-rockchip,0/2] enable Panfrost on RK3328 and RK3568

Message ID 20240531-mesa-panfrost-v1-0-84e23ae9a600@cherry.de
Headers show
Series enable Panfrost on RK3328 and RK3568 | expand

Message

Quentin Schulz May 31, 2024, 12:48 p.m. UTC
Note: I do not have access to any RK3328 or RK3568 device so I could
not test those patches.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
Quentin Schulz (2):
      mesa: enable lima on all rk3328 boards
      mesa: build panfrost for RK3568 boards

 recipes-graphics/mesa/mesa_%.bbappend | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 3381d6af6eabfb532da16863b785a95abba6b9e8
change-id: 20240531-mesa-panfrost-f975f1251b6c

Best regards,

Comments

Trevor Woerner June 11, 2024, 1:29 p.m. UTC | #1
On Fri 2024-05-31 @ 02:48:13 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> Note: I do not have access to any RK3328 or RK3568 device so I could
> not test those patches.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
> Quentin Schulz (2):
>       mesa: enable lima on all rk3328 boards
>       mesa: build panfrost for RK3568 boards
> 
>  recipes-graphics/mesa/mesa_%.bbappend | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> ---
> base-commit: 3381d6af6eabfb532da16863b785a95abba6b9e8
> change-id: 20240531-mesa-panfrost-f975f1251b6c

I have a couple rk3328-based boards, but the rock64 is the only one of these
that has a video output device (hdmi). So I guess if someone really wants to
build a graphics-based image for an rk3328-based board that doesn't have a
video dongle, then I guess they would want panfrost too (?)

It's been a long time since I've done any graphics stuff, I have a rock-3a
that is rk3568-based but couldn't get x11 nor weston/wayland working. I
probably need to do more fiddling.

Neither of these patches interfere with the build so I'm okay adding them.
Would you also want them on scarthgap as well?
Quentin Schulz June 11, 2024, 1:46 p.m. UTC | #2
Hi Trevor,

On 6/11/24 3:29 PM, Trevor Woerner wrote:
> On Fri 2024-05-31 @ 02:48:13 PM, Quentin Schulz via lists.yoctoproject.org wrote:
>> Note: I do not have access to any RK3328 or RK3568 device so I could
>> not test those patches.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
>> ---
>> Quentin Schulz (2):
>>        mesa: enable lima on all rk3328 boards
>>        mesa: build panfrost for RK3568 boards
>>
>>   recipes-graphics/mesa/mesa_%.bbappend | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> ---
>> base-commit: 3381d6af6eabfb532da16863b785a95abba6b9e8
>> change-id: 20240531-mesa-panfrost-f975f1251b6c
> 
> I have a couple rk3328-based boards, but the rock64 is the only one of these
> that has a video output device (hdmi). So I guess if someone really wants to
> build a graphics-based image for an rk3328-based board that doesn't have a
> video dongle, then I guess they would want panfrost too (?)
> 

The NanoPi R2S and RockPiE seem to be the only ones with no video output 
at all (the display subsystem is even disabled in the DTS for the NanoPi).

In any case, it should technically be possible to use the GPU without 
any video output, though I haven't managed to make my RK3588 boards work 
without DSI or HDMI support with Panthor so no clue how this should work :/

Not everything done by the GPU is for displaying stuff (could be used 
for maths stuff, openCL and the likes, on headless systems).

> It's been a long time since I've done any graphics stuff, I have a rock-3a
> that is rk3568-based but couldn't get x11 nor weston/wayland working. I
> probably need to do more fiddling.
> 

I only use kmscube for my tests. You basically only need to make sure 
that the renderer isn't LLVMPipe or swrast and you're good to go.

> Neither of these patches interfere with the build so I'm okay adding them.
> Would you also want them on scarthgap as well?

I have no personal or professional interest in those patches so up to 
you, it's just that I'll need some patches for RK3588 Panthor once we 
publish a downstream kernel with support for it (there's already one but 
I don't want people to start using it, so not creating a recipe just now 
:) ), and this patch series will then probably conflict with it in the 
git context, but nothing too difficult to deal with :)

So, up to you!

Cheers,
Quentin
Trevor Woerner June 11, 2024, 6:22 p.m. UTC | #3
On Tue 2024-06-11 @ 03:46:52 PM, Quentin Schulz wrote:
> Hi Trevor,
> 
> On 6/11/24 3:29 PM, Trevor Woerner wrote:
> > On Fri 2024-05-31 @ 02:48:13 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> > > Note: I do not have access to any RK3328 or RK3568 device so I could
> > > not test those patches.
> > > 
> > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> > > ---
> > > Quentin Schulz (2):
> > >        mesa: enable lima on all rk3328 boards
> > >        mesa: build panfrost for RK3568 boards
> > > 
> > >   recipes-graphics/mesa/mesa_%.bbappend | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)

Applied to meta-rockchip, master branch. Thanks!