| Message ID | 20231204183055.29931-1-antonio@amsobr.com |
|---|---|
| Headers | show |
| Series | lts mixin: kirkstone/nodejs proposal | expand |
António Oliveira <antonio@amsobr.com> escreveu no dia segunda, 4/12/2023 à(s) 18:31: > Hi all, > > This patch contains my proposal for an mixin layer that adds nodejs v18 > and v20 to kirkstone. > > Kirkstone ships with nodejs-16, whose maintenance window ended in > October 2023 (a). > > Kirkstone will be supported until April 2026 and it would be nice to have > some level of support for a maintained version of nodejs during that time > window. > > This proposal seeks to address that by adding nodejs-18 and nodejs-20, > which will be maintained until April 2025 and 2026, respectively. > > The recipes for nodejs-18 are taken from Mickledore and the recipes for > nodejs-20 from master. > > The variable NODE_VERSION can be ser in local.conf to choose either v18 > or v20 (the default). > > This is my first attempt at sending a patch upstream with git send-email > so any comments or suggestions for improvement are welcome. That's also > the reason why I marked this as an RFC. > Hi Antonio, If the patchset was made with more and smaller commits it would make the review easier but it is perfect in my opinion with the context well explained. The git send-mail is much simpler than it seems. Thanks for your contributions. Jose > > Cheers, > António > > António Oliveira (1): > initial commit > > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#61791): > https://lists.yoctoproject.org/g/yocto/message/61791 > Mute This Topic: https://lists.yoctoproject.org/mt/102976461/5052612 > Group Owner: yocto+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [ > quaresma.jose@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Tue, Dec 5, 2023 at 10:44 AM Jose Quaresma <quaresma.jose@gmail.com> wrote: > > > > António Oliveira <antonio@amsobr.com> escreveu no dia segunda, 4/12/2023 à(s) 18:31: >> >> Hi all, >> >> This patch contains my proposal for an mixin layer that adds nodejs v18 >> and v20 to kirkstone. >> >> Kirkstone ships with nodejs-16, whose maintenance window ended in >> October 2023 (a). >> >> Kirkstone will be supported until April 2026 and it would be nice to have >> some level of support for a maintained version of nodejs during that time >> window. >> >> This proposal seeks to address that by adding nodejs-18 and nodejs-20, >> which will be maintained until April 2025 and 2026, respectively. >> >> The recipes for nodejs-18 are taken from Mickledore and the recipes for >> nodejs-20 from master. >> >> The variable NODE_VERSION can be ser in local.conf to choose either v18 >> or v20 (the default). >> >> This is my first attempt at sending a patch upstream with git send-email >> so any comments or suggestions for improvement are welcome. That's also >> the reason why I marked this as an RFC. > > > Hi Antonio, > > If the patchset was made with more and smaller commits it would make the review easier > but it is perfect in my opinion with the context well explained. > The git send-mail is much simpler than it seems. > Thanks for your contributions. I thought of that but couldn't really settle for something. I guess I can break it down into smaller pieces, like: * layer config, license, readme... * nodejs-18 * nodejs-20 * setting the choice of node version in layer.conf. Would that work? I can break > > Jose > >> >> >> Cheers, >> António >> >> António Oliveira (1): >> initial commit >> >> -- >> 2.34.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#61791): https://lists.yoctoproject.org/g/yocto/message/61791 >> Mute This Topic: https://lists.yoctoproject.org/mt/102976461/5052612 >> Group Owner: yocto+owner@lists.yoctoproject.org >> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [quaresma.jose@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> > > > -- > Best regards, > > José Quaresma
António Oliveira <antonio@amsobr.com> escreveu no dia terça, 5/12/2023 à(s) 18:26: > On Tue, Dec 5, 2023 at 10:44 AM Jose Quaresma <quaresma.jose@gmail.com> > wrote: > > > > > > > > António Oliveira <antonio@amsobr.com> escreveu no dia segunda, > 4/12/2023 à(s) 18:31: > >> > >> Hi all, > >> > >> This patch contains my proposal for an mixin layer that adds nodejs v18 > >> and v20 to kirkstone. > >> > >> Kirkstone ships with nodejs-16, whose maintenance window ended in > >> October 2023 (a). > >> > >> Kirkstone will be supported until April 2026 and it would be nice to > have > >> some level of support for a maintained version of nodejs during that > time > >> window. > >> > >> This proposal seeks to address that by adding nodejs-18 and nodejs-20, > >> which will be maintained until April 2025 and 2026, respectively. > >> > >> The recipes for nodejs-18 are taken from Mickledore and the recipes for > >> nodejs-20 from master. > >> > >> The variable NODE_VERSION can be ser in local.conf to choose either v18 > >> or v20 (the default). > >> > >> This is my first attempt at sending a patch upstream with git send-email > >> so any comments or suggestions for improvement are welcome. That's also > >> the reason why I marked this as an RFC. > > > > > > Hi Antonio, > > > > If the patchset was made with more and smaller commits it would make the > review easier > > but it is perfect in my opinion with the context well explained. > > The git send-mail is much simpler than it seems. > > Thanks for your contributions. > > I thought of that but couldn't really settle for something. > > I guess I can break it down into smaller pieces, like: > * layer config, license, readme... > * nodejs-18 > * nodejs-20 > * setting the choice of node version in layer.conf. > > Would that work? > It will be better in my opinion but not strictly necessary. Jose > > I can break > > > > Jose > > > >> > >> > >> Cheers, > >> António > >> > >> António Oliveira (1): > >> initial commit > >> > >> -- > >> 2.34.1 > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- > >> Links: You receive all messages sent to this group. > >> View/Reply Online (#61791): > https://lists.yoctoproject.org/g/yocto/message/61791 > >> Mute This Topic: https://lists.yoctoproject.org/mt/102976461/5052612 > >> Group Owner: yocto+owner@lists.yoctoproject.org > >> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [ > quaresma.jose@gmail.com] > >> -=-=-=-=-=-=-=-=-=-=-=- > >> > > > > > > -- > > Best regards, > > > > José Quaresma >