| Message ID | 20250626105933.564282-1-m-chawdhry@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,scarthgap/master] Revert "conf: machine: k3: disable all fit signing for uboot" | expand |
Hi Manorit, On 6/26/25 05:59, Manorit Chawdhry via lists.yoctoproject.org wrote: > The following revert requires a patch in U-boot as well which has been > posted upstream [0] and backported internally too. > > This reverts commit 9656b79cb557a46d2611b67e7e51702f6da05594. > Please add detail on what this patch is fixing and why we are reverting this commit. The current description gives zero information on why we are doing this. regards Suman > [0]: https://lore.kernel.org/all/20250626-b4-upstream-fix-icssg-fit-v1-1-95eff1c853a4@ti.com/ > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> > --- > meta-ti-bsp/conf/machine/include/k3.inc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc > index 9b85f867c206..14d7db8a1184 100644 > --- a/meta-ti-bsp/conf/machine/include/k3.inc > +++ b/meta-ti-bsp/conf/machine/include/k3.inc > @@ -25,6 +25,10 @@ SPL_BINARY = "tispl.bin" > SPL_BINARYNAME = "tispl.bin" > UBOOT_SUFFIX = "img" > > +UBOOT_SIGN_ENABLE = "1" > +UBOOT_MKIMAGE_DTCOPTS = "-I dts -O dtb" > +UBOOT_SIGN_KEYNAME ?= "custMpk" > +UBOOT_SIGN_KEYDIR ?= "${TI_SECURE_DEV_PKG}/keys" > FIT_HASH_ALG ?= "sha512" > FIT_SIGN_ALG ?= "rsa4096" > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#18692): https://lists.yoctoproject.org/g/meta-ti/message/18692 > Mute This Topic: https://lists.yoctoproject.org/mt/113841171/4594561 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [s-anna@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 6/26/2025 12:11 PM, Suman Anna wrote: > Hi Manorit, > > On 6/26/25 05:59, Manorit Chawdhry via lists.yoctoproject.org wrote: >> The following revert requires a patch in U-boot as well which has been >> posted upstream [0] and backported internally too. >> >> This reverts commit 9656b79cb557a46d2611b67e7e51702f6da05594. >> > > Please add detail on what this patch is fixing and why we are reverting this > commit. The current description gives zero information on why we are doing this. To add more... am65 is now failing again with this patch reverted. So, NAK on taking this revert. Someone needs to actually fix the am65 issue that made us disable this in the first place. > regards > Suman > > >> [0]: https://lore.kernel.org/all/20250626-b4-upstream-fix-icssg-fit-v1-1-95eff1c853a4@ti.com/ >> >> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> >> --- >> meta-ti-bsp/conf/machine/include/k3.inc | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc >> index 9b85f867c206..14d7db8a1184 100644 >> --- a/meta-ti-bsp/conf/machine/include/k3.inc >> +++ b/meta-ti-bsp/conf/machine/include/k3.inc >> @@ -25,6 +25,10 @@ SPL_BINARY = "tispl.bin" >> SPL_BINARYNAME = "tispl.bin" >> UBOOT_SUFFIX = "img" >> >> +UBOOT_SIGN_ENABLE = "1" >> +UBOOT_MKIMAGE_DTCOPTS = "-I dts -O dtb" >> +UBOOT_SIGN_KEYNAME ?= "custMpk" >> +UBOOT_SIGN_KEYDIR ?= "${TI_SECURE_DEV_PKG}/keys" >> FIT_HASH_ALG ?= "sha512" >> FIT_SIGN_ALG ?= "rsa4096" >> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#18692): https://lists.yoctoproject.org/g/meta-ti/message/18692 >> Mute This Topic: https://lists.yoctoproject.org/mt/113841171/4594561 >> Group Owner: meta-ti+owner@lists.yoctoproject.org >> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [s-anna@ti.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >
On 6/26/2025 1:43 PM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 6/26/2025 12:11 PM, Suman Anna wrote: >> Hi Manorit, >> >> On 6/26/25 05:59, Manorit Chawdhry via lists.yoctoproject.org wrote: >>> The following revert requires a patch in U-boot as well which has been >>> posted upstream [0] and backported internally too. >>> >>> This reverts commit 9656b79cb557a46d2611b67e7e51702f6da05594. >>> >> >> Please add detail on what this patch is fixing and why we are >> reverting this >> commit. The current description gives zero information on why we are >> doing this. > > > To add more... am65 is now failing again with this patch reverted. So, > NAK on taking this revert. Someone needs to actually fix the am65 issue > that made us disable this in the first place. Actually, it looks like this patch also requires a uboot patch to work. I'll hold off looking at this then. > > >> regards >> Suman >> >> >>> [0]: >>> https://lore.kernel.org/all/20250626-b4-upstream-fix-icssg-fit-v1-1-95eff1c853a4@ti.com/ >>> >>> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> >>> --- >>> meta-ti-bsp/conf/machine/include/k3.inc | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/meta-ti-bsp/conf/machine/include/k3.inc >>> b/meta-ti-bsp/conf/machine/include/k3.inc >>> index 9b85f867c206..14d7db8a1184 100644 >>> --- a/meta-ti-bsp/conf/machine/include/k3.inc >>> +++ b/meta-ti-bsp/conf/machine/include/k3.inc >>> @@ -25,6 +25,10 @@ SPL_BINARY = "tispl.bin" >>> SPL_BINARYNAME = "tispl.bin" >>> UBOOT_SUFFIX = "img" >>> +UBOOT_SIGN_ENABLE = "1" >>> +UBOOT_MKIMAGE_DTCOPTS = "-I dts -O dtb" >>> +UBOOT_SIGN_KEYNAME ?= "custMpk" >>> +UBOOT_SIGN_KEYDIR ?= "${TI_SECURE_DEV_PKG}/keys" >>> FIT_HASH_ALG ?= "sha512" >>> FIT_SIGN_ALG ?= "rsa4096" >>> >>> >>> >>> >>> >> > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#18694): https://lists.yoctoproject.org/g/meta-ti/message/18694 > Mute This Topic: https://lists.yoctoproject.org/mt/113841171/6551054 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc index 9b85f867c206..14d7db8a1184 100644 --- a/meta-ti-bsp/conf/machine/include/k3.inc +++ b/meta-ti-bsp/conf/machine/include/k3.inc @@ -25,6 +25,10 @@ SPL_BINARY = "tispl.bin" SPL_BINARYNAME = "tispl.bin" UBOOT_SUFFIX = "img" +UBOOT_SIGN_ENABLE = "1" +UBOOT_MKIMAGE_DTCOPTS = "-I dts -O dtb" +UBOOT_SIGN_KEYNAME ?= "custMpk" +UBOOT_SIGN_KEYDIR ?= "${TI_SECURE_DEV_PKG}/keys" FIT_HASH_ALG ?= "sha512" FIT_SIGN_ALG ?= "rsa4096"
The following revert requires a patch in U-boot as well which has been posted upstream [0] and backported internally too. This reverts commit 9656b79cb557a46d2611b67e7e51702f6da05594. [0]: https://lore.kernel.org/all/20250626-b4-upstream-fix-icssg-fit-v1-1-95eff1c853a4@ti.com/ Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com> --- meta-ti-bsp/conf/machine/include/k3.inc | 4 ++++ 1 file changed, 4 insertions(+)