| Message ID | 20250523190054.691771-1-lcpdbld@list.ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,scarthgap] CI/CD Auto-Merger: cicd.scarthgap.202505230901 | expand |
Apparently, this went unnoticed, as nobody usually reviews CI/CD updates... On Fri, May 23, 2025 at 02:00:54PM -0500, LCPD Automation Script via lists.yoctoproject.org wrote: > Updated the value(s) for: > cnm-wave-fw: LIC_FILES_CHKSUM > ti-linux-fw: CNM_WAVE521_FW_VERSION,TI_LINUX_FW_SRCREV > u-boot-ti-staging_2025.01: SRCREV > k3conf: SRCREV > linux-ti-staging_6.12: PV,SRCREV > > Changelogs: > ti-linux-fw: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/log/?qt=range&q=bffa52a1b8d3318ec86814047025e7c5edf7b7b0..d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7 > u-boot-ti-staging_2025.01: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/log/?qt=range&q=98b6b3f5a259be864e8db92f4925c3c19c3482a4..3d024809613c2a8f1d69258554ab8954d26537f5 > k3conf: https://git.ti.com/cgit/k3conf/k3conf/log/?qt=range&q=e4a814ff42ef357ee453b6f2f809ecdfa624aa8c..ea9938bf9cafd9c0cb05ef060a713ab4ac72270f > linux-ti-staging_6.12: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?qt=range&q=013211ccdf5ec33e19652be631b820bc5f6b86a4..d95b7f80f66d104525e6beb002d82a9505b28131 > > Signed-off-by: LCPD Automation Script <lcpdbld@list.ti.com> > --- > meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 +- > meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 4 ++-- > meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb | 2 +- > meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb | 2 +- > meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb | 4 ++-- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > index 43624183..6a65992f 100644 > --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > @@ -5,7 +5,7 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc > inherit update-alternatives > > LICENSE = "BSD-3-Clause" > -LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=93b67e6bac7f8fec22b96b8ad0a1a9d0" > +LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=df3992006621b797e36de43f36336e36" What are the actual changes in the license that caused the checksum update? Did the license change from BSD-3-Clause to something else? Was the package re-licensed under something else, say more restrictive, or even commercial? Sure, I'm imagining a worst-case scenario, but the whole purpose of this LIC_FILES_CHKSUM variable is to catch such cases. So, whenever it changes, there should be an explanation in the commit message detailing the reason for the license checksum change. Moreover, in master there's now a mandatory tag required to explain such a change: https://docs.yoctoproject.org/next/contributor-guide/recipe-style-guide.html#license-updates In OE-Core this gets checked by test_lic_files_chksum_modified_not_mentioned Patchtest case and the patch gets automatically rejected w/o this tag: https://wiki.yoctoproject.org/wiki/Patchtest I would argue that CI/CD should not even try to modify LIC_FILES_CHKSUM variable in automated fashion - this was designed to be consciously updated by a human... > PV = "${CNM_WAVE521_FW_VERSION}" > PR = "${INC_PR}.1" > diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc > index 925f81fe..adc7afa1 100644 > --- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc > +++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc > @@ -13,12 +13,12 @@ PRUETH_FW_AM65X_SR2_VERSION = "02.02.15.04" > GOODIX_FW_VERSION = "1.0.0.0" > CADENCE_MHDP_FW_VERSION = "2.1.0" > IMG_DEC_FW_VERSION = "1.0" > -CNM_WAVE521_FW_VERSION = "1.0.7" > +CNM_WAVE521_FW_VERSION = "1.0.8" > TI_DM_FW_VERSION = "11.00.09" > TI_SYSFW_VERSION = "11.00.07" > TI_HSM_DEMO_FW_VERSION = "11.00.09" > > -TI_LINUX_FW_SRCREV ?= "bffa52a1b8d3318ec86814047025e7c5edf7b7b0" > +TI_LINUX_FW_SRCREV ?= "d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7" > SRCREV = "${TI_LINUX_FW_SRCREV}" > > BRANCH ?= "ti-linux-firmware" > diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb > index fb5dfa73..99a2c8fc 100644 > --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb > +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb > @@ -6,4 +6,4 @@ PR = "r0" > > BRANCH = "ti-u-boot-2025.01" > > -SRCREV = "98b6b3f5a259be864e8db92f4925c3c19c3482a4" > +SRCREV = "3d024809613c2a8f1d69258554ab8954d26537f5" > diff --git a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb > index 8e83a1aa..8691e523 100644 > --- a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb > +++ b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb > @@ -10,7 +10,7 @@ PV = "0.3+git" > COMPATIBLE_MACHINE = "k3" > > BRANCH ?= "master" > -SRCREV = "e4a814ff42ef357ee453b6f2f809ecdfa624aa8c" > +SRCREV = "ea9938bf9cafd9c0cb05ef060a713ab4ac72270f" > > SRC_URI = "git://git.ti.com/git/k3conf/k3conf.git;protocol=https;branch=${BRANCH}" > > diff --git a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb > index 535a96f8..f399c207 100644 > --- a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb > +++ b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb > @@ -23,8 +23,8 @@ S = "${WORKDIR}/git" > > BRANCH ?= "ti-linux-6.12.y" > > -SRCREV ?= "013211ccdf5ec33e19652be631b820bc5f6b86a4" > -PV = "6.12.23+git" > +SRCREV ?= "d95b7f80f66d104525e6beb002d82a9505b28131" > +PV = "6.12.24+git" > > # Special configuration for remoteproc/rpmsg IPC modules > module_conf_rpmsg_client_sample = "blacklist rpmsg_client_sample" > -- > 2.43.5
On 5/29/2025 2:45 PM, Denys Dmytriyenko wrote: > Apparently, this went unnoticed, as nobody usually reviews CI/CD updates... > > > On Fri, May 23, 2025 at 02:00:54PM -0500, LCPD Automation Script via lists.yoctoproject.org wrote: >> Updated the value(s) for: >> cnm-wave-fw: LIC_FILES_CHKSUM >> ti-linux-fw: CNM_WAVE521_FW_VERSION,TI_LINUX_FW_SRCREV >> u-boot-ti-staging_2025.01: SRCREV >> k3conf: SRCREV >> linux-ti-staging_6.12: PV,SRCREV >> >> Changelogs: >> ti-linux-fw: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/log/?qt=range&q=bffa52a1b8d3318ec86814047025e7c5edf7b7b0..d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7 >> u-boot-ti-staging_2025.01: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/log/?qt=range&q=98b6b3f5a259be864e8db92f4925c3c19c3482a4..3d024809613c2a8f1d69258554ab8954d26537f5 >> k3conf: https://git.ti.com/cgit/k3conf/k3conf/log/?qt=range&q=e4a814ff42ef357ee453b6f2f809ecdfa624aa8c..ea9938bf9cafd9c0cb05ef060a713ab4ac72270f >> linux-ti-staging_6.12: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?qt=range&q=013211ccdf5ec33e19652be631b820bc5f6b86a4..d95b7f80f66d104525e6beb002d82a9505b28131 >> >> Signed-off-by: LCPD Automation Script <lcpdbld@list.ti.com> >> --- >> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 +- >> meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 4 ++-- >> meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb | 2 +- >> meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb | 2 +- >> meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb | 4 ++-- >> 5 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> index 43624183..6a65992f 100644 >> --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> @@ -5,7 +5,7 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc >> inherit update-alternatives >> >> LICENSE = "BSD-3-Clause" >> -LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=93b67e6bac7f8fec22b96b8ad0a1a9d0" >> +LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=df3992006621b797e36de43f36336e36" > > What are the actual changes in the license that caused the checksum update? > > Did the license change from BSD-3-Clause to something else? Was the package > re-licensed under something else, say more restrictive, or even commercial? There was a update in License file adding more restrictive language primarily on wave633c codec fw ( not present on TI parts) Ref: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/LICENCE.cnm?id=c97a2ef501be047a901764735147a278999c8ff0 > > Sure, I'm imagining a worst-case scenario, but the whole purpose of this > LIC_FILES_CHKSUM variable is to catch such cases. So, whenever it changes, > there should be an explanation in the commit message detailing the reason > for the license checksum change. > > Moreover, in master there's now a mandatory tag required to explain such a > change: > https://docs.yoctoproject.org/next/contributor-guide/recipe-style-guide.html#license-updates > > In OE-Core this gets checked by test_lic_files_chksum_modified_not_mentioned > Patchtest case and the patch gets automatically rejected w/o this tag: > https://wiki.yoctoproject.org/wiki/Patchtest > > I would argue that CI/CD should not even try to modify LIC_FILES_CHKSUM > variable in automated fashion - this was designed to be consciously updated > by a human... > > >> PV = "${CNM_WAVE521_FW_VERSION}" >> PR = "${INC_PR}.1" >> diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc >> index 925f81fe..adc7afa1 100644 >> --- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc >> +++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc >> @@ -13,12 +13,12 @@ PRUETH_FW_AM65X_SR2_VERSION = "02.02.15.04" >> GOODIX_FW_VERSION = "1.0.0.0" >> CADENCE_MHDP_FW_VERSION = "2.1.0" >> IMG_DEC_FW_VERSION = "1.0" >> -CNM_WAVE521_FW_VERSION = "1.0.7" >> +CNM_WAVE521_FW_VERSION = "1.0.8" >> TI_DM_FW_VERSION = "11.00.09" >> TI_SYSFW_VERSION = "11.00.07" >> TI_HSM_DEMO_FW_VERSION = "11.00.09" >> >> -TI_LINUX_FW_SRCREV ?= "bffa52a1b8d3318ec86814047025e7c5edf7b7b0" >> +TI_LINUX_FW_SRCREV ?= "d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7" >> SRCREV = "${TI_LINUX_FW_SRCREV}" >> >> BRANCH ?= "ti-linux-firmware" >> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb >> index fb5dfa73..99a2c8fc 100644 >> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb >> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb >> @@ -6,4 +6,4 @@ PR = "r0" >> >> BRANCH = "ti-u-boot-2025.01" >> >> -SRCREV = "98b6b3f5a259be864e8db92f4925c3c19c3482a4" >> +SRCREV = "3d024809613c2a8f1d69258554ab8954d26537f5" >> diff --git a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb >> index 8e83a1aa..8691e523 100644 >> --- a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb >> +++ b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb >> @@ -10,7 +10,7 @@ PV = "0.3+git" >> COMPATIBLE_MACHINE = "k3" >> >> BRANCH ?= "master" >> -SRCREV = "e4a814ff42ef357ee453b6f2f809ecdfa624aa8c" >> +SRCREV = "ea9938bf9cafd9c0cb05ef060a713ab4ac72270f" >> >> SRC_URI = "git://git.ti.com/git/k3conf/k3conf.git;protocol=https;branch=${BRANCH}" >> >> diff --git a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb >> index 535a96f8..f399c207 100644 >> --- a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb >> +++ b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb >> @@ -23,8 +23,8 @@ S = "${WORKDIR}/git" >> >> BRANCH ?= "ti-linux-6.12.y" >> >> -SRCREV ?= "013211ccdf5ec33e19652be631b820bc5f6b86a4" >> -PV = "6.12.23+git" >> +SRCREV ?= "d95b7f80f66d104525e6beb002d82a9505b28131" >> +PV = "6.12.24+git" >> >> # Special configuration for remoteproc/rpmsg IPC modules >> module_conf_rpmsg_client_sample = "blacklist rpmsg_client_sample" >> -- >> 2.43.5
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb index 43624183..6a65992f 100644 --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb @@ -5,7 +5,7 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc inherit update-alternatives LICENSE = "BSD-3-Clause" -LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=93b67e6bac7f8fec22b96b8ad0a1a9d0" +LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=df3992006621b797e36de43f36336e36" PV = "${CNM_WAVE521_FW_VERSION}" PR = "${INC_PR}.1" diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc index 925f81fe..adc7afa1 100644 --- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc +++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc @@ -13,12 +13,12 @@ PRUETH_FW_AM65X_SR2_VERSION = "02.02.15.04" GOODIX_FW_VERSION = "1.0.0.0" CADENCE_MHDP_FW_VERSION = "2.1.0" IMG_DEC_FW_VERSION = "1.0" -CNM_WAVE521_FW_VERSION = "1.0.7" +CNM_WAVE521_FW_VERSION = "1.0.8" TI_DM_FW_VERSION = "11.00.09" TI_SYSFW_VERSION = "11.00.07" TI_HSM_DEMO_FW_VERSION = "11.00.09" -TI_LINUX_FW_SRCREV ?= "bffa52a1b8d3318ec86814047025e7c5edf7b7b0" +TI_LINUX_FW_SRCREV ?= "d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7" SRCREV = "${TI_LINUX_FW_SRCREV}" BRANCH ?= "ti-linux-firmware" diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb index fb5dfa73..99a2c8fc 100644 --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb @@ -6,4 +6,4 @@ PR = "r0" BRANCH = "ti-u-boot-2025.01" -SRCREV = "98b6b3f5a259be864e8db92f4925c3c19c3482a4" +SRCREV = "3d024809613c2a8f1d69258554ab8954d26537f5" diff --git a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb index 8e83a1aa..8691e523 100644 --- a/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb +++ b/meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb @@ -10,7 +10,7 @@ PV = "0.3+git" COMPATIBLE_MACHINE = "k3" BRANCH ?= "master" -SRCREV = "e4a814ff42ef357ee453b6f2f809ecdfa624aa8c" +SRCREV = "ea9938bf9cafd9c0cb05ef060a713ab4ac72270f" SRC_URI = "git://git.ti.com/git/k3conf/k3conf.git;protocol=https;branch=${BRANCH}" diff --git a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb index 535a96f8..f399c207 100644 --- a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb +++ b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb @@ -23,8 +23,8 @@ S = "${WORKDIR}/git" BRANCH ?= "ti-linux-6.12.y" -SRCREV ?= "013211ccdf5ec33e19652be631b820bc5f6b86a4" -PV = "6.12.23+git" +SRCREV ?= "d95b7f80f66d104525e6beb002d82a9505b28131" +PV = "6.12.24+git" # Special configuration for remoteproc/rpmsg IPC modules module_conf_rpmsg_client_sample = "blacklist rpmsg_client_sample"
Updated the value(s) for: cnm-wave-fw: LIC_FILES_CHKSUM ti-linux-fw: CNM_WAVE521_FW_VERSION,TI_LINUX_FW_SRCREV u-boot-ti-staging_2025.01: SRCREV k3conf: SRCREV linux-ti-staging_6.12: PV,SRCREV Changelogs: ti-linux-fw: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/log/?qt=range&q=bffa52a1b8d3318ec86814047025e7c5edf7b7b0..d5a6aed56d76f7a8a7729f0d0b4655b7e623e1c7 u-boot-ti-staging_2025.01: https://git.ti.com/cgit/ti-u-boot/ti-u-boot/log/?qt=range&q=98b6b3f5a259be864e8db92f4925c3c19c3482a4..3d024809613c2a8f1d69258554ab8954d26537f5 k3conf: https://git.ti.com/cgit/k3conf/k3conf/log/?qt=range&q=e4a814ff42ef357ee453b6f2f809ecdfa624aa8c..ea9938bf9cafd9c0cb05ef060a713ab4ac72270f linux-ti-staging_6.12: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?qt=range&q=013211ccdf5ec33e19652be631b820bc5f6b86a4..d95b7f80f66d104525e6beb002d82a9505b28131 Signed-off-by: LCPD Automation Script <lcpdbld@list.ti.com> --- meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 +- meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 4 ++-- meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2025.01.bb | 2 +- meta-ti-bsp/recipes-devtools/k3conf/k3conf_git.bb | 2 +- meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.12.bb | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-)